You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2016/06/07 03:57:50 UTC

[GitHub] incubator-gearpump pull request #36: fix GEARPUMP-155, integration test fail...

GitHub user manuzhang opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/36

    fix GEARPUMP-155, integration test failure

    Changes include:
    
    1. fix integration test
    2. `DistShellAppMaster` and `DistServiceAppMaster` send `ActivateAppMaster(appId)`  message to master when all the executor systems have been launched
    3. fix warning 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/incubator-gearpump GERRPUMP-155

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #36
    
----
commit 0322be3dd14aa8aa8d19e9a0c42f92266ca1c986
Author: manuzhang <ow...@gmail.com>
Date:   2016-06-07T03:57:15Z

    fix GEARPUMP-155, integration test failure

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #36: fix GEARPUMP-155, integration test failure

Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/36
  
    ## [Current coverage][cc-pull] is **65.56%**
    > Merging [#36][cc-pull] into [master][cc-base-branch] will increase coverage by **1.21%**
    
    1. 7 files (not in diff) in `...apache/gearpump/util` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/0322be3dd14aa8aa8d19e9a0c42f92266ca1c986/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F7574696C) 
      - Misses `-6` 
      - Hits `+6`
    1. 2 files (not in diff) in `...rpump/cluster/client` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/0322be3dd14aa8aa8d19e9a0c42f92266ca1c986/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F636C69656E74) 
      - Misses `-43` 
      - Hits `+43`
    1. 5 files (not in diff) in `...che/gearpump/cluster` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/0322be3dd14aa8aa8d19e9a0c42f92266ca1c986/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C7573746572) 
      - Misses `-20` 
      - Hits `+20`
    1. File `...ntStoreFactory.scala` (not in diff) was modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/0322be3dd14aa8aa8d19e9a0c42f92266ca1c986/changes?src=pr#65787465726E616C2F6861646F6F7066732F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6861646F6F702F4861646F6F70436865636B706F696E7453746F7265466163746F72792E7363616C61) 
      - Misses `-2` 
      - Partials `0` 
      - Hits `+2`
    1. File `...cutor/Executor.scala` (not in diff) was modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/0322be3dd14aa8aa8d19e9a0c42f92266ca1c986/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6578656375746F722F4578656375746F722E7363616C61) 
      - Misses `-1` 
      - Partials `0` 
      - Hits `+1`
    
    ```diff
    @@             master        #36   diff @@
    ==========================================
      Files           178        178          
      Lines          5922       5924     +2   
      Methods        5644       5645     +1   
      Messages          0          0          
      Branches        278        279     +1   
    ==========================================
    + Hits           3811       3884    +73   
    + Misses         2111       2040    -71   
      Partials          0          0          
    ```
    
    [![Sunburst](https://codecov.io/gh/apache/incubator-gearpump/pull/36/graphs/sunburst.svg?size=150&src=pr)][cc-pull]
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [ae32049...0322be3][cc-compare]
    [cc-base-branch]: https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr
    [cc-compare]: https://codecov.io/gh/apache/incubator-gearpump/compare/ae3204930e93bac5a64ea561ad16c67cdc44da0f...0322be3dd14aa8aa8d19e9a0c42f92266ca1c986
    [cc-pull]: https://codecov.io/gh/apache/incubator-gearpump/pull/36?src=pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #36: fix GEARPUMP-155, integration test failure

Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/36
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #36: fix GEARPUMP-155, integration test fail...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-gearpump/pull/36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---