You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/11/11 23:59:43 UTC
Review Request 71749: Added a test for AsV1Protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71749/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu.
Bugs: MESOS-10026
https://issues.apache.org/jira/browse/MESOS-10026
Repository: mesos
Description
-------
Added a test for AsV1Protobuf.
Diffs
-----
src/tests/common/http_tests.cpp 51c809d70d364530b4c7845f9382610c2eeef366
Diff: https://reviews.apache.org/r/71749/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 71749: Added a test for AsV1Protobuf.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71749/
-----------------------------------------------------------
(Updated Nov. 22, 2019, 6:08 p.m.)
Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu.
Changes
-------
* Added a comprehensive .proto file for covering the cases.
Bugs: MESOS-10026
https://issues.apache.org/jira/browse/MESOS-10026
Repository: mesos
Description
-------
Added a test for AsV1Protobuf.
Diffs (updated)
-----
src/Makefile.am 0e57b28bce7d7846c6aee11215572d2f660b7495
src/tests/CMakeLists.txt 0a3c176d1bafc5445840146a1dd19a0825cab04d
src/tests/common/http_tests.cpp 51c809d70d364530b4c7845f9382610c2eeef366
src/tests/common/http_tests.pb.h PRE-CREATION
src/tests/common/http_tests.pb.cc PRE-CREATION
src/tests/common/http_tests.proto PRE-CREATION
Diff: https://reviews.apache.org/r/71749/diff/2/
Changes: https://reviews.apache.org/r/71749/diff/1-2/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 71749: Added a test for AsV1Protobuf.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71749/#review218677
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/common/http_tests.cpp
Lines 269 (patched)
<https://reviews.apache.org/r/71749/#comment306543>
How about covering nested MESSAGE (repeated and map/non-repeated) and repeated ENUM? (see my comment in r71748)
Not sure if we have all of those in our protobufs (adding a new `.proto` file for this test would be an overkill IMO), but at least we have a repeated-message-inside-nested with a `slave_id` in `scheduler::Call` (`Call::ReconcileOperations`).
- Andrei Sekretenko
On Nov. 11, 2019, 11:59 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71749/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2019, 11:59 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu.
>
>
> Bugs: MESOS-10026
> https://issues.apache.org/jira/browse/MESOS-10026
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test for AsV1Protobuf.
>
>
> Diffs
> -----
>
> src/tests/common/http_tests.cpp 51c809d70d364530b4c7845f9382610c2eeef366
>
>
> Diff: https://reviews.apache.org/r/71749/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>