You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by "tkowalcz (via GitHub)" <gi...@apache.org> on 2024/08/02 13:41:54 UTC
[PR] Destroy forcibly forked test using SIGKILL [ant]
tkowalcz opened a new pull request, #211:
URL: https://github.com/apache/ant/pull/211
If the JVM of the monitored forked test hangs then `Process:destroy` might not be effective. On unix systems it will send `SIGINT`. An alternative is to use `Process: destroyForcibly` method to use `SIGKILL`.
Using `SIGKILL` will not allow the monitored process to cleanly shutdown, but the question is if it already timed out then it will probably never do any cleanup.
Alternatively watchdog could try `destroy` first and then `destroyForcibly`.
Comments?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Destroy forcibly forked test using SIGKILL [ant]
Posted by "jaikiran (via GitHub)" <gi...@apache.org>.
jaikiran commented on PR #211:
URL: https://github.com/apache/ant/pull/211#issuecomment-2266712802
Hello Tomasz, can you tell us the details of the issue you are running into? That might help understand what change needs to be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Destroy forcibly forked test using SIGKILL [ant]
Posted by "jaikiran (via GitHub)" <gi...@apache.org>.
jaikiran commented on PR #211:
URL: https://github.com/apache/ant/pull/211#issuecomment-2281827658
Hello Tomasz,
> Tools like jstack were unable to attach to it unless -Force option was used.
Were you able to get hold of a thread dump with `-F`?
This code dealing with process termination resides in a core layer of Ant and has been around for a long time. So having as much details as possible to see what's causing this issue will help understand if this code deserves a change or if we should address this in a different manner (perhaps in the junitlauncher task specific code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Destroy forcibly forked test using SIGKILL [ant]
Posted by "tkowalcz (via GitHub)" <gi...@apache.org>.
tkowalcz commented on PR #211:
URL: https://github.com/apache/ant/pull/211#issuecomment-2267496463
> Hello Tomasz, can you tell us the details of the issue you are running into? That might help understand what change needs to be done.
Absolutely. I just wanted to get the conversation started. Thanks for taking time to reply.
When using `junitlauncher` with timeout:
```xml
<junitlauncher
taskname="JUnit5"
haltonfailure="${junit.haltonfailure}"
failureproperty="junit.failures"
printsummary="false">
...
<fork timeout="${junit.timeout}">
...
</fork>
</junitlauncher>
```
it setups `ExecuteWatchdog` that will terminate the forked process after timeout passes. If the forked JVM is very busy (e.g. doing GC back to back) it will not terminate (it has the signal handler installed but fails to act upon receiving the signal). The only option is to issue a SIGKILL.
In our case we had the JVM stuck for yet to be discovered reason. Tools like `jstack` were unable to attach to it unless `-F`orce option was used. The CI job that was running test suite got stuck waiting for `ant` task to time out but it never did. Eventually job level timeout of Jenkins kicked in and terminated the parent process.
I was able to verify following - sending `SIGINT` to the forked JVM did not shut it down. Sending `SIGKILL` did and the `junitlauncher` properly continued - set `failureproperty` and continued if `haltonfailure` was set to false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org