You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2016/07/27 11:26:06 UTC

[GitHub] flink pull request #2302: [hotfix] [metrics] Refactor constructors and tests

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/2302

    [hotfix] [metrics] Refactor constructors and tests

    Several `ComponentMetricGroup` classes had an additional constructor which took a `ScopeFormat` argument. This contructor was only used by tests. In this PR i removed them, as they did not made it any easier to test specific formats. By not going through the common channel (via the configuration) they in fact become more obscure imo.
    
    The following changes were made:
    - removed constructors taking a specific ScopeFormat as argument
    - refactored tests accordingly
    - made sure that the registry is shutdown in every test

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink metrics_constructors

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2302.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2302
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2302: [hotfix] [metrics] Refactor constructors and tests

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2302
  
    Looks good to merge from my side...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2302: [hotfix] [metrics] Refactor constructors and tests

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2302


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2302: [hotfix] [metrics] Refactor constructors and tests

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/2302
  
    merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---