You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/09 21:51:58 UTC
[jira] [Commented] (BOOKKEEPER-874) Explict LAC from Writer to
Bookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15736442#comment-15736442 ]
ASF GitHub Bot commented on BOOKKEEPER-874:
-------------------------------------------
GitHub user reddycharan opened a pull request:
https://github.com/apache/bookkeeper/pull/89
BOOKKEEPER-874: Explict LAC from Writer to Bookies
Introduce a new feature for sending explicit LAC to bookies.
A writable LedgerHandle creates a timer thread to send explicit LACs
at the intervals specified through configuration paramenter,
explicitLacInterval. If this is set to zero, this feature is disabled,
no timer thread is created.
Explicit LAC is sent only if the client did not get a chance to send
LAC through piggyback method for "explicitLacInterval" time.
To implement this, introduced two new protocol messages to the
Bookkeeper protocol - WRITE_LAC and READ_LAC, in addition to its
current READ_ENTRY and ADD_ENTRY.
Reviewed-by: Charan Reddy Guttapalem <cg...@salesforce.com>
Signed-off-by: Venkateswararao Jujjuri (JV) <vj...@salesforce.com>
Signed-off-by: Charan Reddy Guttapalem <cg...@salesforce.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/reddycharan/bookkeeper explicitlacsinglecommit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/89.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #89
----
commit d1db9f84aa17eaed97ed81304beb3afe35c4475f
Author: JV <vj...@salesforce.com>
Date: 2015-10-22T05:23:25Z
BOOKKEEPER-874: Explict LAC from Writer to Bookies
Introduce a new feature for sending explicit LAC to bookies.
A writable LedgerHandle creates a timer thread to send explicit LACs
at the intervals specified through configuration paramenter,
explicitLacInterval. If this is set to zero, this feature is disabled,
no timer thread is created.
Explicit LAC is sent only if the client did not get a chance to send
LAC through piggyback method for "explicitLacInterval" time.
To implement this, introduced two new protocol messages to the
Bookkeeper protocol - WRITE_LAC and READ_LAC, in addition to its
current READ_ENTRY and ADD_ENTRY.
Reviewed-by: Charan Reddy Guttapalem <cg...@salesforce.com>
Signed-off-by: Venkateswararao Jujjuri (JV) <vj...@salesforce.com>
Signed-off-by: Charan Reddy Guttapalem <cg...@salesforce.com>
----
> Explict LAC from Writer to Bookies
> ----------------------------------
>
> Key: BOOKKEEPER-874
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-874
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Venkateswararao Jujjuri (JV)
> Assignee: Venkateswararao Jujjuri (JV)
>
> Current client API piggy-backs LAC with a write. This is keeps reader one behind the writer. In order to keep reader up to date with writer even when there is a pause in write, proposing the following:
> Writer sends explicit LAC on a configured timeout if there is no write within that period.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)