[GitHub] spark pull request: [SPARK-6545][SQL][WIP] Minor changes

[marmbrus <gi...@git.apache.org>]

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5199#discussion_r28199545
  
    --- Diff: core/src/main/scala/org/apache/spark/util/collection/CompactBuffer.scala ---
    @@ -152,6 +152,20 @@ private[spark] class CompactBuffer[T: ClassTag] extends Seq[T] with Serializable
     }
     
     private[spark] object CompactBuffer {
    +  def constantEmpty[T: ClassTag](): CompactBuffer[T] = new CompactBuffer[T] {
    --- End diff --
    
    Is this really worth creating a new class for?  Creating new subclasses can actually affect how JIT is going to inline things so might end up degrading performance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org