You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "xinrong-meng (via GitHub)" <gi...@apache.org> on 2023/03/10 00:41:41 UTC
[GitHub] [spark] xinrong-meng opened a new pull request, #40357: [SPARK-42739][BUILD] Ensure release tag to be pushed to release branch
xinrong-meng opened a new pull request, #40357:
URL: https://github.com/apache/spark/pull/40357
### What changes were proposed in this pull request?
In the release script, add a check to ensure release tag to be pushed to release branch.
### Why are the changes needed?
To ensure the success of a RC cut. Otherwise, release conductors have to manually check that.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40357: [SPARK-42739][BUILD] Ensure release tag to be pushed to release branch
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #40357:
URL: https://github.com/apache/spark/pull/40357#discussion_r1131893994
##########
dev/create-release/release-tag.sh:
##########
@@ -122,6 +122,12 @@ if ! is_dry_run; then
git push origin $RELEASE_TAG
if [[ $RELEASE_VERSION != *"preview"* ]]; then
git push origin HEAD:$GIT_BRANCH
Review Comment:
Hm, so to clarify, we set `set -e` on the top, meaning that the script will fail immediately if any command fails with non-zero exit.
I assume that there's a case when `git push origin $RELEASE_TAG` and `git push origin HEAD:$GIT_BRANCH` are successfully executed but the tag still doesn't exist? If that's the case LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-meng closed pull request #40357: [WIP][SPARK-42739][BUILD] Ensure release tag to be pushed to release branch
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng closed pull request #40357: [WIP][SPARK-42739][BUILD] Ensure release tag to be pushed to release branch
URL: https://github.com/apache/spark/pull/40357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-meng commented on a diff in pull request #40357: [SPARK-42739][BUILD] Ensure release tag to be pushed to release branch
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on code in PR #40357:
URL: https://github.com/apache/spark/pull/40357#discussion_r1131900698
##########
dev/create-release/release-tag.sh:
##########
@@ -122,6 +122,12 @@ if ! is_dry_run; then
git push origin $RELEASE_TAG
if [[ $RELEASE_VERSION != *"preview"* ]]; then
git push origin HEAD:$GIT_BRANCH
Review Comment:
When `git push origin HEAD:$GIT_BRANCH` doesn't succeed, the PR proposes to call out the exact error instead of failing silently.
In addition, the reason why we have to `| grep origin` is that, `git branch -r --contains tags/_d_tag` exits 0 even if `git push origin HEAD:$GIT_BRANCH` doesn't execute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-meng commented on pull request #40357: [SPARK-42739][BUILD] Ensure release tag to be pushed to release branch
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on PR #40357:
URL: https://github.com/apache/spark/pull/40357#issuecomment-1463187698
Merged to master and branch-3.4, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-meng closed pull request #40357: [SPARK-42739][BUILD] Ensure release tag to be pushed to release branch
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng closed pull request #40357: [SPARK-42739][BUILD] Ensure release tag to be pushed to release branch
URL: https://github.com/apache/spark/pull/40357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #40357: [SPARK-42739][BUILD] Ensure release tag to be pushed to release branch
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #40357:
URL: https://github.com/apache/spark/pull/40357#issuecomment-1463260567
Thank you, @xinrong-meng and @HyukjinKwon .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org