[jira] [Commented] (THRIFT-4219) Golang HTTP clients created with Nil buffer

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071257#comment-16071257 ] 

ASF GitHub Bot commented on THRIFT-4219:
----------------------------------------

Github user Jens-G commented on the issue:

    https://github.com/apache/thrift/pull/1287
  
    If nobody else wants to vote against it, I'll commit this soon. 


> Golang HTTP clients created with Nil buffer
> -------------------------------------------
>
>                 Key: THRIFT-4219
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4219
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Library
>            Reporter: James Mouradian
>            Assignee: Can Celasun
>
> As of 2b1b32c, [{{NewTHttpClientWithOptions}}|https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go#L93] creates a {{THttpClient}} instance with a nil {{requestBuffer}}. This causes a panic when the instance attempts to write to the buffer.
> A patch probably fits well with THRIFT-4215 and THRIFT-4216.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)