[GitHub] zeppelin issue #1921: [ZEPPELIN-1984] Zeppelin Server doesn't catch all exce...

[Tagar <gi...@git.apache.org>]

Github user Tagar commented on the issue:

    https://github.com/apache/zeppelin/pull/1921
  
    I've tested Zeppelin with this one-line 42b02bd
    commit change and now RemoteInterpreterManagedProcess.java correctly gets return code as 1, notice `Process exited with an error: 1`
    
    >  INFO [2017-01-20 15:31:06,710] ({Exec Default Executor} RemoteInterpreterManagedProcess.java[onProcessFailed]:171) - Interpreter process failed {}
    > org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1)
    >         at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:404)
    >         at org.apache.commons.exec.DefaultExecutor.access$200(DefaultExecutor.java:48)
    >         at org.apache.commons.exec.DefaultExecutor$1.run(DefaultExecutor.java:200)
    >         at java.lang.Thread.run(Thread.java:745)
    > DEBUG [2017-01-20 15:31:07,070] ({pool-2-thread-2} RemoteInterpreterUtils.java[checkIfRemoteEndpointAccessible]:53) - Remote endpoint 'localhost:3044' is not accessible (might be initializing): Connection refuse
    > d
    > DEBUG [2017-01-20 15:31:07,570] ({pool-2-thread-2} RemoteInterpreterUtils.java[checkIfRemoteEndpointAccessible]:53) - Remote endpoint 'localhost:3044' is not accessible (might be initializing): Connection refuse
    > d
    > ... (connect attempts loop continues until timeout reached)
    
    but still you see that RemoteInterpreterManagedProcess.java is still falling into [connect attempts loop](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterManagedProcess.java#L130). So RemoteInterpreterManagedProcess.java ignores return code 1 (signaled from interpreter.sh as exit code that interpreter hasn't started). Will need somebody's help to add this logic too.
    
    Another possible improvement is that RemoteInterpreterManagedProcess could also catch root cause from logger, as you can see it does show up in the log: 
    
    > DEBUG [2017-01-20 15:31:06,685] ({Exec Stream Pumper} RemoteInterpreterManagedProcess.java[processLine]:189) - Exception in thread "main" org.apache.spark.SparkException: Keytab file: /home/someuser/.kt does not
    >  exist
    > 
    
    So then end-users wouldn't have to enable debugging to understand why interpreter isn't starting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---