You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2018/10/20 10:07:22 UTC

[Bug 62841] New: Refactor DeltaSession locking

https://bz.apache.org/bugzilla/show_bug.cgi?id=62841

            Bug ID: 62841
           Summary: Refactor DeltaSession locking
           Product: Tomcat 9
           Version: 9.0.x
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Cluster
          Assignee: dev@tomcat.apache.org
          Reporter: markt@apache.org
  Target Milestone: -----

Background: https://tomcat.markmail.org/thread/26rl3hs6wjzf7ssu

It would helpful in some scenarios to reduce the scope of the DeltaSession
lock.

Currently the sequence is:
- lock session
- serialize DeltaRequest to message
- recycle DeltaRequest
- unlock session
- send message

The proposed sequence is:
- lock session
- keep reference to populated DeltaRequest
- provide session with new DeltaRequest object
- unlock session
- serialize populated DeltaRequest to message
- send message

To avoid the expense of creating a new DeltaRequest each time, a pool of them
could be used which should minimise the garbage.

Looking at the sequence of events, I don't think this does much that is
likely to harm coherence.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62841] Refactor DeltaSession locking

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62841

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
Fixed in:
- master for 9.0.21 onwards
- 8.5.x for 8.5.42 onwards
- 7.0.x for 7.0.95 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org