You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/07 22:14:35 UTC
[GitHub] [airflow] merobi-hub opened a new pull request #20761: Add Python 3 requisite info to installation instructions.
merobi-hub opened a new pull request #20761:
URL: https://github.com/apache/airflow/pull/20761
New users installing Airflow for the first time may be unaware that Airflow currently supports only recent versions of Python 3. Also, successful installation requires Python 3. The mention of `pip` has been a clue to those who know it comes with Python 3, but others have been in the dark. Users unaware of what version of Python is in their path might be prompted to check -- and they may even be surprised to learn that their recent installation of Python defaulted to Python 2.
The Start guide for local installation does not currently mention this requirement, and users prompted to check their version of Python or upgrade to Python 3 will have a much better experience attempting to install Airflow locally.
This small change to the Start>Local doc adds the Python 3 requirement information in the note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #20761: Add Python 3 requisite info to installation instructions.
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #20761:
URL: https://github.com/apache/airflow/pull/20761#discussion_r780660059
##########
File path: docs/apache-airflow/start/local.rst
##########
@@ -24,6 +24,8 @@ This quick start guide will help you bootstrap an Airflow standalone instance on
.. note::
+ Successful installation requires a Python 3 environment. Airflow is currently tested with Python 3.6, 3.7, 3.8, and 3.9.
Review comment:
Does not seem to be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #20761: Add Python 3 requisite info to installation instructions.
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #20761:
URL: https://github.com/apache/airflow/pull/20761#issuecomment-1007779384
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] merobi-hub commented on pull request #20761: Add Python 3 requisite info to installation instructions.
Posted by GitBox <gi...@apache.org>.
merobi-hub commented on pull request #20761:
URL: https://github.com/apache/airflow/pull/20761#issuecomment-1008437846
Closed my PR due to issue with rebase. Also deleted branch. Starting over with new branch and PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] merobi-hub commented on a change in pull request #20761: Add Python 3 requisite info to installation instructions.
Posted by GitBox <gi...@apache.org>.
merobi-hub commented on a change in pull request #20761:
URL: https://github.com/apache/airflow/pull/20761#discussion_r780631020
##########
File path: docs/apache-airflow/start/local.rst
##########
@@ -24,6 +24,8 @@ This quick start guide will help you bootstrap an Airflow standalone instance on
.. note::
+ Successful installation requires a Python 3 environment. Airflow is currently tested with Python 3.6, 3.7, 3.8, and 3.9.
Review comment:
Thanks. Removed versions from new commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #20761: Add Python 3 requisite info to installation instructions.
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #20761:
URL: https://github.com/apache/airflow/pull/20761#discussion_r780624125
##########
File path: docs/apache-airflow/start/local.rst
##########
@@ -24,6 +24,8 @@ This quick start guide will help you bootstrap an Airflow standalone instance on
.. note::
+ Successful installation requires a Python 3 environment. Airflow is currently tested with Python 3.6, 3.7, 3.8, and 3.9.
Review comment:
I’d remove mentioning specifically what versions are tested since it’s too tedious to update this with every release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #20761: Add Python 3 requisite info to installation instructions.
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #20761:
URL: https://github.com/apache/airflow/pull/20761#discussion_r780624125
##########
File path: docs/apache-airflow/start/local.rst
##########
@@ -24,6 +24,8 @@ This quick start guide will help you bootstrap an Airflow standalone instance on
.. note::
+ Successful installation requires a Python 3 environment. Airflow is currently tested with Python 3.6, 3.7, 3.8, and 3.9.
Review comment:
I’d remove mentioning specifically what versions are tested since it’s too tedious to update this with every release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] merobi-hub commented on a change in pull request #20761: Add Python 3 requisite info to installation instructions.
Posted by GitBox <gi...@apache.org>.
merobi-hub commented on a change in pull request #20761:
URL: https://github.com/apache/airflow/pull/20761#discussion_r780631020
##########
File path: docs/apache-airflow/start/local.rst
##########
@@ -24,6 +24,8 @@ This quick start guide will help you bootstrap an Airflow standalone instance on
.. note::
+ Successful installation requires a Python 3 environment. Airflow is currently tested with Python 3.6, 3.7, 3.8, and 3.9.
Review comment:
Thanks. Removed versions from new commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #20761: Add Python 3 requisite info to installation instructions.
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #20761:
URL: https://github.com/apache/airflow/pull/20761#issuecomment-1007779384
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20761: Add Python 3 requisite info to installation instructions.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20761:
URL: https://github.com/apache/airflow/pull/20761#issuecomment-1008020880
Hmm. Now someting went wrong with rebase :( 44 files changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] merobi-hub closed pull request #20761: Add Python 3 requisite info to installation instructions.
Posted by GitBox <gi...@apache.org>.
merobi-hub closed pull request #20761:
URL: https://github.com/apache/airflow/pull/20761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org