You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/19 10:42:38 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6283: pthread/spinlock: Call up_testsest directly in the flat build

gustavonihei commented on code in PR #6283:
URL: https://github.com/apache/incubator-nuttx/pull/6283#discussion_r876901384


##########
include/nuttx/spinlock.h:
##########
@@ -107,28 +107,7 @@ typedef struct
  *
  ****************************************************************************/
 
-#if defined(CONFIG_ARCH_HAVE_TESTSET)
 spinlock_t up_testset(volatile FAR spinlock_t *lock);
-#elif !defined(CONFIG_SMP)

Review Comment:
   There is a change in the logic here, now this function will be built for SMP targets. Is this really intended?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org