You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/23 08:11:07 UTC
[GitHub] [incubator-doris] marising opened a new pull request #4159: [Feature][Cache]Add interface, cache coordinator, metric, variable and config for query cache
marising opened a new pull request #4159:
URL: https://github.com/apache/incubator-doris/pull/4159
## Proposed changes
#2581
1. Define the interface of Cache
2. The option of Config/Variable
3. Add metrics for cache monitor
## Types of change
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on [Doris's issues](https://github.com/apache/incubator-doris/issues), and have described the bug/feature there in detail
- [x] Commit messages in my PR start with the related issues ID, like "#4071 Add pull request template to doris project"
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #4159: [Feature][Cache]Add interface, cache coordinator, metric, variable and config for query cache
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #4159:
URL: https://github.com/apache/incubator-doris/pull/4159#discussion_r459311669
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/Config.java
##########
@@ -1117,5 +1117,34 @@
*/
@ConfField
public static String thrift_server_type = ThriftServer.THREAD_POOL;
-}
+
+ /**
+ * If set to true, fe will enable sql result cache
+ * This option is suitable for offline data update scenarios
+ * case1 case2 case3 case4
+ * enable_sql_cache false true true false
+ * enable_partition_cache false false true true
+ */
+ @ConfField(mutable = true, masterOnly = false)
+ public static boolean enable_sql_cache = false;
+
+ /**
+ * If set to true, fe will get data from be cache,
+ * This option is suitable for real-time updating of partial partitions.
+ */
+ @ConfField(mutable = true, masterOnly = false)
+ public static boolean enable_partition_cache = false;
Review comment:
Please add these configs to FE config doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen merged pull request #4159: [Feature][Cache]Add interface, cache coordinator, metric, variable and config for query cache
Posted by GitBox <gi...@apache.org>.
kangkaisen merged pull request #4159:
URL: https://github.com/apache/incubator-doris/pull/4159
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #4159: [Feature][Cache]Add interface, cache coordinator, metric, variable and config for query cache
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #4159:
URL: https://github.com/apache/incubator-doris/pull/4159#discussion_r459311392
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/Config.java
##########
@@ -1117,5 +1117,34 @@
*/
@ConfField
public static String thrift_server_type = ThriftServer.THREAD_POOL;
-}
+
+ /**
+ * If set to true, fe will enable sql result cache
+ * This option is suitable for offline data update scenarios
+ * case1 case2 case3 case4
+ * enable_sql_cache false true true false
+ * enable_partition_cache false false true true
+ */
+ @ConfField(mutable = true, masterOnly = false)
+ public static boolean enable_sql_cache = false;
Review comment:
All query cache config would better start with the same prefix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org