You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/25 05:31:55 UTC

[GitHub] [flink] Airblader opened a new pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Airblader opened a new pull request #16285:
URL: https://github.com/apache/flink/pull/16285


   ## What is the purpose of the change
   
   This implements `TableEnvironment#createTable(String, TableDescriptor)` as part of FLIP-129. It behaves the same as the previously introduced `#createTemporaryTable(String, TableDescriptor)` with the difference of actually going through the catalog to persist the table.
   
   ## Brief change log
   
   * Introduced new API method `TableEnvironment#createTable(String, TableDescriptor)`.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   * `CalcITCase#testCreateTableFromDescriptor`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? docs + JavaDocs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868253867


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518",
       "triggerID" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c3f475e4c4fcd8bbf0a7695c75630e444308eee1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868253867


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518",
       "triggerID" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19570",
       "triggerID" : "868964300",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "868964300",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9d1a4fc3434815eb1d2d2a54c714517f10c245ed",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19969",
       "triggerID" : "9d1a4fc3434815eb1d2d2a54c714517f10c245ed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "12b1974827a3e4066499ae47df2117afa983caa0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "12b1974827a3e4066499ae47df2117afa983caa0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9d1a4fc3434815eb1d2d2a54c714517f10c245ed Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19969) 
   * 12b1974827a3e4066499ae47df2117afa983caa0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868253867


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c3f475e4c4fcd8bbf0a7695c75630e444308eee1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868253867


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518",
       "triggerID" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c3f475e4c4fcd8bbf0a7695c75630e444308eee1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518) 
   * 3a7708ead7c69816ae9debe89df06f06abed3381 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] twalthr commented on a change in pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #16285:
URL: https://github.com/apache/flink/pull/16285#discussion_r663818201



##########
File path: docs/content.zh/docs/dev/table/common.md
##########
@@ -324,15 +324,18 @@ Such tables can either be created using the Table API directly, or by switching
 
 ```java
 // Using table descriptors
-tableEnv.createTemporaryTable("Source", TableDescriptor.forConnector("datagen")
+final TableDescriptor sourceDescriptor = TableDescriptor.forConnector("datagen")
     .schema(Schema.newBuilder()
-      .column("f0", DataTypes.STRING())
-      .build())
-    .option(DataGenOptions.ROWS_PER_SECOND, 100)
+    .column("f0", DataTypes.STRING())
     .build())
+    .option(DataGenOptions.ROWS_PER_SECOND, 100)
+    .build();
+
+    tableEnv.createTable("SourceTableA", sourceDescriptor);

Review comment:
       wrong indention for all lines that start with `tableEnv`

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala
##########
@@ -548,4 +549,24 @@ class CalcITCase extends StreamingTestBase {
     TestBaseUtils.compareResultAsText(result, "42")
   }
 
+  @Test

Review comment:
       I agree. Having one ITCase for descriptors was ok in the last PR. But we should not add more. We can extend `org.apache.flink.table.api.TableEnvironmentTest` and check what has been put into the in-memory catalog. 

##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -499,6 +499,21 @@ public void createTemporaryTable(String path, TableDescriptor descriptor) {
         catalogManager.createTemporaryTable(catalogTable, tableIdentifier, false);
     }
 
+    @Override
+    public void createTable(String path, TableDescriptor descriptor) {
+        final ObjectIdentifier tableIdentifier =

Review comment:
       add a null check similar to `createTemporaryTable`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] Airblader commented on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
Airblader commented on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868964300


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868253867


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518",
       "triggerID" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19570",
       "triggerID" : "868964300",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 3a7708ead7c69816ae9debe89df06f06abed3381 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19570) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] Airblader commented on a change in pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #16285:
URL: https://github.com/apache/flink/pull/16285#discussion_r664285145



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala
##########
@@ -548,4 +549,24 @@ class CalcITCase extends StreamingTestBase {
     TestBaseUtils.compareResultAsText(result, "42")
   }
 
+  @Test

Review comment:
       Sounds good. The only test case in there will be removed with this FLIP as well anyway. I'll also add one for createTemporaryTable so we have all APIs tested in there, plus the one IT case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868253867


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518",
       "triggerID" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c3f475e4c4fcd8bbf0a7695c75630e444308eee1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518) 
   * 3a7708ead7c69816ae9debe89df06f06abed3381 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868253867


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518",
       "triggerID" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c3f475e4c4fcd8bbf0a7695c75630e444308eee1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868253867


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518",
       "triggerID" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19570",
       "triggerID" : "868964300",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "868964300",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9d1a4fc3434815eb1d2d2a54c714517f10c245ed",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9d1a4fc3434815eb1d2d2a54c714517f10c245ed",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3a7708ead7c69816ae9debe89df06f06abed3381 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19570) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544) 
   * 9d1a4fc3434815eb1d2d2a54c714517f10c245ed UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868253867


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518",
       "triggerID" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19570",
       "triggerID" : "868964300",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "868964300",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 3a7708ead7c69816ae9debe89df06f06abed3381 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19570) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868222480


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 12b1974827a3e4066499ae47df2117afa983caa0 (Thu Sep 23 17:58:38 UTC 2021)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] twalthr closed pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #16285:
URL: https://github.com/apache/flink/pull/16285


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868222480


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c3f475e4c4fcd8bbf0a7695c75630e444308eee1 (Fri Jun 25 05:49:35 UTC 2021)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868253867






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868253867


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518",
       "triggerID" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19570",
       "triggerID" : "868964300",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "868964300",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 3a7708ead7c69816ae9debe89df06f06abed3381 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19570) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] Airblader commented on a change in pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #16285:
URL: https://github.com/apache/flink/pull/16285#discussion_r664285145



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala
##########
@@ -548,4 +549,24 @@ class CalcITCase extends StreamingTestBase {
     TestBaseUtils.compareResultAsText(result, "42")
   }
 
+  @Test

Review comment:
       Sounds good. The only test case in there will be removed with this FLIP as well anyway. I'll also add one for createTemporaryTable so we have all APIs tested in there, plus the one IT case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] twalthr commented on a change in pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #16285:
URL: https://github.com/apache/flink/pull/16285#discussion_r663818201



##########
File path: docs/content.zh/docs/dev/table/common.md
##########
@@ -324,15 +324,18 @@ Such tables can either be created using the Table API directly, or by switching
 
 ```java
 // Using table descriptors
-tableEnv.createTemporaryTable("Source", TableDescriptor.forConnector("datagen")
+final TableDescriptor sourceDescriptor = TableDescriptor.forConnector("datagen")
     .schema(Schema.newBuilder()
-      .column("f0", DataTypes.STRING())
-      .build())
-    .option(DataGenOptions.ROWS_PER_SECOND, 100)
+    .column("f0", DataTypes.STRING())
     .build())
+    .option(DataGenOptions.ROWS_PER_SECOND, 100)
+    .build();
+
+    tableEnv.createTable("SourceTableA", sourceDescriptor);

Review comment:
       wrong indention for all lines that start with `tableEnv`

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala
##########
@@ -548,4 +549,24 @@ class CalcITCase extends StreamingTestBase {
     TestBaseUtils.compareResultAsText(result, "42")
   }
 
+  @Test

Review comment:
       I agree. Having one ITCase for descriptors was ok in the last PR. But we should not add more. We can extend `org.apache.flink.table.api.TableEnvironmentTest` and check what has been put into the in-memory catalog. 

##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -499,6 +499,21 @@ public void createTemporaryTable(String path, TableDescriptor descriptor) {
         catalogManager.createTemporaryTable(catalogTable, tableIdentifier, false);
     }
 
+    @Override
+    public void createTable(String path, TableDescriptor descriptor) {
+        final ObjectIdentifier tableIdentifier =

Review comment:
       add a null check similar to `createTemporaryTable`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] Airblader commented on a change in pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #16285:
URL: https://github.com/apache/flink/pull/16285#discussion_r658610934



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala
##########
@@ -548,4 +549,24 @@ class CalcITCase extends StreamingTestBase {
     TestBaseUtils.compareResultAsText(result, "42")
   }
 
+  @Test

Review comment:
       I think it would be good to find a better place for the TableDescriptor-related tests. Acknowledging that they are expensive, can we create a TableDescriptorITCase if we get rid of another one? There seem to be some with a single test and no additional setup that could easily be transferred into `CalcITCase`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868253867


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518",
       "triggerID" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3a7708ead7c69816ae9debe89df06f06abed3381 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] Airblader commented on a change in pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #16285:
URL: https://github.com/apache/flink/pull/16285#discussion_r658610020



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala
##########
@@ -548,4 +549,24 @@ class CalcITCase extends StreamingTestBase {
     TestBaseUtils.compareResultAsText(result, "42")
   }
 
+  @Test
+  def testCreateTableFromDescriptor(): Unit = {
+    val rows = Seq(row(42))
+    val tableId = TestValuesTableFactory.registerData(rows)
+
+    tEnv.createTable("T", TableDescriptor.forConnector("values")

Review comment:
       We should make sure to delete this table again after the test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868253867


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518",
       "triggerID" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19570",
       "triggerID" : "868964300",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "868964300",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9d1a4fc3434815eb1d2d2a54c714517f10c245ed",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19969",
       "triggerID" : "9d1a4fc3434815eb1d2d2a54c714517f10c245ed",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9d1a4fc3434815eb1d2d2a54c714517f10c245ed Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19969) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868253867


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518",
       "triggerID" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19570",
       "triggerID" : "868964300",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "868964300",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9d1a4fc3434815eb1d2d2a54c714517f10c245ed",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19969",
       "triggerID" : "9d1a4fc3434815eb1d2d2a54c714517f10c245ed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "12b1974827a3e4066499ae47df2117afa983caa0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19987",
       "triggerID" : "12b1974827a3e4066499ae47df2117afa983caa0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9d1a4fc3434815eb1d2d2a54c714517f10c245ed Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19969) 
   * 12b1974827a3e4066499ae47df2117afa983caa0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19987) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16285:
URL: https://github.com/apache/flink/pull/16285#issuecomment-868253867


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19518",
       "triggerID" : "c3f475e4c4fcd8bbf0a7695c75630e444308eee1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19570",
       "triggerID" : "868964300",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3a7708ead7c69816ae9debe89df06f06abed3381",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19544",
       "triggerID" : "868964300",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9d1a4fc3434815eb1d2d2a54c714517f10c245ed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19969",
       "triggerID" : "9d1a4fc3434815eb1d2d2a54c714517f10c245ed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "12b1974827a3e4066499ae47df2117afa983caa0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19987",
       "triggerID" : "12b1974827a3e4066499ae47df2117afa983caa0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 12b1974827a3e4066499ae47df2117afa983caa0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19987) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org