You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Robert Munteanu <ro...@apache.org> on 2017/11/28 09:48:17 UTC
Usage of feature-modelconverter
Hi,
I am trying to use the upcoming feature converter to generate a feature
descriptor from a slingstart package.
I am unsure however what the various arguments to. I tried doing
something like
$ java -jar target/org.apache.sling.feature.modelconverter-0.0.1-
SNAPSHOT.jar -u file:///home/robert/.m2/repository -f
/home/robert/.m2/repository/org/apache/sling/org.apache.sling.starter/1
0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
slingfeature.txt
But the program complains about invalid mvn coordinates:
[INFO] Apache Sling Provisiong Model to Feature Application Converter
[INFO]
[INFO] Assembling model...
[INFO] - reading model
/home/robert/.m2/repository/org/apache/sling/org.apache.sling.starter/1
0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
slingfeature.txt
[INFO] - reading model
/home/robert/.m2/repository/org/apache/sling/org.apache.sling.sample.sl
ingshot/0.8.0/org.apache.sling.sample.slingshot-0.8.0-slingfeature.txt
Exception in thread "main" java.lang.IllegalArgumentException: Invalid
mvn coordinates: generated/:boot/1.0.0
at
org.apache.sling.feature.ArtifactId.fromMvnId(ArtifactId.java:164)
at
org.apache.sling.feature.modelconverter.impl.Main.buildFeatures(Main.ja
va:283)
at
org.apache.sling.feature.modelconverter.impl.Main.main(Main.java:234)
How can I use the model converter to generate an application descriptor
from an existing slingstart?
Thanks,
Robert
Re: Usage of feature-modelconverter
Posted by Robert Munteanu <ro...@apache.org>.
:-)
Thanks for the review. Would be nice to also look into https://github.c
om/apache/sling-whiteboard/pull/1/ when you have the time ( you merged
https://github.com/apache/sling-whiteboard/pull/2/ )
Robert
On Tue, 2017-11-28 at 13:42 +0100, Carsten Ziegeler wrote:
> thanks, yes we had different descriptions on how the mvn id works
> (whether version is the last or the third element). So I implemented
> both :) (just kidding)
>
> According to https://maven.apache.org/pom.html#Maven_Coordinates it's
> now correct, version is always the last part
>
> Regards
>
> Carsten
>
>
> Robert Munteanu wrote
> > Ack. I think I fixed it, but a review would be good
> >
> > https://github.com/apache/sling-whiteboard/pull/1
> >
> > Thanks,
> >
> > Robert
> >
> > On Tue, 2017-11-28 at 11:10 +0100, Carsten Ziegeler wrote:
> > > Hi,
> > >
> > > at first look this seems to be a bug when reading the slingstart
> > > model
> > > as clearly generated/:boot/1.0.0 is nowhere to be found in that
> > > model.
> > >
> > > So far I've only tested converting models which did not have an
> > > include
> > > and that worked months ago when I checked last time :) So I guess
> > > we
> > > have to debug and see what is going wrong.
> > >
> > > For the options with -f you can either point to a file or a
> > > directory
> > > of
> > > files. If you don't specify the -a option you should get a set of
> > > feature files. If you specify -a you get an application json with
> > > a
> > > combination of all features.
> > >
> > > Regards
> > >
> > > Carsten
> > >
> > >
> > > Robert Munteanu wrote
> > > > Hi,
> > > >
> > > > I am trying to use the upcoming feature converter to generate a
> > > > feature
> > > > descriptor from a slingstart package.
> > > >
> > > > I am unsure however what the various arguments to. I tried
> > > > doing
> > > > something like
> > > >
> > > > $ java -jar target/org.apache.sling.feature.modelconverter-
> > > > 0.0.1-
> > > > SNAPSHOT.jar -u file:///home/robert/.m2/repository -f
> > > > /home/robert/.m2/repository/org/apache/sling/org.apache.sling.s
> > > > tart
> > > > er/1
> > > > 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
> > > > slingfeature.txt
> > > >
> > > > But the program complains about invalid mvn coordinates:
> > > >
> > > > [INFO] Apache Sling Provisiong Model to Feature Application
> > > > Converter
> > > > [INFO]
> > > > [INFO] Assembling model...
> > > > [INFO] - reading model
> > > > /home/robert/.m2/repository/org/apache/sling/org.apache.sling.s
> > > > tart
> > > > er/1
> > > > 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
> > > > slingfeature.txt
> > > > [INFO] - reading model
> > > > /home/robert/.m2/repository/org/apache/sling/org.apache.sling.s
> > > > ampl
> > > > e.sl
> > > > ingshot/0.8.0/org.apache.sling.sample.slingshot-0.8.0-
> > > > slingfeature.txt
> > > > Exception in thread "main" java.lang.IllegalArgumentException:
> > > > Invalid
> > > > mvn coordinates: generated/:boot/1.0.0
> > > > at
> > > > org.apache.sling.feature.ArtifactId.fromMvnId(ArtifactId.java:1
> > > > 64)
> > > > at
> > > > org.apache.sling.feature.modelconverter.impl.Main.buildFeatures
> > > > (Mai
> > > > n.ja
> > > > va:283)
> > > > at
> > > > org.apache.sling.feature.modelconverter.impl.Main.main(Main.jav
> > > > a:23
> > > > 4)
> > > >
> > > > How can I use the model converter to generate an application
> > > > descriptor
> > > > from an existing slingstart?
> > > >
> > > > Thanks,
> > > >
> > > > Robert
> > > >
Re: Usage of feature-modelconverter
Posted by Carsten Ziegeler <cz...@apache.org>.
thanks, yes we had different descriptions on how the mvn id works
(whether version is the last or the third element). So I implemented
both :) (just kidding)
According to https://maven.apache.org/pom.html#Maven_Coordinates it's
now correct, version is always the last part
Regards
Carsten
Robert Munteanu wrote
> Ack. I think I fixed it, but a review would be good
>
> https://github.com/apache/sling-whiteboard/pull/1
>
> Thanks,
>
> Robert
>
> On Tue, 2017-11-28 at 11:10 +0100, Carsten Ziegeler wrote:
>> Hi,
>>
>> at first look this seems to be a bug when reading the slingstart
>> model
>> as clearly generated/:boot/1.0.0 is nowhere to be found in that
>> model.
>>
>> So far I've only tested converting models which did not have an
>> include
>> and that worked months ago when I checked last time :) So I guess we
>> have to debug and see what is going wrong.
>>
>> For the options with -f you can either point to a file or a directory
>> of
>> files. If you don't specify the -a option you should get a set of
>> feature files. If you specify -a you get an application json with a
>> combination of all features.
>>
>> Regards
>>
>> Carsten
>>
>>
>> Robert Munteanu wrote
>>> Hi,
>>>
>>> I am trying to use the upcoming feature converter to generate a
>>> feature
>>> descriptor from a slingstart package.
>>>
>>> I am unsure however what the various arguments to. I tried doing
>>> something like
>>>
>>> $ java -jar target/org.apache.sling.feature.modelconverter-0.0.1-
>>> SNAPSHOT.jar -u file:///home/robert/.m2/repository -f
>>> /home/robert/.m2/repository/org/apache/sling/org.apache.sling.start
>>> er/1
>>> 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
>>> slingfeature.txt
>>>
>>> But the program complains about invalid mvn coordinates:
>>>
>>> [INFO] Apache Sling Provisiong Model to Feature Application
>>> Converter
>>> [INFO]
>>> [INFO] Assembling model...
>>> [INFO] - reading model
>>> /home/robert/.m2/repository/org/apache/sling/org.apache.sling.start
>>> er/1
>>> 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
>>> slingfeature.txt
>>> [INFO] - reading model
>>> /home/robert/.m2/repository/org/apache/sling/org.apache.sling.sampl
>>> e.sl
>>> ingshot/0.8.0/org.apache.sling.sample.slingshot-0.8.0-
>>> slingfeature.txt
>>> Exception in thread "main" java.lang.IllegalArgumentException:
>>> Invalid
>>> mvn coordinates: generated/:boot/1.0.0
>>> at
>>> org.apache.sling.feature.ArtifactId.fromMvnId(ArtifactId.java:164)
>>> at
>>> org.apache.sling.feature.modelconverter.impl.Main.buildFeatures(Mai
>>> n.ja
>>> va:283)
>>> at
>>> org.apache.sling.feature.modelconverter.impl.Main.main(Main.java:23
>>> 4)
>>>
>>> How can I use the model converter to generate an application
>>> descriptor
>>> from an existing slingstart?
>>>
>>> Thanks,
>>>
>>> Robert
>>>
>
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: Usage of feature-modelconverter
Posted by Robert Munteanu <ro...@apache.org>.
Ack. I think I fixed it, but a review would be good
https://github.com/apache/sling-whiteboard/pull/1
Thanks,
Robert
On Tue, 2017-11-28 at 11:10 +0100, Carsten Ziegeler wrote:
> Hi,
>
> at first look this seems to be a bug when reading the slingstart
> model
> as clearly generated/:boot/1.0.0 is nowhere to be found in that
> model.
>
> So far I've only tested converting models which did not have an
> include
> and that worked months ago when I checked last time :) So I guess we
> have to debug and see what is going wrong.
>
> For the options with -f you can either point to a file or a directory
> of
> files. If you don't specify the -a option you should get a set of
> feature files. If you specify -a you get an application json with a
> combination of all features.
>
> Regards
>
> Carsten
>
>
> Robert Munteanu wrote
> > Hi,
> >
> > I am trying to use the upcoming feature converter to generate a
> > feature
> > descriptor from a slingstart package.
> >
> > I am unsure however what the various arguments to. I tried doing
> > something like
> >
> > $ java -jar target/org.apache.sling.feature.modelconverter-0.0.1-
> > SNAPSHOT.jar -u file:///home/robert/.m2/repository -f
> > /home/robert/.m2/repository/org/apache/sling/org.apache.sling.start
> > er/1
> > 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
> > slingfeature.txt
> >
> > But the program complains about invalid mvn coordinates:
> >
> > [INFO] Apache Sling Provisiong Model to Feature Application
> > Converter
> > [INFO]
> > [INFO] Assembling model...
> > [INFO] - reading model
> > /home/robert/.m2/repository/org/apache/sling/org.apache.sling.start
> > er/1
> > 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
> > slingfeature.txt
> > [INFO] - reading model
> > /home/robert/.m2/repository/org/apache/sling/org.apache.sling.sampl
> > e.sl
> > ingshot/0.8.0/org.apache.sling.sample.slingshot-0.8.0-
> > slingfeature.txt
> > Exception in thread "main" java.lang.IllegalArgumentException:
> > Invalid
> > mvn coordinates: generated/:boot/1.0.0
> > at
> > org.apache.sling.feature.ArtifactId.fromMvnId(ArtifactId.java:164)
> > at
> > org.apache.sling.feature.modelconverter.impl.Main.buildFeatures(Mai
> > n.ja
> > va:283)
> > at
> > org.apache.sling.feature.modelconverter.impl.Main.main(Main.java:23
> > 4)
> >
> > How can I use the model converter to generate an application
> > descriptor
> > from an existing slingstart?
> >
> > Thanks,
> >
> > Robert
> >
Re: Usage of feature-modelconverter
Posted by Carsten Ziegeler <cz...@apache.org>.
Hi,
at first look this seems to be a bug when reading the slingstart model
as clearly generated/:boot/1.0.0 is nowhere to be found in that model.
So far I've only tested converting models which did not have an include
and that worked months ago when I checked last time :) So I guess we
have to debug and see what is going wrong.
For the options with -f you can either point to a file or a directory of
files. If you don't specify the -a option you should get a set of
feature files. If you specify -a you get an application json with a
combination of all features.
Regards
Carsten
Robert Munteanu wrote
> Hi,
>
> I am trying to use the upcoming feature converter to generate a feature
> descriptor from a slingstart package.
>
> I am unsure however what the various arguments to. I tried doing
> something like
>
> $ java -jar target/org.apache.sling.feature.modelconverter-0.0.1-
> SNAPSHOT.jar -u file:///home/robert/.m2/repository -f
> /home/robert/.m2/repository/org/apache/sling/org.apache.sling.starter/1
> 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
> slingfeature.txt
>
> But the program complains about invalid mvn coordinates:
>
> [INFO] Apache Sling Provisiong Model to Feature Application Converter
> [INFO]
> [INFO] Assembling model...
> [INFO] - reading model
> /home/robert/.m2/repository/org/apache/sling/org.apache.sling.starter/1
> 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
> slingfeature.txt
> [INFO] - reading model
> /home/robert/.m2/repository/org/apache/sling/org.apache.sling.sample.sl
> ingshot/0.8.0/org.apache.sling.sample.slingshot-0.8.0-slingfeature.txt
> Exception in thread "main" java.lang.IllegalArgumentException: Invalid
> mvn coordinates: generated/:boot/1.0.0
> at
> org.apache.sling.feature.ArtifactId.fromMvnId(ArtifactId.java:164)
> at
> org.apache.sling.feature.modelconverter.impl.Main.buildFeatures(Main.ja
> va:283)
> at
> org.apache.sling.feature.modelconverter.impl.Main.main(Main.java:234)
>
> How can I use the model converter to generate an application descriptor
> from an existing slingstart?
>
> Thanks,
>
> Robert
>
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org