You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Filipe Manana (JIRA)" <ji...@apache.org> on 2011/03/02 11:26:36 UTC

[jira] Created: (COUCHDB-1081) Proper database header upgrade

Proper database header upgrade
------------------------------

                 Key: COUCHDB-1081
                 URL: https://issues.apache.org/jira/browse/COUCHDB-1081
             Project: CouchDB
          Issue Type: Bug
          Components: Database Core
            Reporter: Filipe Manana
            Assignee: Filipe Manana
         Attachments: COUCHDB-1081.patch

After upgrading an old database header, we don't set the disk_version field of the upgraded header to the latest supported version.

Also, when opening versions from more recent releases, we get a function clause crash instead of throwing an exception with an explicit message informing the version is not supported.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (COUCHDB-1081) Proper database header upgrade

Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Filipe Manana resolved COUCHDB-1081.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2

Applied the second part of the patch (avoiding the function_clause error when opening unsupported database versions) to trunk.

> Proper database header upgrade
> ------------------------------
>
>                 Key: COUCHDB-1081
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1081
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Database Core
>            Reporter: Filipe Manana
>            Assignee: Filipe Manana
>             Fix For: 1.2
>
>         Attachments: COUCHDB-1081.patch
>
>
> After upgrading an old database header, we don't set the disk_version field of the upgraded header to the latest supported version.
> Also, when opening versions from more recent releases, we get a function clause crash instead of throwing an exception with an explicit message informing the version is not supported.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (COUCHDB-1081) Proper database header upgrade

Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001411#comment-13001411 ] 

Filipe Manana commented on COUCHDB-1081:
----------------------------------------

Just to avoid confusion, the header upgrade procedure is not broken.

The proposed patch just avoids a function clause error when opening a database from more recent versions. Also, updating the disk_version field is not a must (after compaction we'll get an header with the latest version) but it makes it easier to analyze when (from which header/offset) a database file was upgraded (assuming no compaction happened yet).

> Proper database header upgrade
> ------------------------------
>
>                 Key: COUCHDB-1081
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1081
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Database Core
>            Reporter: Filipe Manana
>            Assignee: Filipe Manana
>         Attachments: COUCHDB-1081.patch
>
>
> After upgrading an old database header, we don't set the disk_version field of the upgraded header to the latest supported version.
> Also, when opening versions from more recent releases, we get a function clause crash instead of throwing an exception with an explicit message informing the version is not supported.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira