You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/23 21:25:02 UTC

[GitHub] [airflow] mik-laj edited a comment on pull request #11736: Vault with optional Variables or Connections

mik-laj edited a comment on pull request #11736:
URL: https://github.com/apache/airflow/pull/11736#issuecomment-715596353


   > @kaxil I am happy to take this on, but will probably be asking for lots of guidance along the way particularly regarding the tests. Hope that is ok, as this is my first venture into open source contributions. :)
   
   Look here:
   https://github.com/apache/airflow/blob/master/tests/providers/hashicorp/secrets/test_vault.py
   Your test should pass None when initializing this class, then make assertions on the function result and make sure the client method has not been called.
   
   If you want to run the tests, you should run the following command:
   ```
   pytest tests/providers/hashicorp/secrets/vault.py
   ```
   If you don't have an environment set up then you can use [Breeze](https://github.com/apache/airflow/blob/master/BREEZE.rst). To do this, you run the command:
   ```
   ./breeze
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org