You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/13 05:37:10 UTC

[GitHub] [spark] MaxGekk commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

MaxGekk commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585560123
 
 
   > The code itself looks fine. btw, is this not a correctness issue? (trivial though)
   
   I do believe it is a correctness issue. Rounding 2.123 -> 3 doesn't make any sense. This is not arithmetic rounding, and not just cutting off the rest. And this contradicts to truncations to other levels.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org