You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/09/24 14:54:35 UTC
[GitHub] [couchdb] jjrodrig opened a new pull request #3174: Port rewrite and rewrite_js tests into elixir
jjrodrig opened a new pull request #3174:
URL: https://github.com/apache/couchdb/pull/3174
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
This PR ports these tests to Elixir
- rewrite.js
- rewrite_js.js
rewrite.js was partially ported before this PR, now it is completely ported.
Rawresp module has been moved and now can be used by any test if a non-parsed http response body is required.
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
```
make elixir
```
## Related Issues or Pull Requests
N/A
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [X] Code is written and works correctly
- [X] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] dottorblaster commented on a change in pull request #3174: Port rewrite and rewrite_js tests into elixir
Posted by GitBox <gi...@apache.org>.
dottorblaster commented on a change in pull request #3174:
URL: https://github.com/apache/couchdb/pull/3174#discussion_r494388475
##########
File path: test/elixir/lib/couch.ex
##########
@@ -175,3 +175,109 @@ defmodule Couch do
end
end
end
+
+defmodule Rawresp do
Review comment:
couldn't we just write a new file for this? Too much pain? (at the moment I can't remember if we could call those functions inside the module this way)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] dottorblaster commented on a change in pull request #3174: Port rewrite and rewrite_js tests into elixir
Posted by GitBox <gi...@apache.org>.
dottorblaster commented on a change in pull request #3174:
URL: https://github.com/apache/couchdb/pull/3174#discussion_r494388475
##########
File path: test/elixir/lib/couch.ex
##########
@@ -175,3 +175,109 @@ defmodule Couch do
end
end
end
+
+defmodule Rawresp do
Review comment:
couldn't we just write a new file for this? Too much pain? (at the moment I can't remember if we could call those functions inside the module this way)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jjrodrig commented on a change in pull request #3174: Port rewrite and rewrite_js tests into elixir
Posted by GitBox <gi...@apache.org>.
jjrodrig commented on a change in pull request #3174:
URL: https://github.com/apache/couchdb/pull/3174#discussion_r494452608
##########
File path: test/elixir/lib/couch.ex
##########
@@ -175,3 +175,109 @@ defmodule Couch do
end
end
end
+
+defmodule Rawresp do
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jjrodrig commented on a change in pull request #3174: Port rewrite and rewrite_js tests into elixir
Posted by GitBox <gi...@apache.org>.
jjrodrig commented on a change in pull request #3174:
URL: https://github.com/apache/couchdb/pull/3174#discussion_r494450642
##########
File path: test/elixir/lib/couch.ex
##########
@@ -175,3 +175,109 @@ defmodule Couch do
end
end
end
+
+defmodule Rawresp do
Review comment:
Sure, i'll put it in a new file
Really, a tried to do it with the current Couch module at couch.ex but I don't know how to parametrize this behaviour.
##########
File path: test/elixir/lib/couch.ex
##########
@@ -175,3 +175,109 @@ defmodule Couch do
end
end
end
+
+defmodule Rawresp do
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jjrodrig commented on a change in pull request #3174: Port rewrite and rewrite_js tests into elixir
Posted by GitBox <gi...@apache.org>.
jjrodrig commented on a change in pull request #3174:
URL: https://github.com/apache/couchdb/pull/3174#discussion_r494450642
##########
File path: test/elixir/lib/couch.ex
##########
@@ -175,3 +175,109 @@ defmodule Couch do
end
end
end
+
+defmodule Rawresp do
Review comment:
Sure, i'll put it in a new file
Really, a tried to do it with the current Couch module at couch.ex but I don't know how to parametrize this behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jjrodrig merged pull request #3174: Port rewrite and rewrite_js tests into elixir
Posted by GitBox <gi...@apache.org>.
jjrodrig merged pull request #3174:
URL: https://github.com/apache/couchdb/pull/3174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jjrodrig commented on pull request #3174: Port rewrite and rewrite_js tests into elixir
Posted by GitBox <gi...@apache.org>.
jjrodrig commented on pull request #3174:
URL: https://github.com/apache/couchdb/pull/3174#issuecomment-700517218
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org