You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by conniey <gi...@git.apache.org> on 2016/12/06 17:13:48 UTC
[GitHub] lucenenet pull request #197: Fixing build errors
GitHub user conniey opened a pull request:
https://github.com/apache/lucenenet/pull/197
Fixing build errors
Currently compiling master results in build errors:
```
core\Search\JustCompileSearch.cs(204,46): error CS0507: 'JustCompileSearch.JustCompileFilteredDocIdSet.Match(int)': cannot change access modifiers when overriding 'protected' inherited member 'FilteredDocIdSet.Match(int)' [D:\git\conniey\lucenenet\src\Lucene.Net.Tests\Lucene.Net.Tests.csproj]`
```
This is due to changes in [FilteredDocIdSet](https://github.com/apache/lucenenet/blob/master/src/Lucene.Net.Core/Search/FilteredDocIdSet.cs#L95) from:
`protected internal abstract bool Match(int docid);` to `protected abstract bool Match(int docid);`
This fixes those errors. An alternative would be to add the `internal` modifier back to FilteredDocIdSet.
@NightOwl888 Do you know why it was removed in the first place?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/conniey/lucenenet fixBuildIssues
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucenenet/pull/197.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #197
----
commit a7463ebe72b36bee8e5df5e98cff7f33af39e31a
Author: Connie Yau <co...@microsoft.com>
Date: 2016-12-06T17:06:12Z
Fixing build errors by removing internal modifiers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #197: Fixing build errors
Posted by NightOwl888 <gi...@git.apache.org>.
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/197
See https://github.com/apache/lucenenet/commit/e8735ed9622ab56eaf86bae6394f93f3fb058d30 for an example.
If it is something that needs to go in right away (such as this) you could add to the message preemptively (and hope nobody else beats you to it). If not, you can just add a commit at the end of the PR indicating to close. It really doesn't matter so much, you can close any PR or GitHub issue from any commit by using these commit message commands.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #197: Fixing build errors
Posted by conniey <gi...@git.apache.org>.
Github user conniey commented on the issue:
https://github.com/apache/lucenenet/pull/197
@NightOwl888 Ahh okay! Thanks for letting me know. Just to make sure I understand it correctly, when I am creating a commit, I'll preemptively add "fixes <issue number>" to my commit message. And the <issue number> where it'll be the number my PR will be when I create it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #197: Fixing build errors
Posted by conniey <gi...@git.apache.org>.
Github user conniey commented on the issue:
https://github.com/apache/lucenenet/pull/197
@NightOwl888 Awesome! Thanks for the explanation. I updated my commit message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request #197: Fixing build errors
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucenenet/pull/197
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #197: Fixing build errors
Posted by NightOwl888 <gi...@git.apache.org>.
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/197
Not sure why this happened - probably a botched merge of some kind. I'll pull this into master.
For future reference, it would work smoother on my end if you just add `fixes #197` or `closes #197` to the commit message. I don't have access to be able to merge from GitHub, but if you add one of those to the commit message, the pull request will be closed automatically when merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---