You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/04/06 03:44:06 UTC

[kudu-CR] WIP [HaClient] introduce client metrics

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12951


Change subject: WIP [HaClient] introduce client metrics
......................................................................

WIP [HaClient] introduce client metrics

Introduced metrics for Sentry client in SentryAuthzProvider.

WIP: needed tests

Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f
---
M src/kudu/master/CMakeLists.txt
M src/kudu/master/catalog_manager.cc
M src/kudu/master/sentry_authz_provider.cc
M src/kudu/master/sentry_authz_provider.h
A src/kudu/master/sentry_client_metrics.cc
A src/kudu/master/sentry_client_metrics.h
M src/kudu/thrift/client.h
A src/kudu/thrift/ha_client_metrics.h
8 files changed, 191 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/12951/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f
Gerrit-Change-Number: 12951
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [HaClient] introduce client metrics

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 )

Change subject: [HaClient] introduce client metrics
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/sentry_authz_provider-test.cc
File src/kudu/master/sentry_authz_provider-test.cc:

http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/sentry_authz_provider-test.cc@744
PS5, Line 744:   // NotAuthorized() from Sentry itself considered as a fatal error.
             :   // TODO(KUDU-2769): clarify whether it is a bug in HaClient
> I'm not going to get into the bottom of it in the context of this change, b
Great, thanks for filing that!



-- 
To view, visit http://gerrit.cloudera.org:8080/12951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f
Gerrit-Change-Number: 12951
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 09 Apr 2019 20:25:19 +0000
Gerrit-HasComments: Yes

[kudu-CR] [HaClient] introduce client metrics

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 )

Change subject: [HaClient] introduce client metrics
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/catalog_manager.cc@4680
PS5, Line 4680:                                           optional<const string&> user) {
> warning: the parameter 'user' is copied for each invocation but only used a
I'm going to ignore this TidyBot's comment in the scope of this patch.


http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/sentry_authz_provider-test.cc
File src/kudu/master/sentry_authz_provider-test.cc:

http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/sentry_authz_provider-test.cc@744
PS5, Line 744:   // NotAuthorized() from Sentry itself considered as a fatal error.
             :   // TODO(aserbin): is it a bug in HaClient or Sentry itself?
> Yeah, I'm curious about this. Is there a distinction between the errors tha
I'm not going to get into the bottom of it in the context of this change, but I opened a JIRA for that: https://issues.apache.org/jira/browse/KUDU-2769

I updated the comment as well to mention the JIRA case above.



-- 
To view, visit http://gerrit.cloudera.org:8080/12951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f
Gerrit-Change-Number: 12951
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 09 Apr 2019 19:07:22 +0000
Gerrit-HasComments: Yes

[kudu-CR] [HaClient] introduce client metrics

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 )

Change subject: [HaClient] introduce client metrics
......................................................................


Patch Set 6: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f
Gerrit-Change-Number: 12951
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 09 Apr 2019 19:29:36 +0000
Gerrit-HasComments: No

[kudu-CR] [HaClient] introduce client metrics

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12951 )

Change subject: [HaClient] introduce client metrics
......................................................................

[HaClient] introduce client metrics

Introduced metrics for HA Sentry client in SentryAuthzProvider.
Added corresponding test to verify how the newly introduced
metrics work.

Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f
Reviewed-on: http://gerrit.cloudera.org:8080/12951
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/master/CMakeLists.txt
M src/kudu/master/catalog_manager.cc
M src/kudu/master/sentry_authz_provider-test.cc
M src/kudu/master/sentry_authz_provider.cc
M src/kudu/master/sentry_authz_provider.h
A src/kudu/master/sentry_client_metrics.cc
A src/kudu/master/sentry_client_metrics.h
M src/kudu/thrift/client.h
A src/kudu/thrift/ha_client_metrics.h
9 files changed, 313 insertions(+), 15 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, but someone else must approve
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f
Gerrit-Change-Number: 12951
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [HaClient] introduce client metrics

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 )

Change subject: [HaClient] introduce client metrics
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/sentry_authz_provider-test.cc
File src/kudu/master/sentry_authz_provider-test.cc:

http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/sentry_authz_provider-test.cc@744
PS5, Line 744:   // NotAuthorized() from Sentry itself considered as a fatal error.
             :   // TODO(aserbin): is it a bug in HaClient or Sentry itself?
> We have tests in sentry_client-test.cc for cases when Sentry sends back Not
Yeah, I filed KUDU-2769 to clarify on that, because reconnecting seems to be sub-optimal in those cases.



-- 
To view, visit http://gerrit.cloudera.org:8080/12951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f
Gerrit-Change-Number: 12951
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 09 Apr 2019 20:49:12 +0000
Gerrit-HasComments: Yes

[kudu-CR] [HaClient] introduce client metrics

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.

Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 )

Change subject: [HaClient] introduce client metrics
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/sentry_authz_provider-test.cc
File src/kudu/master/sentry_authz_provider-test.cc:

http://gerrit.cloudera.org:8080/#/c/12951/5/src/kudu/master/sentry_authz_provider-test.cc@744
PS5, Line 744:   // NotAuthorized() from Sentry itself considered as a fatal error.
             :   // TODO(KUDU-2769): clarify whether it is a bug in HaClient
> Great, thanks for filing that!
We have tests in sentry_client-test.cc for cases when Sentry sends back NotAuthorized() error. For example, Sentry fails to find a user's group mapping.

Though I think in these cases we should not retry?



-- 
To view, visit http://gerrit.cloudera.org:8080/12951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f
Gerrit-Change-Number: 12951
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 09 Apr 2019 20:40:22 +0000
Gerrit-HasComments: Yes

[kudu-CR] [HaClient] introduce client metrics

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 )

Change subject: [HaClient] introduce client metrics
......................................................................


Patch Set 5: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f
Gerrit-Change-Number: 12951
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 09 Apr 2019 04:56:09 +0000
Gerrit-HasComments: No

[kudu-CR] [HaClient] introduce client metrics

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 )

Change subject: [HaClient] introduce client metrics
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/12951/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12951/3//COMMIT_MSG@9
PS3, Line 9: Introduced metrics for HA Sentry client in SentryAuthzProvider.
> Are you going to roll out something similar for the HMS client? It'd certai
Yep, I think it's better to do that in a separate patch.  I opened the following JIRA to track that: https://issues.apache.org/jira/browse/KUDU-2766


http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/master/catalog_manager.cc@4680
PS3, Line 4680:                                           optional<const string&> user) {
> warning: the parameter 'user' is copied for each invocation but only used a
I'm going to ignore this in the scope of this changelist.


http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/master/sentry_authz_provider-test.cc
File src/kudu/master/sentry_authz_provider-test.cc:

http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/master/sentry_authz_provider-test.cc@749
PS3, Line 749:   ASSERT_EQ(0, GetTasksFailedNonFatal());
> Can we test that this increases?
Good idea, however I could not find a way to get non-fatal error code from ListPrivilegesByUser() from Sentry.


http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/thrift/client.h
File src/kudu/thrift/client.h:

http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/thrift/client.h@287
PS3, Line 287:         if (PREDICT_TRUE(metrics_)) {
             :           metrics_->tasks_failed_fatal->Increment();
             :         }
> Why is this conditioned on attempt == 0?
Because that's the first time a failure is noticed, and later failures will happen because of retries.  I think the tasks_failed_fatal should not count duplicates/retries for clarity; also, tasks_failed_nonfatal doesn't count retries either.



-- 
To view, visit http://gerrit.cloudera.org:8080/12951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f
Gerrit-Change-Number: 12951
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 09 Apr 2019 02:13:46 +0000
Gerrit-HasComments: Yes

[kudu-CR] [HaClient] introduce client metrics

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12951

to look at the new patch set (#4).

Change subject: [HaClient] introduce client metrics
......................................................................

[HaClient] introduce client metrics

Introduced metrics for HA Sentry client in SentryAuthzProvider.
Added corresponding test to verify how the newly introduced
metrics work.

Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f
---
M src/kudu/master/CMakeLists.txt
M src/kudu/master/catalog_manager.cc
M src/kudu/master/sentry_authz_provider-test.cc
M src/kudu/master/sentry_authz_provider.cc
M src/kudu/master/sentry_authz_provider.h
A src/kudu/master/sentry_client_metrics.cc
A src/kudu/master/sentry_client_metrics.h
M src/kudu/thrift/client.h
A src/kudu/thrift/ha_client_metrics.h
9 files changed, 285 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/12951/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f
Gerrit-Change-Number: 12951
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)