You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by Erik Beeson <er...@gmail.com> on 2009/10/06 23:26:02 UTC
Javadoc Typos
Hello,
Been poking around under the hood of snapshot 20091001 and found a couple of
extremely minor javadoc issues. The docs are a little broken in
ThreadContextSubjectBinder, and the docs in ShiroFilter still have a few
references to "some.pkg" instead of "example.pkg".
--Erik
Re: Javadoc Typos
Posted by Les Hazlewood <lh...@apache.org>.
Agreed!
On Tue, Oct 6, 2009 at 5:59 PM, Kalle Korhonen
<ka...@gmail.com> wrote:
> Patch or not, but please create a jira - issues reported on email
> easily get lost if there's nobody to jump on it immediately.
>
> Kalle
>
>
> On Tue, Oct 6, 2009 at 2:53 PM, Les Hazlewood <lh...@apache.org> wrote:
>> Hi Erik,
>>
>> This is great - the code base can definitely benefit from more
>> scrutinizing eyes. Thanks for letting us know.
>>
>> Would it be possible to submit your changes as a patch? That way we
>> can apply the changes directly to code. Granted, this change is
>> probably an easy search-and-replace, but if you come across anything
>> else, patches are a real time saver.
>>
>> Cheers,
>>
>> Les
>>
>> On Tue, Oct 6, 2009 at 5:26 PM, Erik Beeson <er...@gmail.com> wrote:
>>> Hello,
>>>
>>> Been poking around under the hood of snapshot 20091001 and found a couple of
>>> extremely minor javadoc issues. The docs are a little broken in
>>> ThreadContextSubjectBinder, and the docs in ShiroFilter still have a few
>>> references to "some.pkg" instead of "example.pkg".
>>>
>>> --Erik
>>>
>>
>
Re: Javadoc Typos
Posted by Kalle Korhonen <ka...@gmail.com>.
Patch or not, but please create a jira - issues reported on email
easily get lost if there's nobody to jump on it immediately.
Kalle
On Tue, Oct 6, 2009 at 2:53 PM, Les Hazlewood <lh...@apache.org> wrote:
> Hi Erik,
>
> This is great - the code base can definitely benefit from more
> scrutinizing eyes. Thanks for letting us know.
>
> Would it be possible to submit your changes as a patch? That way we
> can apply the changes directly to code. Granted, this change is
> probably an easy search-and-replace, but if you come across anything
> else, patches are a real time saver.
>
> Cheers,
>
> Les
>
> On Tue, Oct 6, 2009 at 5:26 PM, Erik Beeson <er...@gmail.com> wrote:
>> Hello,
>>
>> Been poking around under the hood of snapshot 20091001 and found a couple of
>> extremely minor javadoc issues. The docs are a little broken in
>> ThreadContextSubjectBinder, and the docs in ShiroFilter still have a few
>> references to "some.pkg" instead of "example.pkg".
>>
>> --Erik
>>
>
Re: Javadoc Typos
Posted by Les Hazlewood <lh...@apache.org>.
Hi Erik,
This is great - the code base can definitely benefit from more
scrutinizing eyes. Thanks for letting us know.
Would it be possible to submit your changes as a patch? That way we
can apply the changes directly to code. Granted, this change is
probably an easy search-and-replace, but if you come across anything
else, patches are a real time saver.
Cheers,
Les
On Tue, Oct 6, 2009 at 5:26 PM, Erik Beeson <er...@gmail.com> wrote:
> Hello,
>
> Been poking around under the hood of snapshot 20091001 and found a couple of
> extremely minor javadoc issues. The docs are a little broken in
> ThreadContextSubjectBinder, and the docs in ShiroFilter still have a few
> references to "some.pkg" instead of "example.pkg".
>
> --Erik
>