You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/25 14:11:15 UTC
[GitHub] [kafka] mdedetrich opened a new pull request #10762: KAFKA-12819: Add assert messages to MirrorMaker tests plus other qual…
mdedetrich opened a new pull request #10762:
URL: https://github.com/apache/kafka/pull/10762
This PR does various QoL improvements for the MM tests, mainly some basic refactoring to remove some boilerplate as well as adding messages to all of the assert statements so that if they fail there is more context
Some improvements to the assert failure messages may need to be done to make it more clear whats actually going on, @ryannedolan you may have more to add on this point.
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine merged pull request #10762: KAFKA-12819: Add assert messages to MirrorMaker tests plus other qual…
Posted by GitBox <gi...@apache.org>.
kkonstantine merged pull request #10762:
URL: https://github.com/apache/kafka/pull/10762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ryannedolan commented on pull request #10762: KAFKA-12819: Add assert messages to MirrorMaker tests plus other qual…
Posted by GitBox <gi...@apache.org>.
ryannedolan commented on pull request #10762:
URL: https://github.com/apache/kafka/pull/10762#issuecomment-847906780
thx lgtm!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mdedetrich commented on pull request #10762: KAFKA-12819: Add assert messages to MirrorMaker tests plus other qual…
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on pull request #10762:
URL: https://github.com/apache/kafka/pull/10762#issuecomment-848553078
Okay PR is ready, some tests are failing but it seems to be due to unstable CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org