[GitHub] [flink] qinjunjerry commented on a change in pull request #19021: [hotfix][docs] Clarify semantic of tolerable checkpoint failure number

[GitBox <gi...@apache.org>]

qinjunjerry commented on a change in pull request #19021:
URL: https://github.com/apache/flink/pull/19021#discussion_r827743023



##########
File path: docs/content.zh/docs/dev/datastream/fault-tolerance/checkpointing.md
##########
@@ -61,6 +61,10 @@ Checkpoint 其他的属性包括：
 
   - *checkpoint 可容忍连续失败次数*：该属性定义可容忍多少次连续的 checkpoint 失败。超过这个阈值之后会触发作业错误 fail over。
     默认次数为“0”，这意味着不容忍 checkpoint 失败，作业将在第一次 checkpoint 失败时fail over。
+    This only applies to the following failure reasons: IOException on the Job Manager, failures in
+    the async phase on the Task Managers and checkpoint expiration due to a timeout. Failures
+    originating from the sync phase on the Task Managers are always forcing failover of an affected
+    task. Other types of checkpoint failures (such as checkpoint being subsumed) are being ignored。
     

Review comment:
       I translated your text into Chinese:
   可容忍的checkpoint失败仅适用于下列情形：Job Manager的IOException，TaskManager做checkpoint时异步部分的失败，checkpoint超时等。TaskManager做checkpoint时同步部分的失败会直接触发作业fail over。其它的checkpoint失败（如一个checkpoint被另一个checkpoint包含）会被忽略掉。

##########
File path: docs/content.zh/docs/dev/datastream/fault-tolerance/checkpointing.md
##########
@@ -61,6 +61,10 @@ Checkpoint 其他的属性包括：
 
   - *checkpoint 可容忍连续失败次数*：该属性定义可容忍多少次连续的 checkpoint 失败。超过这个阈值之后会触发作业错误 fail over。
     默认次数为“0”，这意味着不容忍 checkpoint 失败，作业将在第一次 checkpoint 失败时fail over。
+    This only applies to the following failure reasons: IOException on the Job Manager, failures in
+    the async phase on the Task Managers and checkpoint expiration due to a timeout. Failures
+    originating from the sync phase on the Task Managers are always forcing failover of an affected
+    task. Other types of checkpoint failures (such as checkpoint being subsumed) are being ignored。
     

Review comment:
       I translated your text into Chinese:
   可容忍的checkpoint失败仅适用于下列情形：Job Manager的IOException，TaskManager做checkpoint时异步部分的失败，checkpoint超时等。TaskManager做checkpoint时同步部分的失败会直接触发作业fail over。其它的checkpoint失败（如一个checkpoint被另一个checkpoint包含）会被忽略掉。




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org