You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2016/09/01 15:20:27 UTC

[jclouds/jclouds] JCLOUDS-1166/JCLOUDS-1160: Downgrade to Gson 2.5 (#1004)

This change reverts https://github.com/jclouds/jclouds/commit/da4614e72ce17999afbe54ae32879f27a59d8c5c and upgrades from Gson 2.3.1 to 2.5, which is the last version that exports the internal packages, used in jclouds-core, in the OSGi bundle.

I've run a jclouds-karaf build with this version and it seems to work.

/cc @demobox @andrewgaul Let's merge this to fix the build and let's figure out how we want to proceed if we want to actually upgrade to 2.7? We are still pending confirmation if Spring Boot 1.4.0 actually requires version 2.7 (a quick look to its dependencies marks Gson as `optional`).
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1004

-- Commit Summary --

  * JCLOUDS-1166/JCLOUDS-1160: Downgrade to Gson 2.5

-- File Changes --

    M core/pom.xml (2)
    M core/src/main/java/org/jclouds/json/internal/DeserializationConstructorAndReflectiveTypeAdapterFactory.java (4)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1004.patch
https://github.com/jclouds/jclouds/pull/1004.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1004

Re: [jclouds/jclouds] JCLOUDS-1166/JCLOUDS-1160: Downgrade to Gson 2.5 (#1004)

Posted by Andrew Phillips <no...@github.com>.

Reopened #1004.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1004#event-775935606

Re: [jclouds/jclouds] JCLOUDS-1166/JCLOUDS-1160: Downgrade to Gson 2.5 (#1004)

Posted by Andrew Phillips <no...@github.com>.

> I've run a jclouds-karaf build with this version and it seems to work.

Great, thanks!

> All checks have failed

Looks like a transient test failure: https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds$jclouds-core/2407/testReport/org.jclouds.http.handlers/BackoffLimitedRetryHandlerTest/testExponentialBackoffDelaySmallInterval1/

Let's try this again...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1004#issuecomment-244246986

Re: [jclouds/jclouds] JCLOUDS-1166/JCLOUDS-1160: Downgrade to Gson 2.5 (#1004)

Posted by Andrew Phillips <no...@github.com>.

Closed #1004.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1004#event-775935587

Re: [jclouds/jclouds] JCLOUDS-1166/JCLOUDS-1160: Downgrade to Gson 2.5 (#1004)

Posted by Ignasi Barrera <no...@github.com>.

Closed #1004.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1004#event-776181425

Re: [jclouds/jclouds] JCLOUDS-1166/JCLOUDS-1160: Downgrade to Gson 2.5 (#1004)

Posted by Zack Shoylev <no...@github.com>.

> @@ -80,7 +80,7 @@
>      <dependency>
>        <groupId>com.google.code.gson</groupId>
>        <artifactId>gson</artifactId>
> -      <version>2.7</version>
> +      <version>2.5</version>

Maybe add a comment about why we are doing this here? In case it takes a while for us to move to 2.7

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1004/files/fa01c327f177b86f667fd950a8f073d3a7691f84#r77196933

Re: [jclouds/jclouds] JCLOUDS-1166/JCLOUDS-1160: Downgrade to Gson 2.5 (#1004)

Posted by Andrew Gaul <no...@github.com>.

👍 Stop the bleeding.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1004#issuecomment-244166292

Re: [jclouds/jclouds] JCLOUDS-1166/JCLOUDS-1160: Downgrade to Gson 2.5 (#1004)

Posted by Ignasi Barrera <no...@github.com>.

Merged to master as [4c927636](http://git-wip-us.apache.org/repos/asf/jclouds/commit/4c927636). And included the reasoning behind this change in the commit message as per @zack-shoylev's suggestion.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1004#issuecomment-244299258