You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Sravya Tirukkovalur <sr...@cloudera.com> on 2013/06/12 18:18:36 UTC
Re: Review Request: JMX support for SpoolDir Source
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11821/
-----------------------------------------------------------
(Updated June 12, 2013, 4:18 p.m.)
Review request for Flume, Brock Noland, Mike Percy, and Hari Shreedharan.
Changes
-------
Adding flume group
Description
-------
SpoolDir Source supports following metrics:
START
STOP
EVENTS_RECEIVED
EVENTS_ACCEPTED
APPEND_BATCH_RECEIVED
APPEND_BATCH_ACCEPTED
This addresses bug FLUME-2081.
https://issues.apache.org/jira/browse/FLUME-2081
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java 641b5c6
Diff: https://reviews.apache.org/r/11821/diff/
Testing
-------
Ran existing tests
Thanks,
Sravya Tirukkovalur
Re: Review Request 11821: JMX support for SpoolDir Source
Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11821/#review23296
-----------------------------------------------------------
Ship it!
looks good, thanks
- Alexander Alten-Lorenz
On June 12, 2013, 4:18 p.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11821/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 4:18 p.m.)
>
>
> Review request for Flume, Brock Noland, Hari Shreedharan, and Mike Percy.
>
>
> Bugs: FLUME-2081
> https://issues.apache.org/jira/browse/FLUME-2081
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> SpoolDir Source supports following metrics:
> START
> STOP
> EVENTS_RECEIVED
> EVENTS_ACCEPTED
> APPEND_BATCH_RECEIVED
> APPEND_BATCH_ACCEPTED
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java 641b5c6
>
> Diff: https://reviews.apache.org/r/11821/diff/
>
>
> Testing
> -------
>
> Ran existing tests
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
Re: Review Request: JMX support for SpoolDir Source
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11821/#review22267
-----------------------------------------------------------
Ship it!
+1, looks good and unit tests pass
- Mike Percy
On June 12, 2013, 4:18 p.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11821/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 4:18 p.m.)
>
>
> Review request for Flume, Brock Noland, Mike Percy, and Hari Shreedharan.
>
>
> Description
> -------
>
> SpoolDir Source supports following metrics:
> START
> STOP
> EVENTS_RECEIVED
> EVENTS_ACCEPTED
> APPEND_BATCH_RECEIVED
> APPEND_BATCH_ACCEPTED
>
>
> This addresses bug FLUME-2081.
> https://issues.apache.org/jira/browse/FLUME-2081
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java 641b5c6
>
> Diff: https://reviews.apache.org/r/11821/diff/
>
>
> Testing
> -------
>
> Ran existing tests
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>