You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2023/06/19 02:15:05 UTC
[GitHub] [incubator-hugegraph] liuxiaocs7 opened a new pull request, #2234: chore: add pr template
liuxiaocs7 opened a new pull request, #2234:
URL: https://github.com/apache/incubator-hugegraph/pull/2234
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #2234: chore: add pr template
Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme commented on code in PR #2234:
URL: https://github.com/apache/incubator-hugegraph/pull/2234#discussion_r1235164745
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -0,0 +1,66 @@
+<!--
+ Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
+
+ Here are some tips for you:
+ 1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
+
+ 2. If a PR fix/close an issue, type the message "close xxx" (xxx is the link of related
+issue) in the content, GitHub will auto link it (Required)
+
+ 3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
+ such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
+ skip it if you are unsure about which is the best component.
+
+ 4. One PR address one issue, better not to mix up multiple issues.
+
+ 5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after
+published)
+-->
+
+## Purpose of the PR
+
+- close #xxx <!-- or use "fix #xxx", "xxx" is the ID-link of related issue, e.g: close #1024 -->
+
+<!--
+Please explain more context in this section, clarify why the changes are needed.
+e.g:
+- If you propose a new API, clarify the use case for a new API.
+- If you fix a bug, you can clarify why it is a bug, and should be associated with an issue.
+-->
+
+## Main Changes
+
+<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
+
+For example:
+
+- If you introduce a new feature, please show detailed design here or add the link of design documentation.
+- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
+- If there is a discussion in the mailing list, please add the link. -->
+
+## Verifying these changes
+
+<!-- Please pick the proper options below -->
+
+- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
+- [ ] Already covered by existing tests, such as *(please modify tests here)*.
+- [ ] Need tests and can be verified as follows:
+ - xxx
+
+## Does this PR potentially affect the following parts?
+
+<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
+
+- [ ] Nope
+- [ ] Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
+- [ ] Modify configurations
+- [ ] The public API
+- [ ] Other affects (typed here)
+
+## Documentation Status
+
+<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
+
+- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update later -->
+- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
+- [ ] `Doc - NO Need` <!-- Your PR changes don't impact/need docs -->
Review Comment:
it can be updated to "No Need"
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -0,0 +1,66 @@
+<!--
+ Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
+
+ Here are some tips for you:
+ 1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
+
+ 2. If a PR fix/close an issue, type the message "close xxx" (xxx is the link of related
+issue) in the content, GitHub will auto link it (Required)
+
+ 3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
+ such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
+ skip it if you are unsure about which is the best component.
+
+ 4. One PR address one issue, better not to mix up multiple issues.
+
+ 5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after
+published)
+-->
+
+## Purpose of the PR
+
+- close #xxx <!-- or use "fix #xxx", "xxx" is the ID-link of related issue, e.g: close #1024 -->
+
+<!--
+Please explain more context in this section, clarify why the changes are needed.
+e.g:
+- If you propose a new API, clarify the use case for a new API.
+- If you fix a bug, you can clarify why it is a bug, and should be associated with an issue.
+-->
+
+## Main Changes
+
+<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
+
+For example:
+
+- If you introduce a new feature, please show detailed design here or add the link of design documentation.
+- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
+- If there is a discussion in the mailing list, please add the link. -->
+
+## Verifying these changes
+
+<!-- Please pick the proper options below -->
+
+- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
+- [ ] Already covered by existing tests, such as *(please modify tests here)*.
+- [ ] Need tests and can be verified as follows:
+ - xxx
Review Comment:
keep "None"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #2234: chore: add pr template
Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme commented on code in PR #2234:
URL: https://github.com/apache/incubator-hugegraph/pull/2234#discussion_r1236713069
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -0,0 +1,66 @@
+<!--
+ Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
+
+ Here are some tips for you:
+ 1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
+
+ 2. If a PR fix/close an issue, type the message "close xxx" (xxx is the link of related
+issue) in the content, GitHub will auto link it (Required)
+
+ 3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
+ such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
+ skip it if you are unsure about which is the best component.
+
+ 4. One PR address one issue, better not to mix up multiple issues.
+
+ 5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after
+published)
+-->
+
+## Purpose of the PR
+
+- close #xxx <!-- or use "fix #xxx", "xxx" is the ID-link of related issue, e.g: close #1024 -->
+
+<!--
+Please explain more context in this section, clarify why the changes are needed.
+e.g:
+- If you propose a new API, clarify the use case for a new API.
+- If you fix a bug, you can clarify why it is a bug, and should be associated with an issue.
+-->
+
+## Main Changes
+
+<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
+
+For example:
+
+- If you introduce a new feature, please show detailed design here or add the link of design documentation.
+- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
+- If there is a discussion in the mailing list, please add the link. -->
+
+## Verifying these changes
+
+<!-- Please pick the proper options below -->
+
+- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
+- [ ] Already covered by existing tests, such as *(please modify tests here)*.
+- [ ] Need tests and can be verified as follows:
+ - xxx
Review Comment:
mean that we prefer to replace "xxx" with "None" since we may not need to test manually and modify the default list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] Radeity commented on a diff in pull request #2234: chore: add pr template
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on code in PR #2234:
URL: https://github.com/apache/incubator-hugegraph/pull/2234#discussion_r1233871692
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -0,0 +1,75 @@
+<!--
+ Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
+
+ Here are some tips for you:
+ 1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
+
+ 2. If a PR fix/close an issue, type the message "close xxx" (xxx is the link of related
+issue) in the content, GitHub will auto link it (Required)
+
+ 3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
+ such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
+ skip it if you are unsure about which is the best component.
+
+ 4. One PR address one issue, better not to mix up multiple issues.
+
+ 5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after
+published)
+-->
+
+## Purpose of the PR
+
+- close: xxx <!-- or use "fix: xxx", "xxx" is the link of related issue -->
+
+<!--
+Please explain more context in this section, clarify why the changes are needed.
+For example:
+- If you propose a new API, clarify the use case for a new API.
+- If you fix a bug, you can clarify why it is a bug, and should be associated with an issue.
+-->
+
+## Main Changes
+
+<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
+
+For example:
+
+- If you introduce a new feature, please show detailed design here or add the link of design documentation.
+- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
+- If there is a discussion in the mailing list, please add the link. -->
+
+## Verifying these changes
+
+<!-- Please pick either of the following options -->
+
+- This change is a trivial rework / code cleanup without any test coverage.
+
+*(or)*
+
+- This change is already covered by existing tests, such as *(please describe tests)*.
+
+*(or)*
+
+- This change added tests and can be verified as follows:
+
+ *(for example:)*
+ - *Add UT.*
Review Comment:
It's simpler now, I will synchronize the changes, thx :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2234: chore: add pr template
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2234:
URL: https://github.com/apache/incubator-hugegraph/pull/2234#discussion_r1233571370
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -0,0 +1,75 @@
+<!--
+ Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
+
+ Here are some tips for you:
+ 1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
+
+ 2. If a PR fix/close an issue, type the message "close xxx" (xxx is the link of related
+issue) in the content, GitHub will auto link it (Required)
+
+ 3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
+ such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
+ skip it if you are unsure about which is the best component.
+
+ 4. One PR address one issue, better not to mix up multiple issues.
+
+ 5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after
+published)
+-->
+
+## Purpose of the PR
+
+- close: xxx <!-- or use "fix: xxx", "xxx" is the link of related issue -->
+
+<!--
+Please explain more context in this section, clarify why the changes are needed.
+For example:
+- If you propose a new API, clarify the use case for a new API.
+- If you fix a bug, you can clarify why it is a bug, and should be associated with an issue.
+-->
+
+## Main Changes
+
+<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
+
+For example:
+
+- If you introduce a new feature, please show detailed design here or add the link of design documentation.
+- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
+- If there is a discussion in the mailing list, please add the link. -->
+
+## Verifying these changes
+
+<!-- Please pick either of the following options -->
+
+- This change is a trivial rework / code cleanup without any test coverage.
+
+*(or)*
+
+- This change is already covered by existing tests, such as *(please describe tests)*.
+
+*(or)*
+
+- This change added tests and can be verified as follows:
+
+ *(for example:)*
+ - *Add UT.*
Review Comment:
a little strange with the UI, any suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] imbajin merged pull request #2234: chore: add pr template
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #2234:
URL: https://github.com/apache/incubator-hugegraph/pull/2234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] Radeity commented on a diff in pull request #2234: chore: add pr template
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on code in PR #2234:
URL: https://github.com/apache/incubator-hugegraph/pull/2234#discussion_r1233913490
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -0,0 +1,66 @@
+<!--
+ Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
+
+ Here are some tips for you:
+ 1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
+
+ 2. If a PR fix/close an issue, type the message "close xxx" (xxx is the link of related
+issue) in the content, GitHub will auto link it (Required)
+
+ 3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
+ such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
+ skip it if you are unsure about which is the best component.
+
+ 4. One PR address one issue, better not to mix up multiple issues.
+
+ 5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after
+published)
+-->
+
+## Purpose of the PR
+
+- close #xxx <!-- or use "fix #xxx", "xxx" is the ID-link of related issue, e.g: close #1024 -->
+
+<!--
+Please explain more context in this section, clarify why the changes are needed.
+e.g:
+- If you propose a new API, clarify the use case for a new API.
+- If you fix a bug, you can clarify why it is a bug, and should be associated with an issue.
+-->
+
+## Main Changes
+
+<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
+
+For example:
+
+- If you introduce a new feature, please show detailed design here or add the link of design documentation.
+- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
+- If there is a discussion in the mailing list, please add the link. -->
+
+## Verifying these changes
+
+<!-- Please pick the proper options below -->
+
+- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
+- [ ] Already covered by existing tests, such as *(please modify tests here)*.
+- [ ] Need tests and can be verified as follows:
+ - xxx
+
+## Does this PR potentially affect the following parts?
+
+<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
+
+- [ ] Nope
+- [ ] Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
+- [ ] Modify configurations
+- [ ] The public API
+- [ ] Other affects (typed here)
+
+## Documentation Status
+
+<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
+
+- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update later -->
+- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
+- [ ] `Doc - NO Need` <!-- Your PR changes don't impact/need docs -->
Review Comment:
How about using upper case for all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2234: chore: add pr template
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2234:
URL: https://github.com/apache/incubator-hugegraph/pull/2234#discussion_r1233863475
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -0,0 +1,75 @@
+<!--
+ Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
+
+ Here are some tips for you:
+ 1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
+
+ 2. If a PR fix/close an issue, type the message "close xxx" (xxx is the link of related
+issue) in the content, GitHub will auto link it (Required)
+
+ 3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
+ such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
+ skip it if you are unsure about which is the best component.
+
+ 4. One PR address one issue, better not to mix up multiple issues.
+
+ 5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after
+published)
+-->
+
+## Purpose of the PR
+
+- close: xxx <!-- or use "fix: xxx", "xxx" is the link of related issue -->
+
+<!--
+Please explain more context in this section, clarify why the changes are needed.
+For example:
+- If you propose a new API, clarify the use case for a new API.
+- If you fix a bug, you can clarify why it is a bug, and should be associated with an issue.
+-->
+
+## Main Changes
+
+<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
+
+For example:
+
+- If you introduce a new feature, please show detailed design here or add the link of design documentation.
+- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
+- If there is a discussion in the mailing list, please add the link. -->
+
+## Verifying these changes
+
+<!-- Please pick either of the following options -->
+
+- This change is a trivial rework / code cleanup without any test coverage.
+
+*(or)*
+
+- This change is already covered by existing tests, such as *(please describe tests)*.
+
+*(or)*
+
+- This change added tests and can be verified as follows:
+
+ *(for example:)*
+ - *Add UT.*
Review Comment:
simplify the desc, check the UI again? @Radeity
<img width="594" alt="image" src="https://github.com/apache/incubator-hugegraph/assets/17706099/403e5d48-3b93-498f-9397-de800bfbcb4e">
and also remove `:` before `#issue` (refer [doc](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] codecov[bot] commented on pull request #2234: chore: add pr template
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2234:
URL: https://github.com/apache/incubator-hugegraph/pull/2234#issuecomment-1596390600
## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2234](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2234?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1baf726) into [master](https://app.codecov.io/gh/apache/incubator-hugegraph/commit/b836426db01567a6d912edf9fd0600dd624de62d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b836426) will **decrease** coverage by `20.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2234 +/- ##
=============================================
- Coverage 68.64% 48.63% -20.02%
+ Complexity 977 652 -325
=============================================
Files 498 498
Lines 40681 40623 -58
Branches 5681 5658 -23
=============================================
- Hits 27927 19758 -8169
- Misses 10055 18730 +8675
+ Partials 2699 2135 -564
```
[see 211 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2234/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] liuxiaocs7 commented on a diff in pull request #2234: chore: add pr template
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #2234:
URL: https://github.com/apache/incubator-hugegraph/pull/2234#discussion_r1236205446
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -0,0 +1,66 @@
+<!--
+ Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
+
+ Here are some tips for you:
+ 1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
+
+ 2. If a PR fix/close an issue, type the message "close xxx" (xxx is the link of related
+issue) in the content, GitHub will auto link it (Required)
+
+ 3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
+ such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
+ skip it if you are unsure about which is the best component.
+
+ 4. One PR address one issue, better not to mix up multiple issues.
+
+ 5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after
+published)
+-->
+
+## Purpose of the PR
+
+- close #xxx <!-- or use "fix #xxx", "xxx" is the ID-link of related issue, e.g: close #1024 -->
+
+<!--
+Please explain more context in this section, clarify why the changes are needed.
+e.g:
+- If you propose a new API, clarify the use case for a new API.
+- If you fix a bug, you can clarify why it is a bug, and should be associated with an issue.
+-->
+
+## Main Changes
+
+<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
+
+For example:
+
+- If you introduce a new feature, please show detailed design here or add the link of design documentation.
+- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
+- If there is a discussion in the mailing list, please add the link. -->
+
+## Verifying these changes
+
+<!-- Please pick the proper options below -->
+
+- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
+- [ ] Already covered by existing tests, such as *(please modify tests here)*.
+- [ ] Need tests and can be verified as follows:
+ - xxx
Review Comment:
I don't quite understand, could you explain in more detail? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] liuxiaocs7 commented on a diff in pull request #2234: chore: add pr template
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #2234:
URL: https://github.com/apache/incubator-hugegraph/pull/2234#discussion_r1233690601
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -0,0 +1,75 @@
+<!--
+ Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
+
+ Here are some tips for you:
+ 1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
+
+ 2. If a PR fix/close an issue, type the message "close xxx" (xxx is the link of related
+issue) in the content, GitHub will auto link it (Required)
+
+ 3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
+ such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
+ skip it if you are unsure about which is the best component.
+
+ 4. One PR address one issue, better not to mix up multiple issues.
+
+ 5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after
+published)
+-->
+
+## Purpose of the PR
+
+- close: xxx <!-- or use "fix: xxx", "xxx" is the link of related issue -->
+
+<!--
+Please explain more context in this section, clarify why the changes are needed.
+For example:
+- If you propose a new API, clarify the use case for a new API.
+- If you fix a bug, you can clarify why it is a bug, and should be associated with an issue.
+-->
+
+## Main Changes
+
+<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
+
+For example:
+
+- If you introduce a new feature, please show detailed design here or add the link of design documentation.
+- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
+- If there is a discussion in the mailing list, please add the link. -->
+
+## Verifying these changes
+
+<!-- Please pick either of the following options -->
+
+- This change is a trivial rework / code cleanup without any test coverage.
+
+*(or)*
+
+- This change is already covered by existing tests, such as *(please describe tests)*.
+
+*(or)*
+
+- This change added tests and can be verified as follows:
+
+ *(for example:)*
+ - *Add UT.*
Review Comment:
remove italics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2234: chore: add pr template
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2234:
URL: https://github.com/apache/incubator-hugegraph/pull/2234#discussion_r1236747863
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -0,0 +1,66 @@
+<!--
+ Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
+
+ Here are some tips for you:
+ 1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
+
+ 2. If a PR fix/close an issue, type the message "close xxx" (xxx is the link of related
+issue) in the content, GitHub will auto link it (Required)
+
+ 3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
+ such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
+ skip it if you are unsure about which is the best component.
+
+ 4. One PR address one issue, better not to mix up multiple issues.
+
+ 5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after
+published)
+-->
+
+## Purpose of the PR
+
+- close #xxx <!-- or use "fix #xxx", "xxx" is the ID-link of related issue, e.g: close #1024 -->
+
+<!--
+Please explain more context in this section, clarify why the changes are needed.
+e.g:
+- If you propose a new API, clarify the use case for a new API.
+- If you fix a bug, you can clarify why it is a bug, and should be associated with an issue.
+-->
+
+## Main Changes
+
+<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
+
+For example:
+
+- If you introduce a new feature, please show detailed design here or add the link of design documentation.
+- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
+- If there is a discussion in the mailing list, please add the link. -->
+
+## Verifying these changes
+
+<!-- Please pick the proper options below -->
+
+- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
+- [ ] Already covered by existing tests, such as *(please modify tests here)*.
+- [ ] Need tests and can be verified as follows:
+ - xxx
Review Comment:
> mean that we prefer to replace "xxx" with "None" since we may not need to test manually and modify the default list.
`None` seems duplicate with the first option (No Need), and devs could remove it manually, we could test & enhance it later (listen the users feedback)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2234: chore: add pr template
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2234:
URL: https://github.com/apache/incubator-hugegraph/pull/2234#discussion_r1234997521
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -0,0 +1,66 @@
+<!--
+ Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
+
+ Here are some tips for you:
+ 1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
+
+ 2. If a PR fix/close an issue, type the message "close xxx" (xxx is the link of related
+issue) in the content, GitHub will auto link it (Required)
+
+ 3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
+ such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
+ skip it if you are unsure about which is the best component.
+
+ 4. One PR address one issue, better not to mix up multiple issues.
+
+ 5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after
+published)
+-->
+
+## Purpose of the PR
+
+- close #xxx <!-- or use "fix #xxx", "xxx" is the ID-link of related issue, e.g: close #1024 -->
+
+<!--
+Please explain more context in this section, clarify why the changes are needed.
+e.g:
+- If you propose a new API, clarify the use case for a new API.
+- If you fix a bug, you can clarify why it is a bug, and should be associated with an issue.
+-->
+
+## Main Changes
+
+<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
+
+For example:
+
+- If you introduce a new feature, please show detailed design here or add the link of design documentation.
+- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
+- If there is a discussion in the mailing list, please add the link. -->
+
+## Verifying these changes
+
+<!-- Please pick the proper options below -->
+
+- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
+- [ ] Already covered by existing tests, such as *(please modify tests here)*.
+- [ ] Need tests and can be verified as follows:
+ - xxx
+
+## Does this PR potentially affect the following parts?
+
+<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
+
+- [ ] Nope
+- [ ] Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
+- [ ] Modify configurations
+- [ ] The public API
+- [ ] Other affects (typed here)
+
+## Documentation Status
+
+<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
+
+- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update later -->
+- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
+- [ ] `Doc - NO Need` <!-- Your PR changes don't impact/need docs -->
Review Comment:
> How about using upper case for all?
@liuxiaocs7 @javeme how do u think? (Both fine for me)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] Radeity commented on a diff in pull request #2234: chore: add pr template
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on code in PR #2234:
URL: https://github.com/apache/incubator-hugegraph/pull/2234#discussion_r1233869158
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -0,0 +1,66 @@
+<!--
+ Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
+
+ Here are some tips for you:
+ 1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
+
+ 2. If a PR fix/close an issue, type the message "close xxx" (xxx is the link of related
+issue) in the content, GitHub will auto link it (Required)
+
+ 3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
+ such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
+ skip it if you are unsure about which is the best component.
+
+ 4. One PR address one issue, better not to mix up multiple issues.
+
+ 5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after
+published)
+-->
+
+## Purpose of the PR
+
+- close #xxx <!-- or use "fix #xxx", "xxx" is the ID-link of related issue, e.g: close #1024 -->
+
+<!--
+Please explain more context in this section, clarify why the changes are needed.
+e.g:
+- If you propose a new API, clarify the use case for a new API.
+- If you fix a bug, you can clarify why it is a bug, and should be associated with an issue.
+-->
+
+## Main Changes
+
+<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
+
+For example:
+
+- If you introduce a new feature, please show detailed design here or add the link of design documentation.
+- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
+- If there is a discussion in the mailing list, please add the link. -->
+
+## Verifying these changes
+
+<!-- Please pick the proper options below -->
+
+- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
+- [ ] Already covered by existing tests, such as *(please modify tests here)*.
+- [ ] Need tests and can be verified as follows:
+ - xxx
+
+## Does this PR potentially affect the following parts?
+
+<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
+
+- [ ] Nope
+- [ ] Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
+- [ ] Modify configurations
+- [ ] The public API
+- [ ] Other affects (typed here)
+
+## Documentation Status
+
+<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
+
+- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update later -->
+- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
+- [ ] `Doc - NO Need` <!-- Your PR changes don't impact/need docs -->
Review Comment:
Should we uniform the case of `TODO`, `Done`, `NO Need`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2234: chore: add pr template
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2234:
URL: https://github.com/apache/incubator-hugegraph/pull/2234#discussion_r1233910990
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -0,0 +1,66 @@
+<!--
+ Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
+
+ Here are some tips for you:
+ 1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
+
+ 2. If a PR fix/close an issue, type the message "close xxx" (xxx is the link of related
+issue) in the content, GitHub will auto link it (Required)
+
+ 3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
+ such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
+ skip it if you are unsure about which is the best component.
+
+ 4. One PR address one issue, better not to mix up multiple issues.
+
+ 5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after
+published)
+-->
+
+## Purpose of the PR
+
+- close #xxx <!-- or use "fix #xxx", "xxx" is the ID-link of related issue, e.g: close #1024 -->
+
+<!--
+Please explain more context in this section, clarify why the changes are needed.
+e.g:
+- If you propose a new API, clarify the use case for a new API.
+- If you fix a bug, you can clarify why it is a bug, and should be associated with an issue.
+-->
+
+## Main Changes
+
+<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
+
+For example:
+
+- If you introduce a new feature, please show detailed design here or add the link of design documentation.
+- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
+- If there is a discussion in the mailing list, please add the link. -->
+
+## Verifying these changes
+
+<!-- Please pick the proper options below -->
+
+- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
+- [ ] Already covered by existing tests, such as *(please modify tests here)*.
+- [ ] Need tests and can be verified as follows:
+ - xxx
+
+## Does this PR potentially affect the following parts?
+
+<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
+
+- [ ] Nope
+- [ ] Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
+- [ ] Modify configurations
+- [ ] The public API
+- [ ] Other affects (typed here)
+
+## Documentation Status
+
+<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
+
+- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update later -->
+- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
+- [ ] `Doc - NO Need` <!-- Your PR changes don't impact/need docs -->
Review Comment:
> Should we uniform the case of `TODO`, `Done`, `NO Need`?
like what?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org