You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/02 04:11:30 UTC
[GitHub] codecov-io commented on issue #4724: Improve database type inference
codecov-io commented on issue #4724: Improve database type inference
URL: https://github.com/apache/incubator-superset/pull/4724#issuecomment-377632311
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4724?src=pr&el=h1) Report
> Merging [#4724](https://codecov.io/gh/apache/incubator-superset/pull/4724?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/069d61c53f03608f05a0684572b9a2bb545fd9a6?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/4724/graphs/tree.svg?height=150&width=650&token=KsB0fHcx6l&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4724?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4724 +/- ##
==========================================
+ Coverage 72.22% 72.26% +0.03%
==========================================
Files 204 204
Lines 15323 15344 +21
Branches 1180 1180
==========================================
+ Hits 11067 11088 +21
Misses 4253 4253
Partials 3 3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4724?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4724/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `71.97% <100%> (-3.59%)` | :arrow_down: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4724/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `53.41% <100%> (+1.51%)` | :arrow_up: |
| [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/4724/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `99.05% <100%> (+0.3%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4724?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4724?src=pr&el=footer). Last update [069d61c...5fd632b](https://codecov.io/gh/apache/incubator-superset/pull/4724?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services