You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/09/13 02:33:33 UTC
[GitHub] [incubator-inlong] LeBW opened a new pull request #1537: Add Apollo dependency and config for InLong-Manager
LeBW opened a new pull request #1537:
URL: https://github.com/apache/incubator-inlong/pull/1537
### [INLONG-1316][InLong-Manager] Add Apollo dependency and config for InLong-Manager
Fixes #1316 (partially)
### Modifications
Add Apollo dependency and config for InLong-Manager.
The Apollo is disabled by default, and the local configuration files is enabled.
If you want to use Apollo as configuration server, you need to do following things:
1. change `apollo.bootstrap.enabled` to `true`.
2. change `apollo.meta` to your Apollo meta service URL.
Then you can use Apollo as the configuration server, and the local configuration files will be overridden.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] LeBW commented on pull request #1537: Add Apollo dependency and config for InLong-Manager
Posted by GitBox <gi...@apache.org>.
LeBW commented on pull request #1537:
URL: https://github.com/apache/incubator-inlong/pull/1537#issuecomment-917805785
> @LeBW it's better to add related code for this PR, like how to use `apollo.bootstrap.enabled` configuration in the code.
> what's more, if you split #1316 into multi sub-tasks, it's better to record each sub-task issue like #1496. Each PR must have its own issue, which solves a specific problem.
got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang closed pull request #1537: Add Apollo dependency and config for InLong-Manager
Posted by GitBox <gi...@apache.org>.
dockerzhang closed pull request #1537:
URL: https://github.com/apache/incubator-inlong/pull/1537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter commented on pull request #1537: Add Apollo dependency and config for InLong-Manager
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1537:
URL: https://github.com/apache/incubator-inlong/pull/1537#issuecomment-917790455
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1537?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1537](https://codecov.io/gh/apache/incubator-inlong/pull/1537?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2ba10db) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/771b942f7f779300e485583cfb103f33930db800?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (771b942) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/1537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1537 +/- ##
============================================
- Coverage 12.21% 12.20% -0.01%
+ Complexity 1052 1050 -2
============================================
Files 392 392
Lines 32736 32736
Branches 5157 5157
============================================
- Hits 3999 3996 -3
- Misses 27974 27976 +2
- Partials 763 764 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/1537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../inlong/tubemq/corebase/policies/FlowCtrlItem.java](https://codecov.io/gh/apache/incubator-inlong/pull/1537/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW5sb25nL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybEl0ZW0uamF2YQ==) | `38.88% <0.00%> (-1.12%)` | :arrow_down: |
| [.../tubemq/corebase/policies/FlowCtrlRuleHandler.java](https://codecov.io/gh/apache/incubator-inlong/pull/1537/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW5sb25nL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybFJ1bGVIYW5kbGVyLmphdmE=) | `34.07% <0.00%> (-0.45%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1537?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1537?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [771b942...2ba10db](https://codecov.io/gh/apache/incubator-inlong/pull/1537?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #1537: Add Apollo dependency and config for InLong-Manager
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #1537:
URL: https://github.com/apache/incubator-inlong/pull/1537#issuecomment-917795982
@LeBW it's better to add related code for this PR, like how to use `apollo.bootstrap.enabled` configuration in the code.
what's more, if you split #1316 into multi sub-tasks, it's better to record each sub-task issue like #1496. Each PR must have its own issue, which solves a specific problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org