[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #884: [WIP][ISSUE-883] Transitively export the dependencies of [eventmesh-sdk-java] to other module

[GitBox <gi...@apache.org>]

ruanwenjun commented on PR #884:
URL: https://github.com/apache/incubator-eventmesh/pull/884#issuecomment-1134203619

   > > Good catch. Right now, the scope of `eventmesh-common` in `eventmesh-sdk-java` is `implementation`, so if we want to use eventmesh-sdk-java in our app, we need to add the `eventmesh-common` to our dependency. We need to change the scope from `implementation` to api to solve this.
   > > And I think we don't need to make a shawdow jar. cc @xwm1992
   > 
   > Currently I'm trying to use the following script to generate a fat jar of [eventmesh-sdk-java] (without the usage of `shadow` plugin), sometimes it works. Mark the PR work in progress.
   > 
   > ```
   > jar {
   >     from {
   >         configurations. runtimeClasspath.filter{ it.exists() }.collect { it.isDirectory() ? it : zipTree(it) }
   >     }
   > }
   > ```
   
   I suggest we just change the scope of `eventmesh-commom` to `spi` is enough.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org