You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/08 08:46:54 UTC

[GitHub] kaxil commented on a change in pull request #3703: [AIRFLOW-2857] Fix broken RTD env

kaxil commented on a change in pull request #3703: [AIRFLOW-2857] Fix broken RTD env 
URL: https://github.com/apache/incubator-airflow/pull/3703#discussion_r208502954
 
 

 ##########
 File path: setup.py
 ##########
 @@ -161,6 +164,7 @@ def write_version(filename=os.path.join(*['airflow',
 databricks = ['requests>=2.5.1, <3']
 datadog = ['datadog>=0.14.0']
 doc = [
+    'mock',
 
 Review comment:
   I did some digging and looks like we use it here:
   https://github.com/apache/incubator-airflow/blob/acca61c602e341da06ebee2eca3a26f4e7400238/docs/conf.py#L16
   
   This is used for mocking import of various modules:
   https://github.com/apache/incubator-airflow/blob/master/docs/conf.py#L18-L31
   
   
   Reference: http://blog.rtwilson.com/how-to-make-your-sphinx-documentation-compile-with-readthedocs-when-youre-using-numpy-and-scipy/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services