You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/08/04 23:06:54 UTC
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10510: feat: add favorite star to dashboard and chart lists
codecov-commenter commented on pull request #10510:
URL: https://github.com/apache/incubator-superset/pull/10510#issuecomment-668869885
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10510?src=pr&el=h1) Report
> Merging [#10510](https://codecov.io/gh/apache/incubator-superset/pull/10510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c9cb723cab321b82c3153f1a2b9fde27e9270106&el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `81.96%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10510 +/- ##
==========================================
+ Coverage 70.85% 71.00% +0.14%
==========================================
Files 604 605 +1
Lines 32400 32484 +84
Branches 3414 3438 +24
==========================================
+ Hits 22956 23064 +108
+ Misses 9332 9309 -23
+ Partials 112 111 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.05% <80.00%> (+0.33%)` | :arrow_up: |
| #javascript | `59.98% <75.40%> (+0.26%)` | :arrow_up: |
| #python | `70.40% <ø> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10510/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `64.10% <38.88%> (-21.62%)` | :arrow_down: |
| [superset-frontend/src/components/FaveStar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10510/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmF2ZVN0YXIudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Icon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10510/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi50c3g=) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10510/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `55.78% <100.00%> (+0.30%)` | :arrow_up: |
| [...tend/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10510/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIuanN4) | `83.33% <100.00%> (+0.98%)` | :arrow_up: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10510/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `71.09% <100.00%> (+1.67%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10510/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `70.07% <100.00%> (+1.74%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/10510/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `70.83% <0.00%> (-29.17%)` | :arrow_down: |
| [superset/examples/energy.py](https://codecov.io/gh/apache/incubator-superset/pull/10510/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | `82.50% <0.00%> (-2.12%)` | :arrow_down: |
| [superset/examples/unicode\_test\_data.py](https://codecov.io/gh/apache/incubator-superset/pull/10510/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdW5pY29kZV90ZXN0X2RhdGEucHk=) | `80.00% <0.00%> (-1.64%)` | :arrow_down: |
| ... and [46 more](https://codecov.io/gh/apache/incubator-superset/pull/10510/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10510?src=pr&el=footer). Last update [c9cb723...07ce20c](https://codecov.io/gh/apache/incubator-superset/pull/10510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org