You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/06 16:09:44 UTC

[GitHub] [airflow] ephraimbuddy opened a new pull request #14645: Use OpenAPI validation and only use updateable fields in request body for PATCH endpoints of DAG and Variable.

ephraimbuddy opened a new pull request #14645:
URL: https://github.com/apache/airflow/pull/14645


   Closes: #14635 
   This two endpoints DAG `PATCH` and Variable `PATCH` allows only a single field to be updated and were being given the DAG and Variable objects in the requestBody respectively. This causes confusion and I feel we should let users know that they don't need the DAG or Variable object for their updates
   
   This PR changes the behaviour and also switch to using Openapi for validation in the requestBody instead of schema validation
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj edited a comment on pull request #14645: Use OpenAPI validation and only use updateable fields in request body for PATCH endpoints of DAG and Variable.

Posted by GitBox <gi...@apache.org>.

mik-laj edited a comment on pull request #14645:
URL: https://github.com/apache/airflow/pull/14645#issuecomment-792004494


   I don't understand this change.  according to the specification, these fields should never be sent. See: https://github.com/zalando/connexion/issues/942
   
   we should fix clienr whch don't respect OpenAPI specs, not make changes to our API specs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #14645: Use OpenAPI validation and only use updateable fields in request body for PATCH endpoints of DAG and Variable.

Posted by GitBox <gi...@apache.org>.

mik-laj commented on pull request #14645:
URL: https://github.com/apache/airflow/pull/14645#issuecomment-792122001


   I am still not convinced that this change is a good idea. Especially in strongly typed languages like Java, this means that we will have several kinds of objects. This does not follow the REST convention.  The REST convention limits the number of different types of objects for different operations.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #14645: Use OpenAPI validation and only use updateable fields in request body for PATCH endpoints of DAG and Variable.

Posted by GitBox <gi...@apache.org>.

mik-laj commented on a change in pull request #14645:
URL: https://github.com/apache/airflow/pull/14645#discussion_r588912631



##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -425,7 +425,12 @@ paths:
         content:
           application/json:
             schema:
-              $ref: '#/components/schemas/DAG'
+              type: object

Review comment:
       We should named components here. Otherwise there may be problems with generating classes for API client  
   
    I personally prefer to always use named components.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ephraimbuddy closed pull request #14645: Use OpenAPI validation and only use updateable fields in request body for PATCH endpoints of DAG and Variable.

Posted by GitBox <gi...@apache.org>.

ephraimbuddy closed pull request #14645:
URL: https://github.com/apache/airflow/pull/14645


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #14645: Use OpenAPI validation and only use updateable fields in request body for PATCH endpoints of DAG and Variable.

Posted by GitBox <gi...@apache.org>.

mik-laj commented on pull request #14645:
URL: https://github.com/apache/airflow/pull/14645#issuecomment-792004494


   I don't understand this change.  according to the specification, these fields should never be sent. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj edited a comment on pull request #14645: Use OpenAPI validation and only use updateable fields in request body for PATCH endpoints of DAG and Variable.

Posted by GitBox <gi...@apache.org>.

mik-laj edited a comment on pull request #14645:
URL: https://github.com/apache/airflow/pull/14645#issuecomment-792004494


   I don't understand this change.  according to the OpenAPI specification, these fields should never be sent. See: https://github.com/zalando/connexion/issues/942
   
   we should fix clients which don't respect OpenAPI specs, not make changes to our API specs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org