You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/12/19 05:27:56 UTC
[GitHub] [kafka] venkatteki opened a new pull request #11615: KAFKA-13546[WIP]: Do not fail connector if default topic creation group is explicitly specified
venkatteki opened a new pull request #11615:
URL: https://github.com/apache/kafka/pull/11615
### Problem:
If user specifies `default` group as part of topic.creation.groups config, that is causing the connector to fail.
According to KIP-158, specifying `default` group as part of topic.creation.groups config should throw a warning, but not let connector fail.
### Fix
Remove the `default` topic creation group from user input if specified explicitly, and log a warning message
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] venkatteki commented on pull request #11615: KAFKA-13546: Do not fail connector if default topic creation group is explicitly specified
Posted by GitBox <gi...@apache.org>.
venkatteki commented on pull request #11615:
URL: https://github.com/apache/kafka/pull/11615#issuecomment-1002597957
@kkonstantine @rhauch Can you please review this PR
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] venkatteki commented on pull request #11615: KAFKA-13546: Do not fail connector if default topic creation group is explicitly specified
Posted by GitBox <gi...@apache.org>.
venkatteki commented on pull request #11615:
URL: https://github.com/apache/kafka/pull/11615#issuecomment-997357188
Failing test doesnt seem to be related to this change:
`integration.kafka.server.FetchRequestBetweenDifferentIbpTest.testControllerNewToOldIBP()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on a change in pull request #11615: KAFKA-13546: Do not fail connector if default topic creation group is explicitly specified
Posted by GitBox <gi...@apache.org>.
C0urante commented on a change in pull request #11615:
URL: https://github.com/apache/kafka/pull/11615#discussion_r782322703
##########
File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceConnectorConfigTest.java
##########
@@ -64,6 +67,18 @@
return props;
}
+ @Test
+ public void shouldNotFailWithExplicitlySpecifiedDefaultTopicCreationGroup() {
+ Map<String, String> props = defaultConnectorProps();
+ //Ensure default group is omitted even if its specified multiple times.
+ props.put(TOPIC_CREATION_GROUPS_CONFIG, String.join(",", DEFAULT_TOPIC_CREATION_GROUP,
+ TOPIC_CREATION_GROUP_1, DEFAULT_TOPIC_CREATION_GROUP, TOPIC_CREATION_GROUP_2));
+ props.put(TOPIC_CREATION_GROUPS_CONFIG, DEFAULT_TOPIC_CREATION_GROUP);
Review comment:
Was this left in accidentally? Looks like it overrides the line above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] venkatteki commented on a change in pull request #11615: KAFKA-13546: Do not fail connector if default topic creation group is explicitly specified
Posted by GitBox <gi...@apache.org>.
venkatteki commented on a change in pull request #11615:
URL: https://github.com/apache/kafka/pull/11615#discussion_r787676776
##########
File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceConnectorConfigTest.java
##########
@@ -64,6 +67,18 @@
return props;
}
+ @Test
+ public void shouldNotFailWithExplicitlySpecifiedDefaultTopicCreationGroup() {
+ Map<String, String> props = defaultConnectorProps();
+ //Ensure default group is omitted even if its specified multiple times.
+ props.put(TOPIC_CREATION_GROUPS_CONFIG, String.join(",", DEFAULT_TOPIC_CREATION_GROUP,
+ TOPIC_CREATION_GROUP_1, DEFAULT_TOPIC_CREATION_GROUP, TOPIC_CREATION_GROUP_2));
+ props.put(TOPIC_CREATION_GROUPS_CONFIG, DEFAULT_TOPIC_CREATION_GROUP);
Review comment:
> Was this left in accidentally? Looks like it overrides the line above, which seems more suitable for this test case.
Thanks for catching it! fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on a change in pull request #11615: KAFKA-13546: Do not fail connector if default topic creation group is explicitly specified
Posted by GitBox <gi...@apache.org>.
C0urante commented on a change in pull request #11615:
URL: https://github.com/apache/kafka/pull/11615#discussion_r782322703
##########
File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceConnectorConfigTest.java
##########
@@ -64,6 +67,18 @@
return props;
}
+ @Test
+ public void shouldNotFailWithExplicitlySpecifiedDefaultTopicCreationGroup() {
+ Map<String, String> props = defaultConnectorProps();
+ //Ensure default group is omitted even if its specified multiple times.
+ props.put(TOPIC_CREATION_GROUPS_CONFIG, String.join(",", DEFAULT_TOPIC_CREATION_GROUP,
+ TOPIC_CREATION_GROUP_1, DEFAULT_TOPIC_CREATION_GROUP, TOPIC_CREATION_GROUP_2));
+ props.put(TOPIC_CREATION_GROUPS_CONFIG, DEFAULT_TOPIC_CREATION_GROUP);
Review comment:
Was this left in accidentally? Looks like it overrides the line above, which seems more suitable for this test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] venkatteki edited a comment on pull request #11615: KAFKA-13546: Do not fail connector if default topic creation group is explicitly specified
Posted by GitBox <gi...@apache.org>.
venkatteki edited a comment on pull request #11615:
URL: https://github.com/apache/kafka/pull/11615#issuecomment-1002597957
@kkonstantine @rhauch Can you please review this PR ( I dont seem to have access to add the reviewers, so leaving a comment)
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org