[GitHub] spark pull request #14279: [SPARK-16216][SQL][WIP] Read/write timestamps and...

[rxin <gi...@git.apache.org>]

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14279#discussion_r75195100
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ---
    @@ -62,6 +64,11 @@ object DateTimeUtils {
     
       @transient lazy val defaultTimeZone = TimeZone.getDefault
     
    +  // These are ISO 8601 compliant `FastDateFormat`s. These are thread-safe and compatible
    +  // with `SimpleDateFormat`.
    +  lazy val iso8601TimeFormat = FastDateFormat.getInstance("yyyy-MM-dd'T'HH:mm:ss.SSSZZ")
    --- End diff --
    
    It's only expensive if you want to initialize it per row. An one-time init is probably fine.
    
    Do we need to worry about thread safety, e.g. is this instance thread safe? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org