You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/07/14 05:06:15 UTC
[GitHub] [iotdb] yyt86 opened a new pull request #3562: add checkDeviceIdExist method to ITimeIndex
yyt86 opened a new pull request #3562:
URL: https://github.com/apache/iotdb/pull/3562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3562: add checkDeviceIdExist method to ITimeIndex
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3562:
URL: https://github.com/apache/iotdb/pull/3562#issuecomment-879616928
[](https://coveralls.io/builds/41382105)
Coverage decreased (-0.04%) to 68.139% when pulling **af5a49e4ddcd0507716aeecace34ce5bfe996ff3 on yyt86:remove_device_set** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #3562: add checkDeviceIdExist method to ITimeIndex
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #3562:
URL: https://github.com/apache/iotdb/pull/3562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3562: add checkDeviceIdExist method to ITimeIndex
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3562:
URL: https://github.com/apache/iotdb/pull/3562#issuecomment-879616928
[](https://coveralls.io/builds/41420059)
Coverage decreased (-0.03%) to 68.149% when pulling **c32fc8394b4e93b4efdecd2601385c8229f01e9b on yyt86:remove_device_set** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3562: add checkDeviceIdExist method to ITimeIndex
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3562:
URL: https://github.com/apache/iotdb/pull/3562#issuecomment-879616928
[](https://coveralls.io/builds/41387718)
Coverage decreased (-0.03%) to 68.146% when pulling **a7db4d21318c3fa6d229375b1fe9228f93f86444 on yyt86:remove_device_set** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a change in pull request #3562: add checkDeviceIdExist method to ITimeIndex
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #3562:
URL: https://github.com/apache/iotdb/pull/3562#discussion_r670046357
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileResource.java
##########
@@ -627,10 +627,14 @@ public boolean stillLives(long timeLowerBound) {
return timeIndex.stillLives(timeLowerBound);
}
+ public boolean isDeviceIdInRes(String deviceId) {
+ return timeIndex.checkDeviceIdExist(deviceId);
+ }
+
/** @return true if the device is contained in the TsFile and it lives beyond TTL */
public boolean isSatisfied(
String deviceId, Filter timeFilter, boolean isSeq, long ttl, boolean debug) {
- if (!timeIndex.checkDeviceIdExist(deviceId)) {
+ if (!isDeviceIdInRes(deviceId)) {
Review comment:
Hi, here you could directly use timeIndex.checkDeviceIdExist, eliminating a function call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a change in pull request #3562: add checkDeviceIdExist method to ITimeIndex
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #3562:
URL: https://github.com/apache/iotdb/pull/3562#discussion_r670213753
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileResource.java
##########
@@ -627,10 +627,14 @@ public boolean stillLives(long timeLowerBound) {
return timeIndex.stillLives(timeLowerBound);
}
+ public boolean isDeviceIdInRes(String deviceId) {
Review comment:
```suggestion
public boolean isDeviceIdExist(String deviceId) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #3562: add checkDeviceIdExist method to ITimeIndex
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3562:
URL: https://github.com/apache/iotdb/pull/3562#issuecomment-879616928
[](https://coveralls.io/builds/41352486)
Coverage increased (+0.003%) to 68.178% when pulling **209f0548dc606a033277bebe2037e904af325637 on yyt86:remove_device_set** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a change in pull request #3562: add checkDeviceIdExist method to ITimeIndex
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #3562:
URL: https://github.com/apache/iotdb/pull/3562#discussion_r669714393
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/timeindex/DeviceTimeIndex.java
##########
@@ -44,6 +47,8 @@
protected static final Map<String, String> cachedDevicePool =
CachedStringPool.getInstance().getCachedPool();
+ private static final Logger DEBUG_LOGGER = LoggerFactory.getLogger("QUERY_DEBUG");
Review comment:
Is this used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org