[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull request #53: Additions for ESP32

[GitBox <gi...@apache.org>]

yamt commented on a change in pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#discussion_r465588963



##########
File path: docker/linux/Dockerfile
##########
@@ -183,12 +182,13 @@ ENV PATH="/tools/pinguino-compilers/p32/bin:$PATH"
 # RISCV toolchain
 COPY --from=nuttx-toolchain-riscv /tools/riscv64-unknown-elf-gcc/ riscv64-unknown-elf-gcc/
 ENV PATH="/tools/riscv64-unknown-elf-gcc/bin:$PATH"
- 
+
 # ESP32 toolchain
 COPY --from=nuttx-toolchain-esp32 /tools/xtensa-esp32-elf-gcc/ xtensa-esp32-elf-gcc/
+COPY --from=nuttx-toolchain-esp32 /tools/esp-idf/ esp-idf/
 ENV PATH="/tools/xtensa-esp32-elf-gcc/bin:$PATH"
 RUN mkdir -p /tools/blobs/esp32core
 COPY --from=nuttx-toolchain-esp32 /tools/blobs/* /tools/blobs/esp32core/
 RUN pip3 install esptool
 
-ENTRYPOINT [ "/bin/bash" ]
+CMD [ "/bin/bash" ]

Review comment:
       you can always override it with --entrypoint.
   
   on the other hand, the ENTRYPOINT usage here looks a bit unusual for me.
   @btashton can you explain why it's done this way? i guess the ci can specify bash, rather than just "-c".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org