You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Shuai Lin <li...@gmail.com> on 2016/04/23 04:33:36 UTC
Re: Review Request 42806: Added the fetcher plugin module interface.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42806/
-----------------------------------------------------------
(Updated April 23, 2016, 2:33 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
rebased
Bugs: MESOS-3926
https://issues.apache.org/jira/browse/MESOS-3926
Repository: mesos
Description
-------
Added the fetcher plugin module interface.
Diffs (updated)
-----
include/mesos/module/fetcher_plugin.hpp PRE-CREATION
src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca
src/examples/test_fetcher_plugin_module.cpp PRE-CREATION
src/module/manager.cpp 9f88ec3addab59e4a40b0b40612518178d535aa5
src/tests/module.hpp e661d95fa44fc1aedfe83c564c826d5b7d32c85b
src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505
src/uri/fetcher.hpp 8af2c9122e0b15fd54f7d3a84779540e7186f566
src/uri/fetcher.cpp aa9df5d0256a26b8684934c2bd37b82a069088f7
Diff: https://reviews.apache.org/r/42806/diff/
Testing
-------
make check
Thanks,
Shuai Lin
Re: Review Request 42806: Added the fetcher plugin module interface.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42806/#review130490
-----------------------------------------------------------
FYI: I will be making some changes to the fetcher underneath your change here. See the new issues added to the epic: MESOS-3918
src/uri/fetcher.hpp (lines 40 - 50)
<https://reviews.apache.org/r/42806/#comment194216>
This flag-based initialization method for the fetcher plugins doesn't make too much sense. Instead, we should probably go for something like the `--isolation` agent flag.
i.e. `--fetcher_plugins=builtin/copy;builtin/curl;builtin/hadoop;builtin/docker;<some_custom_plugin>;...`
That would allow re-ordering of plugins as well as multiple custom plugins.
---
Also, all these flags are empty, other than `HadoopFetcherPlugin::Flags`. Now would be a good opportunity to get rid of these flags. The Hadoop plugin would be a good candidate for an example Fetcher plugin implementation.
(Parameters/Flags for plugins would be specified in the `--modules` flag.)
- Joseph Wu
On April 22, 2016, 7:33 p.m., Shuai Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42806/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 7:33 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-3926
> https://issues.apache.org/jira/browse/MESOS-3926
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the fetcher plugin module interface.
>
>
> Diffs
> -----
>
> include/mesos/module/fetcher_plugin.hpp PRE-CREATION
> src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca
> src/examples/test_fetcher_plugin_module.cpp PRE-CREATION
> src/module/manager.cpp 9f88ec3addab59e4a40b0b40612518178d535aa5
> src/tests/module.hpp e661d95fa44fc1aedfe83c564c826d5b7d32c85b
> src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505
> src/uri/fetcher.hpp 8af2c9122e0b15fd54f7d3a84779540e7186f566
> src/uri/fetcher.cpp aa9df5d0256a26b8684934c2bd37b82a069088f7
>
> Diff: https://reviews.apache.org/r/42806/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Shuai Lin
>
>
Re: Review Request 42806: Added the fetcher plugin module interface.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42806/#review167296
-----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews.
- Joris Van Remoortere
On April 23, 2016, 2:33 a.m., Shuai Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42806/
> -----------------------------------------------------------
>
> (Updated April 23, 2016, 2:33 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-3926
> https://issues.apache.org/jira/browse/MESOS-3926
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the fetcher plugin module interface.
>
>
> Diffs
> -----
>
> include/mesos/module/fetcher_plugin.hpp PRE-CREATION
> src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca
> src/examples/test_fetcher_plugin_module.cpp PRE-CREATION
> src/module/manager.cpp 9f88ec3addab59e4a40b0b40612518178d535aa5
> src/tests/module.hpp e661d95fa44fc1aedfe83c564c826d5b7d32c85b
> src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505
> src/uri/fetcher.hpp 8af2c9122e0b15fd54f7d3a84779540e7186f566
> src/uri/fetcher.cpp aa9df5d0256a26b8684934c2bd37b82a069088f7
>
>
> Diff: https://reviews.apache.org/r/42806/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Shuai Lin
>
>
Re: Review Request 42806: Added the fetcher plugin module interface.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42806/#review130248
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42806]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 23, 2016, 2:33 a.m., Shuai Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42806/
> -----------------------------------------------------------
>
> (Updated April 23, 2016, 2:33 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-3926
> https://issues.apache.org/jira/browse/MESOS-3926
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the fetcher plugin module interface.
>
>
> Diffs
> -----
>
> include/mesos/module/fetcher_plugin.hpp PRE-CREATION
> src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca
> src/examples/test_fetcher_plugin_module.cpp PRE-CREATION
> src/module/manager.cpp 9f88ec3addab59e4a40b0b40612518178d535aa5
> src/tests/module.hpp e661d95fa44fc1aedfe83c564c826d5b7d32c85b
> src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505
> src/uri/fetcher.hpp 8af2c9122e0b15fd54f7d3a84779540e7186f566
> src/uri/fetcher.cpp aa9df5d0256a26b8684934c2bd37b82a069088f7
>
> Diff: https://reviews.apache.org/r/42806/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Shuai Lin
>
>