You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Stanton Sievers <si...@gmail.com> on 2011/08/26 13:22:35 UTC
Re: Review Request: Common container gadget rendering does not support view
aliases
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1657/
-----------------------------------------------------------
(Updated 2011-08-26 11:22:35.474234)
Review request for shindig and Ryan Baxter.
Changes
-------
Adding the full dev list
Summary
-------
osapi.container.GadgetSite.prototype.render fails to render a gadget using a given view when that gadget does not explicitly define that view, even in the case where the container configuration has aliases for that view.
For instance, Gadget A supports the "profile" and "canvas" views only. The container configuration defines the "home" view and provides "profile" as an alias for "home". In the use case where the container tries to render Gadget A using the "home" view, gadget render will fail, even though the gadget supports "profile" and it has been specified as an alias for "home" in the container configuration.
This problem commonly manifests itself in Shindig because of the way "default" views are handled. By default, Shindig will attempt to render the gadget using the "default" view. If the gadget does not support that view, rendering will fail.
This addresses bug SHINDIG-1596.
https://issues.apache.org/jira/browse/SHINDIG-1596
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1160327
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1160327
Diff: https://reviews.apache.org/r/1657/diff
Testing
-------
Tested rendering a gadget in the "default" view case where the gadget doesn't support default.
Thanks,
Stanton
Re: Review Request: Common container gadget rendering does not support view
aliases
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1657/#review1680
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js
<https://reviews.apache.org/r/1657/#comment3833>
Could you refactor this code and the code below into one function since its the same?
- Ryan
On 2011-08-26 19:48:19, Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1657/
> -----------------------------------------------------------
>
> (Updated 2011-08-26 19:48:19)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Summary
> -------
>
> osapi.container.GadgetSite.prototype.render fails to render a gadget using a given view when that gadget does not explicitly define that view, even in the case where the container configuration has aliases for that view.
>
> For instance, Gadget A supports the "profile" and "canvas" views only. The container configuration defines the "home" view and provides "profile" as an alias for "home". In the use case where the container tries to render Gadget A using the "home" view, gadget render will fail, even though the gadget supports "profile" and it has been specified as an alias for "home" in the container configuration.
>
> This problem commonly manifests itself in Shindig because of the way "default" views are handled. By default, Shindig will attempt to render the gadget using the "default" view. If the gadget does not support that view, rendering will fail.
>
>
> This addresses bug SHINDIG-1596.
> https://issues.apache.org/jira/browse/SHINDIG-1596
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1160327
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1160327
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1160327
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java 1160327
>
> Diff: https://reviews.apache.org/r/1657/diff
>
>
> Testing
> -------
>
> Tested rendering a gadget in the "default" view case where the gadget doesn't support default.
>
>
> Thanks,
>
> Stanton
>
>
Re: Review Request: Common container gadget rendering does not support view
aliases
Posted by Ryan Baxter <rb...@gmail.com>.
> On 2011-08-30 22:09:50, Ryan Baxter wrote:
> > Committed revision 1163432. Please close the review and the JIRA.
Made a mistake the revision is 1163439.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1657/#review1697
-----------------------------------------------------------
On 2011-08-30 15:23:07, Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1657/
> -----------------------------------------------------------
>
> (Updated 2011-08-30 15:23:07)
>
>
> Review request for shindig, Ryan Baxter and Dan Dumont.
>
>
> Summary
> -------
>
> osapi.container.GadgetSite.prototype.render fails to render a gadget using a given view when that gadget does not explicitly define that view, even in the case where the container configuration has aliases for that view.
>
> For instance, Gadget A supports the "profile" and "canvas" views only. The container configuration defines the "home" view and provides "profile" as an alias for "home". In the use case where the container tries to render Gadget A using the "home" view, gadget render will fail, even though the gadget supports "profile" and it has been specified as an alias for "home" in the container configuration.
>
> This problem commonly manifests itself in Shindig because of the way "default" views are handled. By default, Shindig will attempt to render the gadget using the "default" view. If the gadget does not support that view, rendering will fail.
>
>
> This addresses bug SHINDIG-1596.
> https://issues.apache.org/jira/browse/SHINDIG-1596
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1160327
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1160327
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1160327
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java 1160327
>
> Diff: https://reviews.apache.org/r/1657/diff
>
>
> Testing
> -------
>
> Tested rendering a gadget in the "default" view case where the gadget doesn't support default.
>
>
> Thanks,
>
> Stanton
>
>
Re: Review Request: Common container gadget rendering does not support view
aliases
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1657/#review1697
-----------------------------------------------------------
Ship it!
Committed revision 1163432. Please close the review and the JIRA.
- Ryan
On 2011-08-30 15:23:07, Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1657/
> -----------------------------------------------------------
>
> (Updated 2011-08-30 15:23:07)
>
>
> Review request for shindig, Ryan Baxter and Dan Dumont.
>
>
> Summary
> -------
>
> osapi.container.GadgetSite.prototype.render fails to render a gadget using a given view when that gadget does not explicitly define that view, even in the case where the container configuration has aliases for that view.
>
> For instance, Gadget A supports the "profile" and "canvas" views only. The container configuration defines the "home" view and provides "profile" as an alias for "home". In the use case where the container tries to render Gadget A using the "home" view, gadget render will fail, even though the gadget supports "profile" and it has been specified as an alias for "home" in the container configuration.
>
> This problem commonly manifests itself in Shindig because of the way "default" views are handled. By default, Shindig will attempt to render the gadget using the "default" view. If the gadget does not support that view, rendering will fail.
>
>
> This addresses bug SHINDIG-1596.
> https://issues.apache.org/jira/browse/SHINDIG-1596
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1160327
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1160327
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1160327
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java 1160327
>
> Diff: https://reviews.apache.org/r/1657/diff
>
>
> Testing
> -------
>
> Tested rendering a gadget in the "default" view case where the gadget doesn't support default.
>
>
> Thanks,
>
> Stanton
>
>
Re: Review Request: Common container gadget rendering does not support view
aliases
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1657/#review1692
-----------------------------------------------------------
Ship it!
LGTM
- Dan
On 2011-08-30 15:23:07, Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1657/
> -----------------------------------------------------------
>
> (Updated 2011-08-30 15:23:07)
>
>
> Review request for shindig, Ryan Baxter and Dan Dumont.
>
>
> Summary
> -------
>
> osapi.container.GadgetSite.prototype.render fails to render a gadget using a given view when that gadget does not explicitly define that view, even in the case where the container configuration has aliases for that view.
>
> For instance, Gadget A supports the "profile" and "canvas" views only. The container configuration defines the "home" view and provides "profile" as an alias for "home". In the use case where the container tries to render Gadget A using the "home" view, gadget render will fail, even though the gadget supports "profile" and it has been specified as an alias for "home" in the container configuration.
>
> This problem commonly manifests itself in Shindig because of the way "default" views are handled. By default, Shindig will attempt to render the gadget using the "default" view. If the gadget does not support that view, rendering will fail.
>
>
> This addresses bug SHINDIG-1596.
> https://issues.apache.org/jira/browse/SHINDIG-1596
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1160327
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1160327
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1160327
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java 1160327
>
> Diff: https://reviews.apache.org/r/1657/diff
>
>
> Testing
> -------
>
> Tested rendering a gadget in the "default" view case where the gadget doesn't support default.
>
>
> Thanks,
>
> Stanton
>
>
Re: Review Request: Common container gadget rendering does not support view
aliases
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1657/
-----------------------------------------------------------
(Updated 2011-08-30 15:23:07.357636)
Review request for shindig, Ryan Baxter and Dan Dumont.
Summary
-------
osapi.container.GadgetSite.prototype.render fails to render a gadget using a given view when that gadget does not explicitly define that view, even in the case where the container configuration has aliases for that view.
For instance, Gadget A supports the "profile" and "canvas" views only. The container configuration defines the "home" view and provides "profile" as an alias for "home". In the use case where the container tries to render Gadget A using the "home" view, gadget render will fail, even though the gadget supports "profile" and it has been specified as an alias for "home" in the container configuration.
This problem commonly manifests itself in Shindig because of the way "default" views are handled. By default, Shindig will attempt to render the gadget using the "default" view. If the gadget does not support that view, rendering will fail.
This addresses bug SHINDIG-1596.
https://issues.apache.org/jira/browse/SHINDIG-1596
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1160327
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1160327
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1160327
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java 1160327
Diff: https://reviews.apache.org/r/1657/diff
Testing
-------
Tested rendering a gadget in the "default" view case where the gadget doesn't support default.
Thanks,
Stanton
Re: Review Request: Common container gadget rendering does not support view
aliases
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1657/
-----------------------------------------------------------
(Updated 2011-08-26 19:48:19.931881)
Review request for shindig and Ryan Baxter.
Changes
-------
Adding some better documentation and updated the workflow so that we also set the view to the alias we used. This is important so that the gadget holder's getView API returns the correct thing.
Summary
-------
osapi.container.GadgetSite.prototype.render fails to render a gadget using a given view when that gadget does not explicitly define that view, even in the case where the container configuration has aliases for that view.
For instance, Gadget A supports the "profile" and "canvas" views only. The container configuration defines the "home" view and provides "profile" as an alias for "home". In the use case where the container tries to render Gadget A using the "home" view, gadget render will fail, even though the gadget supports "profile" and it has been specified as an alias for "home" in the container configuration.
This problem commonly manifests itself in Shindig because of the way "default" views are handled. By default, Shindig will attempt to render the gadget using the "default" view. If the gadget does not support that view, rendering will fail.
This addresses bug SHINDIG-1596.
https://issues.apache.org/jira/browse/SHINDIG-1596
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1160327
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1160327
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1160327
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java 1160327
Diff: https://reviews.apache.org/r/1657/diff
Testing
-------
Tested rendering a gadget in the "default" view case where the gadget doesn't support default.
Thanks,
Stanton
Re: Review Request: Common container gadget rendering does not support view
aliases
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1657/#review1657
-----------------------------------------------------------
Ship it!
+1
- Henry
On 2011-08-26 11:22:35, Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1657/
> -----------------------------------------------------------
>
> (Updated 2011-08-26 11:22:35)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Summary
> -------
>
> osapi.container.GadgetSite.prototype.render fails to render a gadget using a given view when that gadget does not explicitly define that view, even in the case where the container configuration has aliases for that view.
>
> For instance, Gadget A supports the "profile" and "canvas" views only. The container configuration defines the "home" view and provides "profile" as an alias for "home". In the use case where the container tries to render Gadget A using the "home" view, gadget render will fail, even though the gadget supports "profile" and it has been specified as an alias for "home" in the container configuration.
>
> This problem commonly manifests itself in Shindig because of the way "default" views are handled. By default, Shindig will attempt to render the gadget using the "default" view. If the gadget does not support that view, rendering will fail.
>
>
> This addresses bug SHINDIG-1596.
> https://issues.apache.org/jira/browse/SHINDIG-1596
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1160327
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1160327
>
> Diff: https://reviews.apache.org/r/1657/diff
>
>
> Testing
> -------
>
> Tested rendering a gadget in the "default" view case where the gadget doesn't support default.
>
>
> Thanks,
>
> Stanton
>
>