You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2026/10/23 00:33:40 UTC
[PR] TPC-DS suite follow ups [beam]
Abacn opened a new pull request, #40741:
URL: https://github.com/apache/beam/pull/40741
* Some 10 MB test failed due to filtered dataset has no result, either intermediate or final query result, and may cause ZeroDivision, etc. Fixed dataset to add more items so they query result has non-zero row
* Fix known error to check whole error stack instead of the first line
* Fix log spam on Flink and Spark runners
* Enable query90,98
<!--
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
- [ ] Replace these instructions with a description of your change and why you have made it.
- [ ] Mention the appropriate issue in your description (for example: `addresses #123` or `fixes #456`).
- [ ] Update `CHANGES.md` with noteworthy changes.
See [CONTRIBUTING.md]() for more details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TPC-DS suite follow ups [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40741:
URL: https://github.com/apache/beam/pull/40741#issuecomment-6354900649
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/40741?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `8 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 79.92%. Comparing base ([`a8d6afd`](https://app.codecov.io/gh/apache/beam/commit/a8d6afdf5cbc8c4635732ad6dd8b702d16d869ec?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`13ae771`](https://app.codecov.io/gh/apache/beam/commit/13ae771e5ba9e4250df1e3f1a6628ec78ecccda7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 53 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/beam/pull/40741?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he\_beam/testing/benchmarks/tpcds/tpcds\_launcher.py](https://app.codecov.io/gh/apache/beam/pull/40741?src=pr&el=tree&filepath=sdks%2Fpython%2Fapache_beam%2Ftesting%2Fbenchmarks%2Ftpcds%2Ftpcds_launcher.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL3RwY2RzL3RwY2RzX2xhdW5jaGVyLnB5) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/beam/pull/40741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40741 +/- ##
==========================================
- Coverage 80.04% 79.92% -0.13%
==========================================
Files 490 493 +3
Lines 82916 83408 +492
==========================================
+ Hits 66373 66660 +287
- Misses 16543 16748 +205
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/40741/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/40741/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.92% <0.00%> (-0.13%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/beam/pull/40741?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TPC-DS suite follow ups [beam]
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #40741:
URL: https://github.com/apache/beam/pull/40741#issuecomment-6371002987
The local environment test is failing in a way I have seen before but I don't remember. I think it is printing the Java version then exiting, but not sure why it doesn't give a full error message. I've seen this across many PRs and I assume it is an environmental issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TPC-DS suite follow ups [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40741:
URL: https://github.com/apache/beam/pull/40741#issuecomment-6365918153
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TPC-DS suite follow ups [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #40741:
URL: https://github.com/apache/beam/pull/40741#issuecomment-6365905551
R: @kennknowles @aIbrahiim (bring newly added PostCommit green: https://github.com/apache/beam/actions/runs/39878843497/job/120171031464)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TPC-DS suite follow ups [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #40741:
URL: https://github.com/apache/beam/pull/40741#discussion_r4359985329
##########
sdks/python/apache_beam/testing/benchmarks/tpcds/tpcds_launcher.py:
##########
@@ -240,7 +240,7 @@ def run_single_query(
elapsed = time.monotonic() - t0
end_dt = datetime.datetime.now(datetime.timezone.utc)
err_str = str(exc)
- first_line = err_str.splitlines()[0] if err_str else repr(exc)
+ first_line = err_str.splitlines()[0]
Review Comment:
Overly defensive for test code. On error, error message shouldn't be empty. If it does, it's a observability bug and we should fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TPC-DS suite follow ups [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #40741:
URL: https://github.com/apache/beam/pull/40741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TPC-DS suite follow ups [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40741:
URL: https://github.com/apache/beam/pull/40741#issuecomment-6355164454
Assigning reviewers:
R: @chamikaramj for label java.
Backup reviewer: kennknowles (if the main reviewer is unresponsive, you can escalate to them by tagging their username)
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TPC-DS suite follow ups [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #40741:
URL: https://github.com/apache/beam/pull/40741#discussion_r4354968200
##########
sdks/python/apache_beam/testing/benchmarks/tpcds/tpcds_launcher.py:
##########
@@ -240,7 +240,7 @@ def run_single_query(
elapsed = time.monotonic() - t0
end_dt = datetime.datetime.now(datetime.timezone.utc)
err_str = str(exc)
- first_line = err_str.splitlines()[0] if err_str else repr(exc)
+ first_line = err_str.splitlines()[0]
Review Comment:
**🟡 Medium**: If `exc` has an empty string message (e.g., `RuntimeError()`), `err_str` will be `""` and `err_str.splitlines()` will return an empty list `[]`, causing `err_str.splitlines()[0]` to raise an `IndexError` inside the exception handler. Restoring the fallback guard prevents an unhandled crash during error reporting.
```suggestion
first_line = err_str.splitlines()[0] if err_str else repr(exc)
```
##########
sdks/python/apache_beam/testing/benchmarks/tpcds/tpcds_queries.py:
##########
@@ -34,22 +34,22 @@
"3", "7", "13", "15", "19", "26", "42", "43", "48", "52", "55", "91", "96"
]
-# The 55 TPC-DS queries supported by Beam Calcite SQL (returning > 0 rows).
-# Together with KNOWN_FAILING_QUERIES (48 queries), this partitions all 103 TPC-DS queries.
+# TPC-DS queries supported by Beam Calcite SQL (returning > 0 rows).
+# Together with KNOWN_FAILING_QUERIES, this partitions all 103 TPC-DS queries.
# yapf: disable
SUPPORTED_QUERIES: List[str] = [
"1", "3", "4", "7", "9", "10", "11", "12", "15", "17",
"19", "20", "21", "26", "31", "32", "33", "34", "35", "38",
"40", "42", "43", "45", "46", "49", "50", "52", "53", "55",
"56", "59", "60", "61", "63", "65", "66", "68", "69", "71",
"73", "74", "75", "76", "79", "82", "84", "87", "88", "89",
- "92", "93", "96", "97", "99",
+ "90", "92", "93", "96", "97", "98", "99",
]
# yapf: enable
-# The 48 known failing TPC-DS queries on Beam Calcite SQL with their expected error substring.
+# Known failing TPC-DS queries on Beam Calcite SQL with their expected error substring.
# Used by `--check_regression` and `:sdks:python:apache_beam:testing:benchmarks:tpcds:checkAllQueries`
-# to verify that all 55 SUPPORTED_QUERIES succeed on PrismRunner and that the remaining 48 known
+# to verify that all SUPPORTED_QUERIES succeed on PrismRunner and that the remaining 48 known
Review Comment:
**🟢 Low**: Nit: Since the hardcoded counts were removed from the surrounding comments so they don't go stale as queries are enabled (and `KNOWN_FAILING_QUERIES` now has 46 entries rather than 48), consider removing `48` here as well.
```suggestion
# to verify that all SUPPORTED_QUERIES succeed on PrismRunner and that the remaining known
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org