You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by iilyak <gi...@git.apache.org> on 2015/01/19 18:23:18 UTC
[GitHub] couchdb-couch-mrview pull request: Fix typo in metrics definition
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-couch-mrview/pull/14
Fix typo in metrics definition
We call increment_counter with map_docs.
Change definition in stats_description.cfg to match.
COUCHDB-2552
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iilyak/couchdb-couch-mrview 2552-unknown-metric-mrview-map_docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-mrview/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit 29780bffd46e5accc3b5977fecd21c8e52429d20
Author: ILYA Khlopotov <ii...@ca.ibm.com>
Date: 2015-01-19T17:18:22Z
Fix typo in metrics definition
We call increment_counter with map_docs.
Change definition in stats_description.cfg to match.
COUCHDB-2552
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview pull request: Fix typo in metrics definition
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/14#issuecomment-70530802
The name is related to query server command which it counts, so they need to be in sync.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview pull request: Fix typo in metrics definition
Posted by iilyak <gi...@git.apache.org>.
Github user iilyak closed the pull request at:
https://github.com/apache/couchdb-couch-mrview/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview pull request: Fix typo in metrics definition
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/14#issuecomment-70530606
Oh, that is my fault.
Originally this metric was defined in couchdb-couch and here is the commit the moved it to mrview:
https://github.com/apache/couchdb-couch/commit/c6c3c1eec396574b792b4e86b96f48816a0fc0ee
and here is how it was used:
https://github.com/apache/couchdb-couch/commit/40c5c85d3bf60c73f28389394058ec1f27207335
So actually, there is need to rename map_docs to map_doc in order of great justice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview pull request: Fix typo in metrics definition
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/14#issuecomment-86240632
The real typo wasn't in stats definition, but in code. Fixed in https://github.com/apache/couchdb-couch-mrview/commit/5c10340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview pull request: Fix typo in metrics definition
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/14#issuecomment-85285422
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---