[GitHub] [incubator-pekko] jrudolph commented on a diff in pull request #273: upgrade to jackson 2.14.2

["jrudolph (via GitHub)" <gi...@apache.org>]

jrudolph commented on code in PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273#discussion_r1157006693


##########
project/PekkoDisciplinePlugin.scala:
##########
@@ -134,7 +136,7 @@ object PekkoDisciplinePlugin extends AutoPlugin {
           case Some((2, 12)) =>
             disciplineScalacOptions
           case _ =>
-            Nil
+            Seq("-Wconf:cat=deprecation:s")

Review Comment:
   Does that mean we disable all deprecation warnings for Scala 3 for all submodules. Is that really what we want?
   
   You can also match by other factors, so maybe we can restrict the silencing to Jackson in particular?



##########
actor-typed-tests/src/test/scala/docs/org/apache/pekko/typed/InteractionPatternsSpec.scala:
##########
@@ -33,6 +33,14 @@ import pekko.actor.typed.scaladsl.TimerScheduler
 import pekko.pattern.StatusReply
 import org.scalatest.wordspec.AnyWordSpecLike
 
+// #per-session-child
+// dummy data types just for this sample
+case class Keys()
+

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org