You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/10 11:58:37 UTC
[GitHub] [kafka] jlprat opened a new pull request #10662: KAFKA-12747: Fix flaky test RocksDBStoreTest.shouldReturnUUIDsWithStr…
jlprat opened a new pull request #10662:
URL: https://github.com/apache/kafka/pull/10662
…ingPrefix
Fixes the test by checking if there is a prefix collision.
Following comment on [JIRA ticket](https://issues.apache.org/jira/browse/KAFKA-12747?focusedCommentId=17338612&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17338612), in case of prefix clash, we check that the returned value can be either of both (a or b).
Alternatively, we could re-generate the second UUID in case of prefix
clash until they are clash-free.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10662: KAFKA-12747: Fix flaky test RocksDBStoreTest.shouldReturnUUIDsWithStr…
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10662:
URL: https://github.com/apache/kafka/pull/10662#issuecomment-836981716
The other way around, I haven't seen your PR, you were first 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat closed pull request #10662: KAFKA-12747: Fix flaky test RocksDBStoreTest.shouldReturnUUIDsWithStr…
Posted by GitBox <gi...@apache.org>.
jlprat closed pull request #10662:
URL: https://github.com/apache/kafka/pull/10662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #10662: KAFKA-12747: Fix flaky test RocksDBStoreTest.shouldReturnUUIDsWithStr…
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #10662:
URL: https://github.com/apache/kafka/pull/10662#issuecomment-836978921
Hey @jlprat sorry I was not aware you're also working on this ticket..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10662: KAFKA-12747: Fix flaky test RocksDBStoreTest.shouldReturnUUIDsWithStr…
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10662:
URL: https://github.com/apache/kafka/pull/10662#issuecomment-836630173
Now I see another PR was already there: https://github.com/apache/kafka/pull/10643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org