You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2016/12/10 01:19:30 UTC
Re: Review Request 52071: Updated docs to handle resources with no
size in agent flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52071/
-----------------------------------------------------------
(Updated Dec. 10, 2016, 1:19 a.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Updated docs to clarify auto detection done for json representation only.
Bugs: MESOS-6062
https://issues.apache.org/jira/browse/MESOS-6062
Repository: mesos
Description (updated)
-------
When a resource with no size is specified in `--resources` startup
flag of mesos agent, the size is auto detected by the agent. This
is enabled for all known resource types (except gpus) only when
the resources are specified in JSON format.
For disk resources, this is done for both root disks as well as
MOUNT and PATH disks.
Diffs (updated)
-----
docs/attributes-resources.md 2caa44927d45c0ab13f8160794b50f4fde3711aa
Diff: https://reviews.apache.org/r/52071/diff/
Testing
-------
Documentation change only. All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 52071: Updated docs to handle resources with no
size in agent flags.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52071/#review158774
-----------------------------------------------------------
Patch looks great!
Reviews applied: [51999, 52002, 51879, 51880, 52071]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 10, 2016, 1:19 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52071/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2016, 1:19 a.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-6062
> https://issues.apache.org/jira/browse/MESOS-6062
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When a resource with no size is specified in `--resources` startup
> flag of mesos agent, the size is auto detected by the agent. This
> is enabled for all known resource types (except gpus) only when
> the resources are specified in JSON format.
> For disk resources, this is done for both root disks as well as
> MOUNT and PATH disks.
>
>
> Diffs
> -----
>
> docs/attributes-resources.md 2caa44927d45c0ab13f8160794b50f4fde3711aa
>
> Diff: https://reviews.apache.org/r/52071/diff/
>
>
> Testing
> -------
>
> Documentation change only. All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 52071: Updated docs to handle resources with no
size in agent flags.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52071/
-----------------------------------------------------------
(Updated June 1, 2017, 7:16 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-6062
https://issues.apache.org/jira/browse/MESOS-6062
Repository: mesos
Description
-------
When a resource with no size is specified in `--resources` startup
flag of mesos agent, the size is auto detected by the agent. This
is enabled for all known resource types (except gpus) only when
the resources are specified in JSON format.
For disk resources, this is done for both root disks as well as
MOUNT and PATH disks.
Diffs (updated)
-----
docs/attributes-resources.md 2caa44927d45c0ab13f8160794b50f4fde3711aa
Diff: https://reviews.apache.org/r/52071/diff/13/
Changes: https://reviews.apache.org/r/52071/diff/12-13/
Testing
-------
Documentation change only. All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 52071: Updated docs to handle resources with no
size in agent flags.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52071/
-----------------------------------------------------------
(Updated May 24, 2017, 7:56 p.m.)
Review request for mesos and Jiang Yan Xu.
Bugs: MESOS-6062
https://issues.apache.org/jira/browse/MESOS-6062
Repository: mesos
Description
-------
When a resource with no size is specified in `--resources` startup
flag of mesos agent, the size is auto detected by the agent. This
is enabled for all known resource types (except gpus) only when
the resources are specified in JSON format.
For disk resources, this is done for both root disks as well as
MOUNT and PATH disks.
Diffs (updated)
-----
docs/attributes-resources.md 2caa44927d45c0ab13f8160794b50f4fde3711aa
Diff: https://reviews.apache.org/r/52071/diff/12/
Changes: https://reviews.apache.org/r/52071/diff/11-12/
Testing
-------
Documentation change only. All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 52071: Updated docs to handle resources with no
size in agent flags.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52071/#review167533
-----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews.
- Joris Van Remoortere
On Dec. 20, 2016, 2:05 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52071/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2016, 2:05 a.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-6062
> https://issues.apache.org/jira/browse/MESOS-6062
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When a resource with no size is specified in `--resources` startup
> flag of mesos agent, the size is auto detected by the agent. This
> is enabled for all known resource types (except gpus) only when
> the resources are specified in JSON format.
> For disk resources, this is done for both root disks as well as
> MOUNT and PATH disks.
>
>
> Diffs
> -----
>
> docs/attributes-resources.md 2caa44927d45c0ab13f8160794b50f4fde3711aa
>
>
> Diff: https://reviews.apache.org/r/52071/diff/11/
>
>
> Testing
> -------
>
> Documentation change only. All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 52071: Updated docs to handle resources with no
size in agent flags.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52071/#review159717
-----------------------------------------------------------
Patch looks great!
Reviews applied: [51999, 52002, 51879, 51880, 52071]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 20, 2016, 2:05 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52071/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2016, 2:05 a.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-6062
> https://issues.apache.org/jira/browse/MESOS-6062
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When a resource with no size is specified in `--resources` startup
> flag of mesos agent, the size is auto detected by the agent. This
> is enabled for all known resource types (except gpus) only when
> the resources are specified in JSON format.
> For disk resources, this is done for both root disks as well as
> MOUNT and PATH disks.
>
>
> Diffs
> -----
>
> docs/attributes-resources.md 2caa44927d45c0ab13f8160794b50f4fde3711aa
>
> Diff: https://reviews.apache.org/r/52071/diff/
>
>
> Testing
> -------
>
> Documentation change only. All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 52071: Updated docs to handle resources with no
size in agent flags.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52071/
-----------------------------------------------------------
(Updated Dec. 20, 2016, 2:05 a.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-6062
https://issues.apache.org/jira/browse/MESOS-6062
Repository: mesos
Description
-------
When a resource with no size is specified in `--resources` startup
flag of mesos agent, the size is auto detected by the agent. This
is enabled for all known resource types (except gpus) only when
the resources are specified in JSON format.
For disk resources, this is done for both root disks as well as
MOUNT and PATH disks.
Diffs (updated)
-----
docs/attributes-resources.md 2caa44927d45c0ab13f8160794b50f4fde3711aa
Diff: https://reviews.apache.org/r/52071/diff/
Testing
-------
Documentation change only. All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 52071: Updated docs to handle resources with no
size in agent flags.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52071/
-----------------------------------------------------------
(Updated Dec. 18, 2016, 8:38 a.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-6062
https://issues.apache.org/jira/browse/MESOS-6062
Repository: mesos
Description
-------
When a resource with no size is specified in `--resources` startup
flag of mesos agent, the size is auto detected by the agent. This
is enabled for all known resource types (except gpus) only when
the resources are specified in JSON format.
For disk resources, this is done for both root disks as well as
MOUNT and PATH disks.
Diffs (updated)
-----
docs/attributes-resources.md 2caa44927d45c0ab13f8160794b50f4fde3711aa
Diff: https://reviews.apache.org/r/52071/diff/
Testing
-------
Documentation change only. All tests passed.
Thanks,
Anindya Sinha