svn commit: rev 54716 - in spamassassin/trunk: . t

[jm...@apache.org]

Author: jm
Date: Tue Oct 12 17:44:57 2004
New Revision: 54716

Added:
   spamassassin/trunk/t/memory_cycles.t   (contents, props changed)
Modified:
   spamassassin/trunk/MANIFEST
Log:
add test to detect circular references in the modules, using Devel::Cycle

Modified: spamassassin/trunk/MANIFEST
==============================================================================
--- spamassassin/trunk/MANIFEST	(original)
+++ spamassassin/trunk/MANIFEST	Tue Oct 12 17:44:57 2004
@@ -297,6 +297,7 @@
 t/ifversion.t
 t/ip_addrs.t
 t/lang_pl_tests.t
+t/memory_cycles.t
 t/mimeparse.t
 t/nonspam.t
 t/plugin.t

Added: spamassassin/trunk/t/memory_cycles.t
==============================================================================
--- (empty file)
+++ spamassassin/trunk/t/memory_cycles.t	Tue Oct 12 17:44:57 2004
@@ -0,0 +1,86 @@
+#!/usr/bin/perl
+
+use constant HAVE_DEVEL_CYCLE => eval { require Devel::Cycle; };
+
+BEGIN {
+  if (-e 't/test_dir') { # if we are running "t/rule_tests.t", kluge around ...
+    chdir 't';
+  }
+
+  if (-e 'test_dir') {            # running from test directory, not ..
+    unshift(@INC, '../blib/lib');
+  }
+}
+
+my $prefix = '.';
+if (-e 'test_dir') {            # running from test directory, not ..
+  $prefix = '..';
+}
+
+use lib '.'; use lib 't';
+use SATest; sa_t_init("memory_cycles");
+
+use Test; BEGIN {
+  plan tests => (HAVE_DEVEL_CYCLE ? 3 : 0);
+}
+unless (HAVE_DEVEL_CYCLE) {
+  print "# Devel::Cycle module required for this test, skipped\n";
+  exit 0;
+}
+
+use strict;
+use Mail::SpamAssassin;
+
+# ---------------------------------------------------------------------------
+
+my $spamtest = Mail::SpamAssassin->new({
+    rules_filename => "$prefix/t/log/test_rules_copy",
+    site_rules_filename => "$prefix/t/log/test_default.cf",
+    userprefs_filename  => "$prefix/masses/spamassassin/user_prefs",
+    local_tests_only    => 1,
+    debug             => 0,
+    dont_copy_prefs   => 1,
+});
+
+$spamtest->init(0); # parse rules
+ok($spamtest);
+
+open (IN, "<data/spam/009");
+my $dataref = [<IN>];
+close IN;
+my $mail   = $spamtest->parse($dataref);
+my $status = $spamtest->check($mail);
+my $output = $status->get_report();
+
+$status->finish();
+ok (check_for_cycles($status));
+
+$spamtest->finish();
+ok (check_for_cycles($spamtest));
+exit;
+
+############################################################################
+# Test::Memory::Cycle would be a nice way to do this -- but it relies
+# on Test::More.  so just do it ourselves.
+
+use Devel::Cycle;
+our $cycles;
+
+sub check_for_cycles {
+  my $obj = shift;
+  $cycles = 0;
+  find_cycle ($obj, \&cyclecb);
+  if ($cycles) {
+    print "found $cycles cycles! dump to follow:\n";
+    find_cycle ($obj);  # with default output-to-stdout callback
+    return 0;
+  } else {
+    return 1;
+  }
+}
+
+sub cyclecb {
+  my $aryref = shift;
+  $cycles += scalar @{$aryref};
+}
+

Re: svn commit: rev 54716 - in spamassassin/trunk: . t

[Sidney Markowitz <si...@sidney.com>]

> Added: spamassassin/trunk/t/memory_cycles.t

I just noticed this now while trying to make test on a machine that 
doesn't have Devel::Cycle. Is that going to be a documented requirement now?

  -- sidney