You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Julian Hyde <jh...@apache.org> on 2018/12/06 08:18:59 UTC
[VOTE] Release apache-calcite-1.18.0 (release candidate 1)
OK, let's try again.
I have created a build for Apache Calcite 1.18.0, release candidate 1.
Thanks to everyone who has contributed to this release.
Since RC 0, we have fixed the following issues:
* [CALCITE-2726] ReduceExpressionRule oversimplifies filter conditions
containing nulls
* [CALCITE-2670] Combine similar JSON aggregate functions in operator table
* [CALCITE-2468] Validator throws IndexOutOfBoundsException when
trying to infer operand type from STRUCT return type (Rong Rong)
You can read the release notes here:
https://github.com/apache/calcite/blob/branch-1.18/site/_docs/history.md
The commit to be voted upon:
http://git-wip-us.apache.org/repos/asf/calcite/commit/06d0526e9e58b88bb6722ae3e66789b9e60a70d1
Its hash is 06d0526e9e58b88bb6722ae3e66789b9e60a70d1.
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.18.0-rc1
The hashes of the artifacts are as follows:
src.tar.gz.sha256
88501d9c22c5cd28c2988a1f921fa112386ac819fb1dbcc5f68504b30b8d7dd7
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1050
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/jhyde.asc
Please vote on releasing this package as Apache Calcite 1.18.0.
The vote is open for the next 108 hours (ending at 1pm Pacific on Mon 10th)
and passes if a majority of at least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Calcite 1.18.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Here is my vote:
+1 (binding)
Julian
Re: [VOTE] Release apache-calcite-1.18.0 (release candidate 1)
Posted by Stamatis Zampetakis <za...@gmail.com>.
+1 (non binding)
System: Ubuntu 18.04 LTS and jdk1.8.0.66
-run mvn clean install on staged sources and git repo
-checked signatures and checksums
-went quickly over release note
Everything looks good! I have only a small question: should the release
note mention new dependencies (e.g., com.jayway.jsonpath)?
-run tests on downstream project
Still many failures mostly due to the following bugs:
* [CALCITE-2464] Struct types are always not nullable [1]
* [CALCITE-2677] Struct types with one field are not mapped correctly to
Java Classes [2]
These are not regressions so my +1 vote remains.
Best,
Stamatis
[1] https://issues.apache.org/jira/browse/CALCITE-2464
[2] https://issues.apache.org/jira/browse/CALCITE-2677
Στις Πέμ, 6 Δεκ 2018 στις 9:19 π.μ., ο/η Julian Hyde <jh...@apache.org>
έγραψε:
> OK, let's try again.
>
> I have created a build for Apache Calcite 1.18.0, release candidate 1.
>
> Thanks to everyone who has contributed to this release.
> Since RC 0, we have fixed the following issues:
>
> * [CALCITE-2726] ReduceExpressionRule oversimplifies filter conditions
> containing nulls
> * [CALCITE-2670] Combine similar JSON aggregate functions in operator table
> * [CALCITE-2468] Validator throws IndexOutOfBoundsException when
> trying to infer operand type from STRUCT return type (Rong Rong)
>
> You can read the release notes here:
> https://github.com/apache/calcite/blob/branch-1.18/site/_docs/history.md
>
> The commit to be voted upon:
>
> http://git-wip-us.apache.org/repos/asf/calcite/commit/06d0526e9e58b88bb6722ae3e66789b9e60a70d1
>
> Its hash is 06d0526e9e58b88bb6722ae3e66789b9e60a70d1.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.18.0-rc1
>
> The hashes of the artifacts are as follows:
> src.tar.gz.sha256
> 88501d9c22c5cd28c2988a1f921fa112386ac819fb1dbcc5f68504b30b8d7dd7
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1050
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jhyde.asc
>
> Please vote on releasing this package as Apache Calcite 1.18.0.
>
> The vote is open for the next 108 hours (ending at 1pm Pacific on Mon 10th)
> and passes if a majority of at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.18.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Julian
>
[CANCEL] [VOTE] Release apache-calcite-1.18.0 (release candidate 1)
Posted by Julian Hyde <jh...@apache.org>.
Canceling vote due to https://issues.apache.org/jira/browse/CALCITE-2731 <https://issues.apache.org/jira/browse/CALCITE-2731>.
Let's fix that and https://issues.apache.org/jira/browse/CALCITE-2730 <https://issues.apache.org/jira/browse/CALCITE-2730> before RC2.
Julian
> On Dec 7, 2018, at 10:17 AM, Julian Hyde <jh...@apache.org> wrote:
>
> OK, this is another showstopper. When you have a fix for
> https://issues.apache.org/jira/browse/CALCITE-2731, can you please run
> the full Hive test suite on the snapshot before we roll the next RC.
> On Fri, Dec 7, 2018 at 8:44 AM Zoltan Haindrich <ki...@rxd.hu> wrote:
>>
>> Hello,
>>
>> I've run the Hive tests and I've found something which might cause problems: in CALCITE-1413 we were extra cautious to not simplify cases like:
>> CASE a=0 THEN 0 ELSE 1/a END
>> and it worked correctly; however: RexProgramBuilder is also executes simplify - but the protection at that point is completely helpless:
>> CASE $1 THEN $2 ELSE $3 END
>> I've opened CALCITE-2731
>> Beyond this there are some new "redundant" IS TRUE checks and some extra casts which are probably appeared because of CALCITE-2726.
>>
>> I was more thorough this time; so I don't think I'll be uncovering any more issues.
>>
>> Zoltan
>>
>> On 12/6/18 9:18 AM, Julian Hyde wrote:
>>> OK, let's try again.
>>>
>>> I have created a build for Apache Calcite 1.18.0, release candidate 1.
>>>
>>> Thanks to everyone who has contributed to this release.
>>> Since RC 0, we have fixed the following issues:
>>>
>>> * [CALCITE-2726] ReduceExpressionRule oversimplifies filter conditions
>>> containing nulls
>>> * [CALCITE-2670] Combine similar JSON aggregate functions in operator table
>>> * [CALCITE-2468] Validator throws IndexOutOfBoundsException when
>>> trying to infer operand type from STRUCT return type (Rong Rong)
>>>
>>> You can read the release notes here:
>>> https://github.com/apache/calcite/blob/branch-1.18/site/_docs/history.md
>>>
>>> The commit to be voted upon:
>>> http://git-wip-us.apache.org/repos/asf/calcite/commit/06d0526e9e58b88bb6722ae3e66789b9e60a70d1
>>>
>>> Its hash is 06d0526e9e58b88bb6722ae3e66789b9e60a70d1.
>>>
>>> The artifacts to be voted on are located here:
>>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.18.0-rc1
>>>
>>> The hashes of the artifacts are as follows:
>>> src.tar.gz.sha256
>>> 88501d9c22c5cd28c2988a1f921fa112386ac819fb1dbcc5f68504b30b8d7dd7
>>>
>>> A staged Maven repository is available for review at:
>>> https://repository.apache.org/content/repositories/orgapachecalcite-1050
>>>
>>> Release artifacts are signed with the following key:
>>> https://people.apache.org/keys/committer/jhyde.asc
>>>
>>> Please vote on releasing this package as Apache Calcite 1.18.0.
>>>
>>> The vote is open for the next 108 hours (ending at 1pm Pacific on Mon 10th)
>>> and passes if a majority of at least three +1 PMC votes are cast.
>>>
>>> [ ] +1 Release this package as Apache Calcite 1.18.0
>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>>> [ ] -1 Do not release this package because...
>>>
>>>
>>> Here is my vote:
>>>
>>> +1 (binding)
>>>
>>> Julian
>>>
Re: [VOTE] Release apache-calcite-1.18.0 (release candidate 1)
Posted by Julian Hyde <jh...@apache.org>.
OK, this is another showstopper. When you have a fix for
https://issues.apache.org/jira/browse/CALCITE-2731, can you please run
the full Hive test suite on the snapshot before we roll the next RC.
On Fri, Dec 7, 2018 at 8:44 AM Zoltan Haindrich <ki...@rxd.hu> wrote:
>
> Hello,
>
> I've run the Hive tests and I've found something which might cause problems: in CALCITE-1413 we were extra cautious to not simplify cases like:
> CASE a=0 THEN 0 ELSE 1/a END
> and it worked correctly; however: RexProgramBuilder is also executes simplify - but the protection at that point is completely helpless:
> CASE $1 THEN $2 ELSE $3 END
> I've opened CALCITE-2731
> Beyond this there are some new "redundant" IS TRUE checks and some extra casts which are probably appeared because of CALCITE-2726.
>
> I was more thorough this time; so I don't think I'll be uncovering any more issues.
>
> Zoltan
>
> On 12/6/18 9:18 AM, Julian Hyde wrote:
> > OK, let's try again.
> >
> > I have created a build for Apache Calcite 1.18.0, release candidate 1.
> >
> > Thanks to everyone who has contributed to this release.
> > Since RC 0, we have fixed the following issues:
> >
> > * [CALCITE-2726] ReduceExpressionRule oversimplifies filter conditions
> > containing nulls
> > * [CALCITE-2670] Combine similar JSON aggregate functions in operator table
> > * [CALCITE-2468] Validator throws IndexOutOfBoundsException when
> > trying to infer operand type from STRUCT return type (Rong Rong)
> >
> > You can read the release notes here:
> > https://github.com/apache/calcite/blob/branch-1.18/site/_docs/history.md
> >
> > The commit to be voted upon:
> > http://git-wip-us.apache.org/repos/asf/calcite/commit/06d0526e9e58b88bb6722ae3e66789b9e60a70d1
> >
> > Its hash is 06d0526e9e58b88bb6722ae3e66789b9e60a70d1.
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.18.0-rc1
> >
> > The hashes of the artifacts are as follows:
> > src.tar.gz.sha256
> > 88501d9c22c5cd28c2988a1f921fa112386ac819fb1dbcc5f68504b30b8d7dd7
> >
> > A staged Maven repository is available for review at:
> > https://repository.apache.org/content/repositories/orgapachecalcite-1050
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/jhyde.asc
> >
> > Please vote on releasing this package as Apache Calcite 1.18.0.
> >
> > The vote is open for the next 108 hours (ending at 1pm Pacific on Mon 10th)
> > and passes if a majority of at least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.18.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Julian
> >
Re: [VOTE] Release apache-calcite-1.18.0 (release candidate 1)
Posted by Zoltan Haindrich <ki...@rxd.hu>.
Hello,
I've run the Hive tests and I've found something which might cause problems: in CALCITE-1413 we were extra cautious to not simplify cases like:
CASE a=0 THEN 0 ELSE 1/a END
and it worked correctly; however: RexProgramBuilder is also executes simplify - but the protection at that point is completely helpless:
CASE $1 THEN $2 ELSE $3 END
I've opened CALCITE-2731
Beyond this there are some new "redundant" IS TRUE checks and some extra casts which are probably appeared because of CALCITE-2726.
I was more thorough this time; so I don't think I'll be uncovering any more issues.
Zoltan
On 12/6/18 9:18 AM, Julian Hyde wrote:
> OK, let's try again.
>
> I have created a build for Apache Calcite 1.18.0, release candidate 1.
>
> Thanks to everyone who has contributed to this release.
> Since RC 0, we have fixed the following issues:
>
> * [CALCITE-2726] ReduceExpressionRule oversimplifies filter conditions
> containing nulls
> * [CALCITE-2670] Combine similar JSON aggregate functions in operator table
> * [CALCITE-2468] Validator throws IndexOutOfBoundsException when
> trying to infer operand type from STRUCT return type (Rong Rong)
>
> You can read the release notes here:
> https://github.com/apache/calcite/blob/branch-1.18/site/_docs/history.md
>
> The commit to be voted upon:
> http://git-wip-us.apache.org/repos/asf/calcite/commit/06d0526e9e58b88bb6722ae3e66789b9e60a70d1
>
> Its hash is 06d0526e9e58b88bb6722ae3e66789b9e60a70d1.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.18.0-rc1
>
> The hashes of the artifacts are as follows:
> src.tar.gz.sha256
> 88501d9c22c5cd28c2988a1f921fa112386ac819fb1dbcc5f68504b30b8d7dd7
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1050
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jhyde.asc
>
> Please vote on releasing this package as Apache Calcite 1.18.0.
>
> The vote is open for the next 108 hours (ending at 1pm Pacific on Mon 10th)
> and passes if a majority of at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.18.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Julian
>
Re: [VOTE] Release apache-calcite-1.18.0 (release candidate 1)
Posted by Michael Mior <mm...@apache.org>.
+1 (binding) checked hashes and signature and compiled and ran tests.
Thanks for the fixes!
--
Michael Mior
mmior@apache.org
Le jeu. 6 déc. 2018 à 03:19, Julian Hyde <jh...@apache.org> a écrit :
> OK, let's try again.
>
> I have created a build for Apache Calcite 1.18.0, release candidate 1.
>
> Thanks to everyone who has contributed to this release.
> Since RC 0, we have fixed the following issues:
>
> * [CALCITE-2726] ReduceExpressionRule oversimplifies filter conditions
> containing nulls
> * [CALCITE-2670] Combine similar JSON aggregate functions in operator table
> * [CALCITE-2468] Validator throws IndexOutOfBoundsException when
> trying to infer operand type from STRUCT return type (Rong Rong)
>
> You can read the release notes here:
> https://github.com/apache/calcite/blob/branch-1.18/site/_docs/history.md
>
> The commit to be voted upon:
>
> http://git-wip-us.apache.org/repos/asf/calcite/commit/06d0526e9e58b88bb6722ae3e66789b9e60a70d1
>
> Its hash is 06d0526e9e58b88bb6722ae3e66789b9e60a70d1.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.18.0-rc1
>
> The hashes of the artifacts are as follows:
> src.tar.gz.sha256
> 88501d9c22c5cd28c2988a1f921fa112386ac819fb1dbcc5f68504b30b8d7dd7
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1050
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jhyde.asc
>
> Please vote on releasing this package as Apache Calcite 1.18.0.
>
> The vote is open for the next 108 hours (ending at 1pm Pacific on Mon 10th)
> and passes if a majority of at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.18.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Julian
>
Re: [VOTE] Release apache-calcite-1.18.0 (release candidate 1)
Posted by Kevin Risden <kr...@apache.org>.
+1 (binding) checked sig and hashes, compiled and ran tests from git commit
and tar.gz.
Francis -
[ERROR] Failures:
[ERROR] OsAdapterTest.testFiles:146
Expected: "type=d\ntype=f"
but: was ""
I'm pretty sure this happens when Alpine linux doesn't have the same OS
command output as "regular" Linux.
Kevin Risden
On Fri, Dec 7, 2018 at 3:38 AM Enrico Olivelli <eo...@gmail.com> wrote:
> +1 (non binding)
> - checked signature and checksum
> - built from source, all tests pass on OracleJDK8 on Linux
> - all tests from downstream project (HerdDB) are passing
>
> Still great work !
> Thank you Julian for driving the release
>
> Enrico
>
>
> Il giorno ven 7 dic 2018 alle ore 02:44 Francis Chuang
> <fr...@apache.org> ha scritto:
> >
> > Thanks for making this available for voting, Julian!
> >
> > +1 (binding)
> >
> > Environment: Debian Sid, OpenJDK 11.0.1, maven 3.6.0 in a docker
> container
> > - Verified GPG signature - OK
> > - Verified SHA256 - OK
> > - Ran "mvn -DskipTests clean install" - OK
> > - Ran "mvn test" - OK
> >
> > I also tested using Alpine Linux:
> > Environment: Alpine Linux 3.8, OpenJDK 8u181, maven 3.6.0 in a docker
> > container
> >
> > - Verified GPG signature - OK
> > - Verified SHA256 - OK
> > - Ran "mvn -DskipTests clean install" - OK
> > - Ran "mvn test" - FAILED
> >
> > The tests failed, but since OpenJDK 8 is not supported, this isn't an
> issue:
> >
> > [ERROR] Failures:
> > [ERROR] OsAdapterTest.testFiles:146
> > Expected: "type=d\ntype=f"
> > but: was ""
> > [INFO]
> > [ERROR] Tests run: 59, Failures: 1, Errors: 0, Skipped: 23
> > [INFO]
> > [INFO]
> > ------------------------------------------------------------------------
> > [INFO] Reactor Summary for Calcite 1.18.0:
> > [INFO]
> > [INFO] Calcite ............................................ SUCCESS [
> > 4.064 s]
> > [INFO] Calcite Linq4j ..................................... SUCCESS [
> > 10.991 s]
> > [INFO] Calcite Core ....................................... SUCCESS
> > [09:26 min]
> > [INFO] Calcite Babel ...................................... SUCCESS [
> > 6.333 s]
> > [INFO] Calcite Cassandra .................................. SUCCESS
> > [01:56 min]
> > [INFO] Calcite Druid ...................................... SUCCESS [
> > 5.862 s]
> > [INFO] Calcite Elasticsearch .............................. SUCCESS
> > [01:10 min]
> > [INFO] Calcite Examples ................................... SUCCESS [
> > 0.200 s]
> > [INFO] Calcite Example CSV ................................ SUCCESS [
> > 10.818 s]
> > [INFO] Calcite Example Function ........................... SUCCESS [
> > 5.801 s]
> > [INFO] Calcite File ....................................... SUCCESS [
> > 13.449 s]
> > [INFO] Calcite Geode ...................................... SUCCESS [
> > 18.890 s]
> > [INFO] Calcite MongoDB .................................... SUCCESS [
> > 19.340 s]
> > [INFO] Calcite Pig ........................................ SUCCESS [
> > 15.797 s]
> > [INFO] Calcite Piglet ..................................... SUCCESS [
> > 7.510 s]
> > [INFO] Calcite Plus ....................................... FAILURE [
> > 15.401 s]
> > [INFO] Calcite Server ..................................... SKIPPED
> > [INFO] Calcite Spark ...................................... SKIPPED
> > [INFO] Calcite Splunk ..................................... SKIPPED
> > [INFO] Calcite Ubenchmark ................................. SKIPPED
> > [INFO]
> > ------------------------------------------------------------------------
> > [INFO] BUILD FAILURE
> > [INFO]
> > ------------------------------------------------------------------------
> > [INFO] Total time: 14:47 min
> > [INFO] Finished at: 2018-12-06T23:14:07Z
> > [INFO]
> > ------------------------------------------------------------------------
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test
> > (default-test) on project calcite-plus: There are test failures.
> > [ERROR]
> > [ERROR] Please refer to
> > /apache-calcite-1.18.0-src/plus/target/surefire-reports for the
> > individual test results.
> > [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> > [date].dumpstream and [date]-jvmRun[N].dumpstream.
> > [ERROR] -> [Help 1]
> >
> > Francis
> >
> > On 6/12/2018 7:18 pm, Julian Hyde wrote:
> > > OK, let's try again.
> > >
> > > I have created a build for Apache Calcite 1.18.0, release candidate 1.
> > >
> > > Thanks to everyone who has contributed to this release.
> > > Since RC 0, we have fixed the following issues:
> > >
> > > * [CALCITE-2726] ReduceExpressionRule oversimplifies filter conditions
> > > containing nulls
> > > * [CALCITE-2670] Combine similar JSON aggregate functions in operator
> table
> > > * [CALCITE-2468] Validator throws IndexOutOfBoundsException when
> > > trying to infer operand type from STRUCT return type (Rong Rong)
> > >
> > > You can read the release notes here:
> > >
> https://github.com/apache/calcite/blob/branch-1.18/site/_docs/history.md
> > >
> > > The commit to be voted upon:
> > >
> http://git-wip-us.apache.org/repos/asf/calcite/commit/06d0526e9e58b88bb6722ae3e66789b9e60a70d1
> > >
> > > Its hash is 06d0526e9e58b88bb6722ae3e66789b9e60a70d1.
> > >
> > > The artifacts to be voted on are located here:
> > >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.18.0-rc1
> > >
> > > The hashes of the artifacts are as follows:
> > > src.tar.gz.sha256
> > > 88501d9c22c5cd28c2988a1f921fa112386ac819fb1dbcc5f68504b30b8d7dd7
> > >
> > > A staged Maven repository is available for review at:
> > >
> https://repository.apache.org/content/repositories/orgapachecalcite-1050
> > >
> > > Release artifacts are signed with the following key:
> > > https://people.apache.org/keys/committer/jhyde.asc
> > >
> > > Please vote on releasing this package as Apache Calcite 1.18.0.
> > >
> > > The vote is open for the next 108 hours (ending at 1pm Pacific on Mon
> 10th)
> > > and passes if a majority of at least three +1 PMC votes are cast.
> > >
> > > [ ] +1 Release this package as Apache Calcite 1.18.0
> > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1 Do not release this package because...
> > >
> > >
> > > Here is my vote:
> > >
> > > +1 (binding)
> > >
> > > Julian
> >
> >
>
Re: [VOTE] Release apache-calcite-1.18.0 (release candidate 1)
Posted by Enrico Olivelli <eo...@gmail.com>.
+1 (non binding)
- checked signature and checksum
- built from source, all tests pass on OracleJDK8 on Linux
- all tests from downstream project (HerdDB) are passing
Still great work !
Thank you Julian for driving the release
Enrico
Il giorno ven 7 dic 2018 alle ore 02:44 Francis Chuang
<fr...@apache.org> ha scritto:
>
> Thanks for making this available for voting, Julian!
>
> +1 (binding)
>
> Environment: Debian Sid, OpenJDK 11.0.1, maven 3.6.0 in a docker container
> - Verified GPG signature - OK
> - Verified SHA256 - OK
> - Ran "mvn -DskipTests clean install" - OK
> - Ran "mvn test" - OK
>
> I also tested using Alpine Linux:
> Environment: Alpine Linux 3.8, OpenJDK 8u181, maven 3.6.0 in a docker
> container
>
> - Verified GPG signature - OK
> - Verified SHA256 - OK
> - Ran "mvn -DskipTests clean install" - OK
> - Ran "mvn test" - FAILED
>
> The tests failed, but since OpenJDK 8 is not supported, this isn't an issue:
>
> [ERROR] Failures:
> [ERROR] OsAdapterTest.testFiles:146
> Expected: "type=d\ntype=f"
> but: was ""
> [INFO]
> [ERROR] Tests run: 59, Failures: 1, Errors: 0, Skipped: 23
> [INFO]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary for Calcite 1.18.0:
> [INFO]
> [INFO] Calcite ............................................ SUCCESS [
> 4.064 s]
> [INFO] Calcite Linq4j ..................................... SUCCESS [
> 10.991 s]
> [INFO] Calcite Core ....................................... SUCCESS
> [09:26 min]
> [INFO] Calcite Babel ...................................... SUCCESS [
> 6.333 s]
> [INFO] Calcite Cassandra .................................. SUCCESS
> [01:56 min]
> [INFO] Calcite Druid ...................................... SUCCESS [
> 5.862 s]
> [INFO] Calcite Elasticsearch .............................. SUCCESS
> [01:10 min]
> [INFO] Calcite Examples ................................... SUCCESS [
> 0.200 s]
> [INFO] Calcite Example CSV ................................ SUCCESS [
> 10.818 s]
> [INFO] Calcite Example Function ........................... SUCCESS [
> 5.801 s]
> [INFO] Calcite File ....................................... SUCCESS [
> 13.449 s]
> [INFO] Calcite Geode ...................................... SUCCESS [
> 18.890 s]
> [INFO] Calcite MongoDB .................................... SUCCESS [
> 19.340 s]
> [INFO] Calcite Pig ........................................ SUCCESS [
> 15.797 s]
> [INFO] Calcite Piglet ..................................... SUCCESS [
> 7.510 s]
> [INFO] Calcite Plus ....................................... FAILURE [
> 15.401 s]
> [INFO] Calcite Server ..................................... SKIPPED
> [INFO] Calcite Spark ...................................... SKIPPED
> [INFO] Calcite Splunk ..................................... SKIPPED
> [INFO] Calcite Ubenchmark ................................. SKIPPED
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 14:47 min
> [INFO] Finished at: 2018-12-06T23:14:07Z
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test
> (default-test) on project calcite-plus: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /apache-calcite-1.18.0-src/plus/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] -> [Help 1]
>
> Francis
>
> On 6/12/2018 7:18 pm, Julian Hyde wrote:
> > OK, let's try again.
> >
> > I have created a build for Apache Calcite 1.18.0, release candidate 1.
> >
> > Thanks to everyone who has contributed to this release.
> > Since RC 0, we have fixed the following issues:
> >
> > * [CALCITE-2726] ReduceExpressionRule oversimplifies filter conditions
> > containing nulls
> > * [CALCITE-2670] Combine similar JSON aggregate functions in operator table
> > * [CALCITE-2468] Validator throws IndexOutOfBoundsException when
> > trying to infer operand type from STRUCT return type (Rong Rong)
> >
> > You can read the release notes here:
> > https://github.com/apache/calcite/blob/branch-1.18/site/_docs/history.md
> >
> > The commit to be voted upon:
> > http://git-wip-us.apache.org/repos/asf/calcite/commit/06d0526e9e58b88bb6722ae3e66789b9e60a70d1
> >
> > Its hash is 06d0526e9e58b88bb6722ae3e66789b9e60a70d1.
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.18.0-rc1
> >
> > The hashes of the artifacts are as follows:
> > src.tar.gz.sha256
> > 88501d9c22c5cd28c2988a1f921fa112386ac819fb1dbcc5f68504b30b8d7dd7
> >
> > A staged Maven repository is available for review at:
> > https://repository.apache.org/content/repositories/orgapachecalcite-1050
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/jhyde.asc
> >
> > Please vote on releasing this package as Apache Calcite 1.18.0.
> >
> > The vote is open for the next 108 hours (ending at 1pm Pacific on Mon 10th)
> > and passes if a majority of at least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.18.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Julian
>
>
Re: [VOTE] Release apache-calcite-1.18.0 (release candidate 1)
Posted by Francis Chuang <fr...@apache.org>.
Thanks for making this available for voting, Julian!
+1 (binding)
Environment: Debian Sid, OpenJDK 11.0.1, maven 3.6.0 in a docker container
- Verified GPG signature - OK
- Verified SHA256 - OK
- Ran "mvn -DskipTests clean install" - OK
- Ran "mvn test" - OK
I also tested using Alpine Linux:
Environment: Alpine Linux 3.8, OpenJDK 8u181, maven 3.6.0 in a docker
container
- Verified GPG signature - OK
- Verified SHA256 - OK
- Ran "mvn -DskipTests clean install" - OK
- Ran "mvn test" - FAILED
The tests failed, but since OpenJDK 8 is not supported, this isn't an issue:
[ERROR] Failures:
[ERROR] OsAdapterTest.testFiles:146
Expected: "type=d\ntype=f"
but: was ""
[INFO]
[ERROR] Tests run: 59, Failures: 1, Errors: 0, Skipped: 23
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary for Calcite 1.18.0:
[INFO]
[INFO] Calcite ............................................ SUCCESS [
4.064 s]
[INFO] Calcite Linq4j ..................................... SUCCESS [
10.991 s]
[INFO] Calcite Core ....................................... SUCCESS
[09:26 min]
[INFO] Calcite Babel ...................................... SUCCESS [
6.333 s]
[INFO] Calcite Cassandra .................................. SUCCESS
[01:56 min]
[INFO] Calcite Druid ...................................... SUCCESS [
5.862 s]
[INFO] Calcite Elasticsearch .............................. SUCCESS
[01:10 min]
[INFO] Calcite Examples ................................... SUCCESS [
0.200 s]
[INFO] Calcite Example CSV ................................ SUCCESS [
10.818 s]
[INFO] Calcite Example Function ........................... SUCCESS [
5.801 s]
[INFO] Calcite File ....................................... SUCCESS [
13.449 s]
[INFO] Calcite Geode ...................................... SUCCESS [
18.890 s]
[INFO] Calcite MongoDB .................................... SUCCESS [
19.340 s]
[INFO] Calcite Pig ........................................ SUCCESS [
15.797 s]
[INFO] Calcite Piglet ..................................... SUCCESS [
7.510 s]
[INFO] Calcite Plus ....................................... FAILURE [
15.401 s]
[INFO] Calcite Server ..................................... SKIPPED
[INFO] Calcite Spark ...................................... SKIPPED
[INFO] Calcite Splunk ..................................... SKIPPED
[INFO] Calcite Ubenchmark ................................. SKIPPED
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 14:47 min
[INFO] Finished at: 2018-12-06T23:14:07Z
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test
(default-test) on project calcite-plus: There are test failures.
[ERROR]
[ERROR] Please refer to
/apache-calcite-1.18.0-src/plus/target/surefire-reports for the
individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
[date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
Francis
On 6/12/2018 7:18 pm, Julian Hyde wrote:
> OK, let's try again.
>
> I have created a build for Apache Calcite 1.18.0, release candidate 1.
>
> Thanks to everyone who has contributed to this release.
> Since RC 0, we have fixed the following issues:
>
> * [CALCITE-2726] ReduceExpressionRule oversimplifies filter conditions
> containing nulls
> * [CALCITE-2670] Combine similar JSON aggregate functions in operator table
> * [CALCITE-2468] Validator throws IndexOutOfBoundsException when
> trying to infer operand type from STRUCT return type (Rong Rong)
>
> You can read the release notes here:
> https://github.com/apache/calcite/blob/branch-1.18/site/_docs/history.md
>
> The commit to be voted upon:
> http://git-wip-us.apache.org/repos/asf/calcite/commit/06d0526e9e58b88bb6722ae3e66789b9e60a70d1
>
> Its hash is 06d0526e9e58b88bb6722ae3e66789b9e60a70d1.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.18.0-rc1
>
> The hashes of the artifacts are as follows:
> src.tar.gz.sha256
> 88501d9c22c5cd28c2988a1f921fa112386ac819fb1dbcc5f68504b30b8d7dd7
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1050
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jhyde.asc
>
> Please vote on releasing this package as Apache Calcite 1.18.0.
>
> The vote is open for the next 108 hours (ending at 1pm Pacific on Mon 10th)
> and passes if a majority of at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.18.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Julian