[GitHub] storm pull request #2142: MINOR: Fix pacemaker_state_factory.clj not compile...

[revans2 <gi...@git.apache.org>]

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2142#discussion_r119911355
  
    --- Diff: storm-core/src/clj/org/apache/storm/pacemaker/pacemaker_state_factory.clj ---
    @@ -106,16 +106,15 @@
     (defn get-pacemaker-write-client [conf servers client-pool]
       ;; Client should be created in case of an exception or first write call
       ;; Shutdown happens in the retry loop
    -  (try 
    -    (.waitUntilReady
    -     (let [client (get @client-pool (first @servers))]
    -       (if (nil? client)
    -         (do
    -           (swap! client-pool merge {(first @servers) (PacemakerClient. conf (first @servers))})
    -           (get @client-pool (first @servers)))
    -         client)))
    -    (catch Exception e
    -      (throw e))))
    +  (let [client (get @client-pool (first @servers))]
    +    (try
    +        (.waitUntilReady
    +            (let [] (if (nil? client)
    +                 (do (swap! client-pool merge {(first @servers) (PacemakerClient. conf (first @servers))})
    +                     (get @client-pool (first @servers)))
    +                      client)))
    +       (catch Exception e (throw e)))
    +    (get @client-pool (first @servers))))
    --- End diff --
    
    waitUntilReady is not actually needed because send will call it internally.  We can just skip calling it here all together.  This then lets us have something like ...
    
    ```
    (defn get-pacemaker-write-client [conf servers client-pool]
       ;; Client should be created in case of an exception or first write call
       ;; Shutdown happens in the retry loop
       (let [server (first @servers)]
              (or (get @client-pool server)
                  (get (swap! client-pool merge {server (PacemakerClient. conf server)}) server))))
    ```
    
    and we can then remove the update to PacemakerClient.java


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---