You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2009/09/23 01:03:16 UTC

[jira] Created: (HADOOP-6279) Add JVM memory usage to JvmMetrics

Add JVM memory usage to JvmMetrics
----------------------------------

                 Key: HADOOP-6279
                 URL: https://issues.apache.org/jira/browse/HADOOP-6279
             Project: Hadoop Common
          Issue Type: Improvement
    Affects Versions: 0.20.2, 0.21.0
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon
            Priority: Minor


The JvmMetrics currently publish memory usage from the MemoryMXBean. This is useful, but doesn't include the total heap size (eg as displayed in the JT Web UI).

It would be nice to expose Runtime.getRuntime().maxMemory() as part of JvmMetrics.

It seems that Runtime.getRuntime().totalMemory() (used by the JT for "memory used") is the same as the 'memHeapCommittedM' which already exists.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6279) Add JVM memory usage to JvmMetrics

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-6279:
--------------------------------

    Attachment: hadoop-6279.txt

> Add JVM memory usage to JvmMetrics
> ----------------------------------
>
>                 Key: HADOOP-6279
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6279
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.20.2, 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hadoop-6279.txt
>
>
> The JvmMetrics currently publish memory usage from the MemoryMXBean. This is useful, but doesn't include the total heap size (eg as displayed in the JT Web UI).
> It would be nice to expose Runtime.getRuntime().maxMemory() as part of JvmMetrics.
> It seems that Runtime.getRuntime().totalMemory() (used by the JT for "memory used") is the same as the 'memHeapCommittedM' which already exists.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6279) Add JVM memory usage to JvmMetrics

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763644#action_12763644 ] 

Hudson commented on HADOOP-6279:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #56 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/56/])
    . Add Runtime::maxMemory to JVM metrics. Contributed by Todd Lipcon


> Add JVM memory usage to JvmMetrics
> ----------------------------------
>
>                 Key: HADOOP-6279
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6279
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.20.2, 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: hadoop-6279.txt
>
>
> The JvmMetrics currently publish memory usage from the MemoryMXBean. This is useful, but doesn't include the total heap size (eg as displayed in the JT Web UI).
> It would be nice to expose Runtime.getRuntime().maxMemory() as part of JvmMetrics.
> It seems that Runtime.getRuntime().totalMemory() (used by the JT for "memory used") is the same as the 'memHeapCommittedM' which already exists.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6279) Add JVM memory usage to JvmMetrics

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-6279:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.22.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

+1

I committed this. Thanks, Todd!

> Add JVM memory usage to JvmMetrics
> ----------------------------------
>
>                 Key: HADOOP-6279
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6279
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.20.2, 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: hadoop-6279.txt
>
>
> The JvmMetrics currently publish memory usage from the MemoryMXBean. This is useful, but doesn't include the total heap size (eg as displayed in the JT Web UI).
> It would be nice to expose Runtime.getRuntime().maxMemory() as part of JvmMetrics.
> It seems that Runtime.getRuntime().totalMemory() (used by the JT for "memory used") is the same as the 'memHeapCommittedM' which already exists.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6279) Add JVM memory usage to JvmMetrics

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763972#action_12763972 ] 

Hudson commented on HADOOP-6279:
--------------------------------

Integrated in Hadoop-Common-trunk #122 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/122/])
    . Add Runtime::maxMemory to JVM metrics. Contributed by Todd Lipcon


> Add JVM memory usage to JvmMetrics
> ----------------------------------
>
>                 Key: HADOOP-6279
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6279
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.20.2, 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: hadoop-6279.txt
>
>
> The JvmMetrics currently publish memory usage from the MemoryMXBean. This is useful, but doesn't include the total heap size (eg as displayed in the JT Web UI).
> It would be nice to expose Runtime.getRuntime().maxMemory() as part of JvmMetrics.
> It seems that Runtime.getRuntime().totalMemory() (used by the JT for "memory used") is the same as the 'memHeapCommittedM' which already exists.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6279) Add JVM memory usage to JvmMetrics

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758543#action_12758543 ] 

Hadoop QA commented on HADOOP-6279:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12420321/hadoop-6279.txt
  against trunk revision 817823.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/63/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/63/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/63/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/63/console

This message is automatically generated.

> Add JVM memory usage to JvmMetrics
> ----------------------------------
>
>                 Key: HADOOP-6279
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6279
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.20.2, 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hadoop-6279.txt
>
>
> The JvmMetrics currently publish memory usage from the MemoryMXBean. This is useful, but doesn't include the total heap size (eg as displayed in the JT Web UI).
> It would be nice to expose Runtime.getRuntime().maxMemory() as part of JvmMetrics.
> It seems that Runtime.getRuntime().totalMemory() (used by the JT for "memory used") is the same as the 'memHeapCommittedM' which already exists.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6279) Add JVM memory usage to JvmMetrics

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-6279:
--------------------------------

    Status: Patch Available  (was: Open)

Does not include unit tests - this is an existing open issue HADOOP-3634. This patch is a one-liner, though.

Manual verification steps:
1) Launch daemon with NoEmitMetricsContext configured in hadoop-metrics.properties
2) Go to /metrics on web UI
3) Verify totalMemoryM is present

> Add JVM memory usage to JvmMetrics
> ----------------------------------
>
>                 Key: HADOOP-6279
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6279
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.20.2, 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hadoop-6279.txt
>
>
> The JvmMetrics currently publish memory usage from the MemoryMXBean. This is useful, but doesn't include the total heap size (eg as displayed in the JT Web UI).
> It would be nice to expose Runtime.getRuntime().maxMemory() as part of JvmMetrics.
> It seems that Runtime.getRuntime().totalMemory() (used by the JT for "memory used") is the same as the 'memHeapCommittedM' which already exists.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.