You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by robert burrell donkin <ro...@blueyonder.co.uk> on 2002/10/31 23:12:16 UTC
[digester] bug fix release?
we've had a request for a bug fix release and so that probably means that
we should have done one last week ;)
what needs doing?
bugs
====
#12997 Call the method as soon as last parameter is encountered
---------------------------------------------------------------
maybe someone (craig did some work on this before) might like to evaluate
the new patch.
#13098 digester performance
---------------------------
i don't want to apply this patch. reasons? 1. it would mean changes the
MethodUtils API just when i was about to deprecate the class and move the
actively developed version into lang. 2. once this move is complete, i
want to work on improving beanutils and MethodUtils performance. this
patch should not be necessary once these changes are made.
i'd be happy to mark this WONTFIX
#3893 multiple element body parts problem
-----------------------------------------
i think that in this case the method gets called more than once. so, i'd
say the behaviour is reasonable. the comment from emmanual berg
illustrates that it's hard to know exactly how this should be improved.
i'd be happy to mark this WONTFIX
- robert
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [digester] bug fix release?
Posted by Emmanuel Bourg <e....@cross-systems.fr>.
robert burrell donkin wrote:
> #12997 Call the method as soon as last parameter is encountered
> ---------------------------------------------------------------
> maybe someone (craig did some work on this before) might like to
> evaluate the new patch.
The new patch is just an update to work against the head of the CVS
repository, it still breaks Tomcat 4.1. I'm digging in tomcat's code to
understand what happens here.
> #3893 multiple element body parts problem
> -----------------------------------------
> i think that in this case the method gets called more than once. so, i'd
> say the behaviour is reasonable. the comment from emmanual berg
> illustrates that it's hard to know exactly how this should be improved.
>
> i'd be happy to mark this WONTFIX
Emmanuel BOURG ! not Berg ;)
For this bug i think it might work like the innerHTML function in
Javascript (that's the option 3 i exposed), that's a convenient way to
use HTML-like or XML structures as string parameters. Of course a
workaround is to use a <![CDATA[ .. ]]> section or maybe a different
namespace.
Emmanuel
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [digester] bug fix release?
Posted by Scott Sanders <sa...@apache.org>.
On Sat, Nov 02, 2002 at 03:05:06PM +0000, robert burrell donkin wrote:
> On Friday, November 1, 2002, at 12:05 AM, Scott Sanders wrote:
>
> <snip>
>
> >> #3893 multiple element body parts problem
> >> -----------------------------------------
> >> i think that in this case the method gets called more than once. so, i'd
> >> say the behaviour is reasonable. the comment from emmanual berg
> >> illustrates that it's hard to know exactly how this should be improved.
> >>
> >> i'd be happy to mark this WONTFIX
> >>
> >
> > +1
> >
> > I have taken care of this in the past by writing my own rule that waited
> > until end(). I would mark this as WONTFIX.
>
> i've marked this one as LATER.
>
> (i took another look and i might actually think about looking at solutions
> after this release has happened.)
>
The reason I wrote my own rule rather than changing/'fixing' the existing ones is that the existing ones would break in certain cases if it was to be changed.
I should be able to dig that rule back up and submit it though.
--
Scott Sanders - sanders@apache.org
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [digester] bug fix release?
Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
On Friday, November 1, 2002, at 12:05 AM, Scott Sanders wrote:
<snip>
>> #3893 multiple element body parts problem
>> -----------------------------------------
>> i think that in this case the method gets called more than once. so, i'd
>> say the behaviour is reasonable. the comment from emmanual berg
>> illustrates that it's hard to know exactly how this should be improved.
>>
>> i'd be happy to mark this WONTFIX
>>
>
> +1
>
> I have taken care of this in the past by writing my own rule that waited
> until end(). I would mark this as WONTFIX.
i've marked this one as LATER.
(i took another look and i might actually think about looking at solutions
after this release has happened.)
- robert
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [digester] bug fix release?
Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
On Friday, November 1, 2002, at 12:05 AM, Scott Sanders wrote:
> On Thu, Oct 31, 2002 at 10:12:16PM +0000, robert burrell donkin wrote:
>> we've had a request for a bug fix release and so that probably means that
>> we should have done one last week ;)
>>
>> what needs doing?
>>
>> bugs
>> ====
>>
>> #13098 digester performance
>> ---------------------------
>> i don't want to apply this patch. reasons? 1. it would mean changes the
>> MethodUtils API just when i was about to deprecate the class and move the
>> actively developed version into lang. 2. once this move is complete, i
>> want to work on improving beanutils and MethodUtils performance. this
>> patch should not be necessary once these changes are made.
>>
>> i'd be happy to mark this WONTFIX
>>
>
> -0. How long are we going to take to get the next lang out. I think
> this kind of sucks, but I guess I have to go with the flow.
hi scott
i've been thinking about this whilst i've been looking at MethodUtils.
really the method names are so poorly chosen and the contracts in the java
docs so badly designed that there probably won't be a method-for-method
correspondence with the new version in lang.
you know that i don't like this patch but if you feel strongly that it
should be applied and are willing to maintain the code in the
beanutils.MethodUtils version (until it's deprecated), then i won't stand
in your way.
so... the ball's in your court on this one.
- robert
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [digester] bug fix release?
Posted by Scott Sanders <sa...@apache.org>.
On Thu, Oct 31, 2002 at 10:12:16PM +0000, robert burrell donkin wrote:
> we've had a request for a bug fix release and so that probably means that
> we should have done one last week ;)
>
> what needs doing?
>
> bugs
> ====
>
> #13098 digester performance
> ---------------------------
> i don't want to apply this patch. reasons? 1. it would mean changes the
> MethodUtils API just when i was about to deprecate the class and move the
> actively developed version into lang. 2. once this move is complete, i
> want to work on improving beanutils and MethodUtils performance. this
> patch should not be necessary once these changes are made.
>
> i'd be happy to mark this WONTFIX
>
-0. How long are we going to take to get the next lang out. I think this kind of sucks, but I guess I have to go with the flow.
> #3893 multiple element body parts problem
> -----------------------------------------
> i think that in this case the method gets called more than once. so, i'd
> say the behaviour is reasonable. the comment from emmanual berg
> illustrates that it's hard to know exactly how this should be improved.
>
> i'd be happy to mark this WONTFIX
>
+1
I have taken care of this in the past by writing my own rule that waited until end(). I would mark this as WONTFIX.
--
Scott Sanders - sanders@apache.org
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [digester] RulesBase, tail match API doc patch
Posted by Janek Bogucki <ya...@studylink.com>.
On Friday 01 November 2002 6:22 pm, robert burrell donkin wrote:
> hi Janek
>
> thanks for finding this. i've committed a fix.
>
> just FYI, your patch wouldn't work since */ means the end of the comment.
> what's needed is to use a * entity.
>
> - robert
So it wasn't a typo after all!
-Janek
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [digester] RulesBase, tail match API doc patch
Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
hi Janek
thanks for finding this. i've committed a fix.
just FYI, your patch wouldn't work since */ means the end of the comment.
what's needed is to use a * entity.
- robert
On Friday, November 1, 2002, at 03:29 PM, Janek Bogucki wrote:
> This patch fixes a typo in the example tail match pattern in
> RulesBase.java.
>
> -Janek
>
> Index: RulesBase.java
> ===================================================================
> RCS file:
> /home/cvspublic/jakarta-
> commons/digester/src/java/org/apache/commons/digeste
> r/RulesBase.java,v
> retrieving revision 1.9
> diff -u -r1.9 RulesBase.java
> --- RulesBase.java 29 Oct 2002 20:17:11 -0000 1.9
> +++ RulesBase.java 1 Nov 2002 15:24:11 -0000
> @@ -80,7 +80,7 @@
> * <li><em>Exact Match</em> - A pattern "a/b/c" exactly matches a
> * <code><c></code> element, nested inside a
> <code><b></code>
> * element, which is nested inside an <code><a></code>
> element.</li>
> - * <li><em>Tail Match</em> - A pattern "*\/a/b" matches a
> + * <li><em>Tail Match</em> - A pattern "*/a/b" matches a
> * <code><b></code> element, nested inside an
> <code><a></code>
> * element, no matter how deeply the pair is nested.</li>
> * </ul>
>
>
> --
> To unsubscribe, e-mail: <mailto:commons-dev-unsubscribe@jakarta.apache.
> org>
> For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.
> org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
[digester] RulesBase, tail match API doc patch
Posted by Janek Bogucki <ya...@studylink.com>.
This patch fixes a typo in the example tail match pattern in RulesBase.java.
-Janek
Index: RulesBase.java
===================================================================
RCS file:
/home/cvspublic/jakarta-commons/digester/src/java/org/apache/commons/digeste
r/RulesBase.java,v
retrieving revision 1.9
diff -u -r1.9 RulesBase.java
--- RulesBase.java 29 Oct 2002 20:17:11 -0000 1.9
+++ RulesBase.java 1 Nov 2002 15:24:11 -0000
@@ -80,7 +80,7 @@
* <li><em>Exact Match</em> - A pattern "a/b/c" exactly matches a
* <code><c></code> element, nested inside a
<code><b></code>
* element, which is nested inside an <code><a></code>
element.</li>
- * <li><em>Tail Match</em> - A pattern "*\/a/b" matches a
+ * <li><em>Tail Match</em> - A pattern "*/a/b" matches a
* <code><b></code> element, nested inside an
<code><a></code>
* element, no matter how deeply the pair is nested.</li>
* </ul>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [digester] bug fix release?
Posted by "Craig R. McClanahan" <cr...@apache.org>.
On Thu, 31 Oct 2002, robert burrell donkin wrote:
> Date: Thu, 31 Oct 2002 22:12:16 +0000
> From: robert burrell donkin <ro...@blueyonder.co.uk>
> Reply-To: Jakarta Commons Developers List <co...@jakarta.apache.org>
> To: Jakarta Commons Developers <co...@jakarta.apache.org>
> Subject: [digester] bug fix release?
>
> we've had a request for a bug fix release and so that probably means that
> we should have done one last week ;)
>
> what needs doing?
>
> bugs
> ====
>
> #12997 Call the method as soon as last parameter is encountered
> ---------------------------------------------------------------
> maybe someone (craig did some work on this before) might like to evaluate
> the new patch.
>
I'll look again to double check, but the first proposed patch had
backwards compatibility problems, so at best we're probably talking about
additional Rule(s). I'd have to convince myself that the described use
case is compelling enough for a standard Rule first, though.
> #13098 digester performance
> ---------------------------
> i don't want to apply this patch. reasons? 1. it would mean changes the
> MethodUtils API just when i was about to deprecate the class and move the
> actively developed version into lang. 2. once this move is complete, i
> want to work on improving beanutils and MethodUtils performance. this
> patch should not be necessary once these changes are made.
>
> i'd be happy to mark this WONTFIX
>
I think that makes sense, with the explanation you give above. It might
technically be resolved as LATER though -- even though it will ultimately
get addressed in [lang] instead of [beanutils].
> #3893 multiple element body parts problem
> -----------------------------------------
> i think that in this case the method gets called more than once. so, i'd
> say the behaviour is reasonable. the comment from emmanual berg
> illustrates that it's hard to know exactly how this should be improved.
>
> i'd be happy to mark this WONTFIX
>
+1.
> - robert
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
Craig
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>