[GitHub] [skywalking] wu-sheng commented on a change in pull request #2928: Update ThrowableTransformer.java

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #2928: Update ThrowableTransformer.java
URL: https://github.com/apache/skywalking/pull/2928#discussion_r296227461
 
 

 ##########
 File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/util/ThrowableTransformer.java
 ##########
 @@ -58,6 +58,9 @@ private String printExceptionInfo(Throwable causeException) {
     }
 
     private boolean printStackElement(StackTraceElement[] stackTrace, AppendListener printListener) {
+        if (stackTrace.length == 0) {
+            return true;
 
 Review comment:
   Why return `true` could void OOM? If I am reading code right, this root cause is `Exception` is parent endless loop?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services